server/keymgmt.c (kh_reopen): Promote the happy path.
authorMark Wooding <mdw@distorted.org.uk>
Sat, 12 May 2018 21:20:36 +0000 (22:20 +0100)
committerMark Wooding <mdw@distorted.org.uk>
Fri, 25 Jan 2019 12:10:31 +0000 (12:10 +0000)
server/keymgmt.c

index 7386408..00c3295 100644 (file)
@@ -279,14 +279,13 @@ static int kh_reopen(keyhalf *kh)
           "io-error", "?ERRNO", A_END);
     DESTROY(kf);
     return (-1);
-  } else {
-    if (kh->kf) {
-      key_close(kh->kf);
-      DESTROY(kh->kf);
-    }
-    kh->kf = kf;
-    return (0);
   }
+  if (kh->kf) {
+    key_close(kh->kf);
+    DESTROY(kh->kf);
+  }
+  kh->kf = kf;
+  return (0);
 }
 
 /* --- @kh_init@ --- *