Remove the assert in CommitData.parse() function origin
authorCatalin Marinas <catalin.marinas@gmail.com>
Mon, 14 Feb 2011 17:24:10 +0000 (17:24 +0000)
committerCatalin Marinas <catalin.marinas@gmail.com>
Mon, 14 Feb 2011 17:24:10 +0000 (17:24 +0000)
When some unknown key/value pairs are found in the commit data, StGit
crashes. It looks like this can actually happen with the "encoding:
latin1" pair.

Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
stgit/lib/git.py

index 3378728..f5ea965 100644 (file)
@@ -404,8 +404,6 @@ class CommitData(Immutable, Repr):
                 cd = cd.set_author(Person.parse(value))
             elif key == 'committer':
                 cd = cd.set_committer(Person.parse(value))
-            else:
-                assert False
         assert False
 
 class Commit(GitObject):