simon [Fri, 12 Oct 2001 19:32:13 +0000 (19:32 +0000)]
Due to fears that an incompetent WinSock might allow localhost-
listening sockets to be talked to by non-local hosts, reinstate the
explicit peer address check on connection acceptance.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1306
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 26 Sep 2001 20:31:02 +0000 (20:31 +0000)]
Extra line in the help text to mention you can use a saved session
as well as a hostname.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1305
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 26 Sep 2001 20:29:03 +0000 (20:29 +0000)]
`Server got confused by' error messages now quote a packet type, so
I can start debugging as soon as I get one sent to me.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1304
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 21:08:24 +0000 (21:08 +0000)]
Fiddly fixes in code page handling
git-svn-id: svn://svn.tartarus.org/sgt/putty@1303
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 20:12:14 +0000 (20:12 +0000)]
Spelling fix. When the user hits `Browse' next to the `Private key'
box, they should see a file chooser labelled Select _Private_ Key
File, not Public!
git-svn-id: svn://svn.tartarus.org/sgt/putty@1302
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 20:07:55 +0000 (20:07 +0000)]
Another potential segfault fixed. Thanks RDB :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1301
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 20:07:12 +0000 (20:07 +0000)]
Tidy up a comment.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1300
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 20:05:06 +0000 (20:05 +0000)]
John Sullivan's patch to recreate the Pageant systray icon if
Explorer crashes and restarts while Pageant is running.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1299
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 25 Sep 2001 19:59:14 +0000 (19:59 +0000)]
Fix various fiddly little warnings.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1298
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 24 Sep 2001 22:00:46 +0000 (22:00 +0000)]
Restore Lars Gunnarsson's old link for iXplorer.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1295
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 23 Sep 2001 16:45:36 +0000 (16:45 +0000)]
Destroy DOS line endings and unnecessary redefinition of uint32.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1289
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 23 Sep 2001 11:57:10 +0000 (11:57 +0000)]
Oops - another missing file :-/
git-svn-id: svn://svn.tartarus.org/sgt/putty@1287
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 21:00:53 +0000 (21:00 +0000)]
Arrgh, there's always one. Actually check in the extra file :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1286
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 21:00:16 +0000 (21:00 +0000)]
Add extra explanatory comment about the DSA k generation.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1285
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 20:52:21 +0000 (20:52 +0000)]
Add support for DSA authentication in SSH2, following clever ideas
on how to get round the problem of generating a good k.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1284
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 17:34:10 +0000 (17:34 +0000)]
Pretty much finished writing the Config chapter.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1283
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 15:37:51 +0000 (15:37 +0000)]
Oops - that tweak had bad Buttress syntax. D'oh!
git-svn-id: svn://svn.tartarus.org/sgt/putty@1282
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 15:36:44 +0000 (15:36 +0000)]
Miscellaneous small documentation tweaks.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1281
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Sep 2001 15:19:43 +0000 (15:19 +0000)]
Correct capitalisation in one config option (Cyrillic Caps Lock).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1280
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 21 Sep 2001 17:54:29 +0000 (17:54 +0000)]
Ongoing pastes were being abandoned on any key-down event. Quite
apart from the debatable semantic sanity of abandoning mid-paste,
this was breaking Shift-paste (theoretically valid in any case,
actually necessary with xterm mouse reporting enabled) because when
you hold down Shift the window receives a steady stream of KEYDOWN
messages as the key auto-repeats. One of those is likely to show up
in mid-paste and scupper you. For the moment, this has been changed
so that only a key press that actually _generates session data_
aborts a paste. In future I plan to review just why we're doing this
anyway (it may be that paste-little-by-little was a response to
rubbish socket buffering, in which case we can dispense with it
completely now).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1279
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 19 Sep 2001 20:07:15 +0000 (20:07 +0000)]
Fix pasting of newlines in local line editing mode. Possibly not a
very _good_ fix; something might want doing after the release.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1277
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 19:41:07 +0000 (19:41 +0000)]
terminal.c's from_backend() no longer calls term_out(), because
term_out() can in turn call ldisc_send() which calls back to
from_backend() when local echo is enabled. This was giving rise to
crazy re-entrancy stuff and stack overflows. Instead from_backend()
deposits its data in a bufchain which term_out() empties the next
time it's called.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1276
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 19:04:21 +0000 (19:04 +0000)]
Fix flaky scrollbar update when scrollback was reset to bottom.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1275
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 18:59:37 +0000 (18:59 +0000)]
Selection point movement on scroll should move selanchor as well as
selstart and selend, otherwise all those worthy ideals go *foom*
while the mouse buttons are held down.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1274
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 18:51:10 +0000 (18:51 +0000)]
Reintroduce Cyrillic Caps Lock mode, which was in 0.51 but got
kicked out by the Unicode patch. It's not very good - only works
sanely on US keyboards - but it's no worse than it was in 0.51.
After 0.52 maybe I should fix it properly.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1273
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 18:40:00 +0000 (18:40 +0000)]
Fix the licence again. (Despite the copyright holders being more
numerous, it still only said _I_ would not be liable rather than
_everybody_ not being liable; also the resource file versions
weren't up to date.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1272
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 18 Sep 2001 18:16:56 +0000 (18:16 +0000)]
SSH back end should now be tolerant of garbage appearing in the data
stream after the actual SSH connection is finished. Some firewalls
add this for no good reason.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1271
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 15 Sep 2001 15:54:24 +0000 (15:54 +0000)]
Three more patches from RDB: one to make Atomica work right, one to
fiddle with the widths of characters in DBCS screen fonts, and (the
big one) one to enable a mode in which resizing the window locks the
terminal size and lets the font change, instead of vice versa. That
should shut up a few feature requests!
git-svn-id: svn://svn.tartarus.org/sgt/putty@1269
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 15 Sep 2001 14:58:26 +0000 (14:58 +0000)]
Cygwin build fixes: update the dependencies, add -DNO_SECURITY to
the Cygwin CFLAGS, and declare `struct ssh_channel' in ssh.h to
prevent gcc warning about scope-confined-to-parameter-list.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1268
cda61777-01e9-0310-a592-
d414129be87e
simon [Thu, 13 Sep 2001 18:24:51 +0000 (18:24 +0000)]
Christopher Allene's patch for going full-screen on Alt-Enter.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1267
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 12 Sep 2001 20:38:40 +0000 (20:38 +0000)]
Scrollback viewing position, and selection endpoints, now keep pace
with the scrollback movement. (The former is of course only
detectable when reset-scrollback-on-activity is disabled.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1266
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 12 Sep 2001 20:16:45 +0000 (20:16 +0000)]
PSFTP: when choosing a default destination filename for `get' and
`put', it makes more sense to pick the _basename_ of the source
rather than use the whole path - particularly when the latter might
cause us to try to use a DOS pathname like `f:\stuff' in a Unix (or
worse, such as VMS!) file system.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1265
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 12 Sep 2001 20:11:48 +0000 (20:11 +0000)]
psftp and pscp should disable all forwarding (ports, X, agent).
Partly because that's a good idea _anyway_, and partly because it
seems to be causing trouble. (Specifically, their pathetic attempt
to emulate plink's proper select handling seems to get confused when
the back end tries to open a local listening socket.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1264
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 10 Sep 2001 08:39:37 +0000 (08:39 +0000)]
Clarify the comment at the top of scp.c to make the licensing
situation more explicit.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1263
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 16:31:26 +0000 (16:31 +0000)]
Add the `pwd' command in PSFTP.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1262
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 16:29:51 +0000 (16:29 +0000)]
Add online help in PSFTP.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1261
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 15:41:58 +0000 (15:41 +0000)]
Modify the FIXME into a calculated risk. I don't like this, but I
don't like the thought of having to try to fix it either,
particularly when I can't tell whether it'll work or not without
reproducing the (probably phantom) problem. Gah. I wish WinSock
would give better documentation of possible error returns.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1260
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 14:47:29 +0000 (14:47 +0000)]
Be more careful of bombouts at the s_rdpkt level: if these happen
(for example SSH_MSG_DISCONNECT) we should avoid even calling
ssh_protocol.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1259
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 13:54:00 +0000 (13:54 +0000)]
Add the names of major contributors to the copyright statement. I've
been meaning to do this for _years_.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1258
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 10:41:42 +0000 (10:41 +0000)]
psftp is an interactive program and the ssh.c flags should reflect
this (so we get login banners and a little more verbosity during
authentication).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1257
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 10:35:56 +0000 (10:35 +0000)]
Oops - changing the prototype of statictext() affected puttygen.c too
git-svn-id: svn://svn.tartarus.org/sgt/putty@1256
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Sep 2001 09:58:20 +0000 (09:58 +0000)]
Roman Pompejus's patch (heavily hacked) for parametric log file
names with date, time and hostname automatically embedded.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1255
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Sep 2001 15:16:30 +0000 (15:16 +0000)]
Fix potential float screwup in scp percentage indicator. (Don't
compute (100*a)/b. Instead compute 100*(a/b), because that way
there's no chance that 100*a will become inexact enough to fail to
yield 100 when a==b.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1254
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Sep 2001 12:50:15 +0000 (12:50 +0000)]
Jacob's TIS / CCard authentication tweaks.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1253
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Sep 2001 12:37:48 +0000 (12:37 +0000)]
Jan Holmen Holsten's patch for drag-selects to scroll the scrollback.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1252
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Sep 2001 11:57:00 +0000 (11:57 +0000)]
Fix error message: couldn't load _private_ key, not public.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1251
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Sep 2001 10:33:56 +0000 (10:33 +0000)]
When we receive SSH_MSG_DISCONNECT, say so in an error box because
it's likely to be more helpful than `Strange packet received' or
whatever.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1250
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 23:02:07 +0000 (23:02 +0000)]
Fix to link_font() from RDB. I must get him to comment some of this :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1249
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 23:00:37 +0000 (23:00 +0000)]
RDB also points out we don't need the CJK `not recommended for
general use' wcwidth function, so we condition it out to save space.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1248
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:59:07 +0000 (22:59 +0000)]
Patch from RDB: Markus Kuhn has issued an updated version of his
wcwidth function.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1247
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:58:00 +0000 (22:58 +0000)]
Another patch from RDB: prevent luni_send from sending a particular
range of Unicode characters. Not entirely sure I understand this one
but I trust that RDB knows what he's talking about with Unicode.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1246
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:52:51 +0000 (22:52 +0000)]
RDB points out that when you memset a newly allocated structure to
zero, covering the size of the _structure_ rather than the size of
the pointer to it might help :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1245
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:51:52 +0000 (22:51 +0000)]
RDB's session logging patch: due to some ghastly special case, UTF-8
characters that failed the UTF-8 canonicality rules were being sent
to the session log twice. Sounds trivial, but I bet it'd have
confused anyone who turned on session logging precisely to track
down a canonicality bug :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1244
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:49:17 +0000 (22:49 +0000)]
Pedantry patch from RDB: sanitise header use, correct one comment
and remove an unused variable.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1243
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:45:05 +0000 (22:45 +0000)]
Patch from RDB: in the case where the protocol read from the
settings file is unrecognised (i.e. PuTTYtel reading PuTTY's
registry), fall back to the default _port_ as well as the default
protocol.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1242
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:43:31 +0000 (22:43 +0000)]
Patch from RDB: fix the failure to display window-resize pointers
when in raw mouse mode.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1241
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:41:38 +0000 (22:41 +0000)]
Patch from RDB: rename ISO-8859-12 to -13, add ISO-8859-16, and
update the year specifications on some of the ISO-8859 names.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1240
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:39:01 +0000 (22:39 +0000)]
Robert de Bath's asynchronous-connect patch. Helps a lot in port
forwarding; improves Event Log; and causes the PuTTY window to
appear earlier in the setup process.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1239
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 22:04:44 +0000 (22:04 +0000)]
Fix gratuitous assertion failure in Plink (ssh1_throttle_count was
being decremented far too many times).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1238
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 21:39:03 +0000 (21:39 +0000)]
Robert de Bath's `Patch.a_alt_key': clean up the handling of
Alt-Space, Alt-only and the System menu. It lets Windows do more of
the work, and also saves a static variable, so it must be good :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1237
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 21:07:15 +0000 (21:07 +0000)]
Use WM_SETREDRAW to disable incremental updates while the config box
is switching panels. Speeds things up hugely on slow systems.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1236
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 20:35:38 +0000 (20:35 +0000)]
Jacob's patch to cause Shift to return to copy-and-paste when xterm
mouse tracking is enabled. (This can be turned off if your app
really wants Shift+mouse, but it defaults to on for general
usefulness.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1235
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 20:32:33 +0000 (20:32 +0000)]
Oops, fix that fix. TranslateKey can return <0 and it needs to be
dealt with. I don't recall being told that; I should comment it at
some stage.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1234
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Sep 2001 20:18:55 +0000 (20:18 +0000)]
Fix mouse hiding on keypresses, which was failing due to the Unicode
patch having done something bizarre to the semantics of TranslateKey.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1233
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 22:04:19 +0000 (22:04 +0000)]
Fix the intermittent fault in the socket layer that was occasionally
bombing out X forwarding. It turns out to be a workaround for YET
ANOTHER useless WinSock implementation. Arrgh!
git-svn-id: svn://svn.tartarus.org/sgt/putty@1232
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 21:02:27 +0000 (21:02 +0000)]
Swap round the contents of the Translation panel. The codepage box
should be at the top because it's by _far_ the most important.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1231
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 21:01:04 +0000 (21:01 +0000)]
Unicode cleanup phase 2: we now reintroduce the ability to enter a
numeric code page, and also reinstate the direct-to-font zero
translation mode (but now under an actual _name_ rather than blank).
Also add CP437 to the list since at least one expatriate DOS user
wanted it; also select a sensible ISO or KOI codepage based on the
system locale.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1230
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 19:58:25 +0000 (19:58 +0000)]
Better yet, look for sftp-server on the user's PATH as well, which
allows individual users with shell access to install it without
reference to the admin.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1229
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 19:48:52 +0000 (19:48 +0000)]
PSFTP will now attempt to find /usr/[local]/lib/sftp-server if it
can't start the sftp subsystem. This should enable convenient sftp
access to SSH1-only systems: all the admin needs is to install
sftp-server in the right place.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1228
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 5 Sep 2001 19:33:12 +0000 (19:33 +0000)]
When pscp in SFTP mode does client-side matching of a server-side
wildcard, it's polite to let the user know if the wildcard didn't
match any file names.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1227
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 29 Aug 2001 08:56:26 +0000 (08:56 +0000)]
Fix segfault (should free act.buf not act.name, because the latter
might not point at the start of the former). Cheers Minefield :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1224
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 12:26:16 +0000 (12:26 +0000)]
stripslashes() should have been dealing with colons as well. I don't
_think_ there was an exploit (even if the server sends "c:foobar",
the client will not attempt to create "c:foobar"; instead it will
try to create ".\c:foobar" which will fail), but it's as well to be
sure.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1223
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 12:24:50 +0000 (12:24 +0000)]
Semantic fix in the X11 `authentication failed' error packet
construction. Doesn't actually affect anything right now, since the
bug was a failure to round a length up to the next multiple of 4 and
it so happens that our current message was exactly 40 bytes anyway
:-) But if we start giving a wider variety of messages one day then
it might be handy to be able to do them without gratuitous crashes.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1222
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 09:53:51 +0000 (09:53 +0000)]
Add documentation of the new PSCP `-unsafe' option and the
associated warning message.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1221
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 08:43:33 +0000 (08:43 +0000)]
D'oh! Putting keyboard-interactive authentication _before_ publickey
causes password login to occur on a server that supports password-
through-k-i. Of course when we use the new preference list mechanism
for selecting the order of authentications this will all become much
more sane, but for the moment I've put publickey back up to the top
and things seem to be happier.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1220
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 08:36:27 +0000 (08:36 +0000)]
Fix externally added SSH1 keys in Pageant. I have no idea how this
code _ever_ worked before! But it's been like this for four months
and nobody has noticed, including me. That's quite spooky.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1219
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 28 Aug 2001 08:08:43 +0000 (08:08 +0000)]
Fix various small compiler warnings, mostly unused local variables
git-svn-id: svn://svn.tartarus.org/sgt/putty@1218
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 17:40:03 +0000 (17:40 +0000)]
PuTTYgen: add an extra button to save a public key into a file
(as well as showing it for cut and paste). For SSH1, this feature is
largely cosmetic and added for orthogonality; it comes into its own
in SSH2, where it saves the Official One True Public Key Format as
specified in the draft spec, and more particularly as used by
ssh.com's product for authentication. Now that ssh-3.0.1 supports
RSA user keys, this is suddenly actually useful.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1217
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 16:58:47 +0000 (16:58 +0000)]
Fix handling of SSH2_MSG_CHANNEL_CLOSE, which was breaking in port
forwarding talking to ssh.com's ssh-3.0.1.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1216
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 15:59:37 +0000 (15:59 +0000)]
Port forwarding update: local-host-only listening sockets are now
done properly (by binding to INADDR_LOOPBACK) instead of hackishly
(by binding to INADDR_ANY, looking at the peer address when a
connection is accepted, and slamming the connection shut at that
point).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1215
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 15:55:44 +0000 (15:55 +0000)]
Add a couple of missing return values
git-svn-id: svn://svn.tartarus.org/sgt/putty@1214
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 15:13:14 +0000 (15:13 +0000)]
Port forwarding bug fix: we were unable to handle receiving
CHANNEL_OPEN_FAILURE messages, which occur when the remote side is
unable to open a forwarded network connection we have requested. (It
seems they _don't_ show up if you get something mundane like
Connection Refused - the channel is cheerfully opened and
immediately slammed shut - but they do if you try to connect to a
host that doesn't even exist. Try forwarding a port to
frogwibbler:4800 and see what you get.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1213
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 15:02:52 +0000 (15:02 +0000)]
Finally tighten up the server-side wildcard security hole, the
_right_ way. (SSWs are disabled by default and can be re-enabled
using `-unsafe', meaning that pscp will _never_ do anything
unexpected to your local file system unless you explicitly give
consent. The sftp-based variant will work fine because the
corresponding mechanism is _not_ unsafe.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1212
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 14:51:31 +0000 (14:51 +0000)]
Fix tiny bug in new sftp-mode wildcards: when there wasn't a leading
path component (just `host:*' rather than `host:directory/*') there
was trouble.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1211
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 10:24:55 +0000 (10:24 +0000)]
Minor modification: in remote->local non-recursive mode matching a
wildcard, we don't abandon ship completely if the wildcard matches a
directory; we just warn and carry on with the rest.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1210
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 27 Aug 2001 10:17:41 +0000 (10:17 +0000)]
Implemented a simple wildcard matching engine, and used it to
restore remote wildcard capability in sftp-style PSCP.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1209
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 18:32:28 +0000 (18:32 +0000)]
PSCP now uses the modern SFTP protocol if it can, and falls back to
scp1 if it can't. Currently not very tested - I checked it in as
soon as it completed a successful recursive copy in both directions.
Also, one known bug: you can't specify a remote wildcard, because by
the nature of SFTP we'll need to implement the wildcard engine on
the client side. I do intend to do this (and use the same wildcard
engine in PSFTP as well) but I haven't got round to it yet.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1208
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 15:45:55 +0000 (15:45 +0000)]
Arrgh; yet again I make my security checking too draconian to
actually get things done. I'm sure this is the second time I've
checked in this mistake :-/ Still, this time I've got right to the
bottom of the cause, and commented it clearly. Phew.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1207
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 15:32:51 +0000 (15:32 +0000)]
Oops. ^X^S comes _before_ `cvs commit'. Two more diagnostics gone :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1206
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 15:31:29 +0000 (15:31 +0000)]
Further tightening up in PSCP. Fixed a couple more holes whereby a
malicious SCP server could have written to areas other than the ones
the user requested; cleared up buffer overruns everywhere. Hopefully
we now do not use arbitrary buffer limits _anywhere_.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1205
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 14:53:51 +0000 (14:53 +0000)]
Preparatory work for allowing PSCP to work over SFTP as well as old-
style scp1. I've built a layer of abstraction covering all the gory
details of the old scp network protocol.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1204
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 11:35:11 +0000 (11:35 +0000)]
More upgrades to psftp: it now supports mv, chmod, reget and reput.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1203
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 26 Aug 2001 10:01:45 +0000 (10:01 +0000)]
D'oh, remove two rogue diagnostics
git-svn-id: svn://svn.tartarus.org/sgt/putty@1202
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 25 Aug 2001 20:02:02 +0000 (20:02 +0000)]
Remove gratuitous FIXME entries in cipher list. Oops, didn't mean to
check those in :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@1201
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 25 Aug 2001 20:01:36 +0000 (20:01 +0000)]
Fiddle with the registry format so that backwards compatibility is
natural and defaults are sensible.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1200
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 25 Aug 2001 19:33:33 +0000 (19:33 +0000)]
Jacob's patch for a drag-list to select SSH ciphers. Heavily hacked
by me to make the drag list behaviour slightly more intuitive.
WARNING: DO NOT LOOK AT pl_itemfrompt() IF YOU ARE SQUEAMISH.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1199
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 25 Aug 2001 17:09:23 +0000 (17:09 +0000)]
Extensive changes that _should_ fix the socket buffering problems,
by ceasing to listen on input channels if the corresponding output
channel isn't accepting data. Has had basic check-I-didn't-actually-
break-anything-too-badly testing, but hasn't been genuinely tested
in stress conditions (because concocting stress conditions is non-
trivial).
git-svn-id: svn://svn.tartarus.org/sgt/putty@1198
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 22 Aug 2001 20:23:49 +0000 (20:23 +0000)]
Oops - fix that fix :-/
git-svn-id: svn://svn.tartarus.org/sgt/putty@1197
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 22 Aug 2001 19:56:41 +0000 (19:56 +0000)]
Wording change: make it explicit that you can enter an IP address as
well as a hostname.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1196
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 22 Aug 2001 19:47:05 +0000 (19:47 +0000)]
Fix to allow more than one challenge/response pair during
keyboard-interactive authentication. UNTESTED except that I checked
it compiles. Will ask for testing from the user who complained.
git-svn-id: svn://svn.tartarus.org/sgt/putty@1195
cda61777-01e9-0310-a592-
d414129be87e