When manually initialising a 'struct RSAKey' due to loading an SSH1
authorsimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Tue, 13 Nov 2012 21:34:12 +0000 (21:34 +0000)
committersimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Tue, 13 Nov 2012 21:34:12 +0000 (21:34 +0000)
public key but not the private half, NULL out all the CRT-optimisation
fields as well as the private exponent pointer. Otherwise segfaults -
security-harmless, but annoying - can happen in freersakey() when we
notice they aren't null and try to free them.

git-svn-id: svn://svn.tartarus.org/sgt/putty@9705 cda61777-01e9-0310-a592-d414129be87e

cmdgen.c

index 86a548e..254ae6a 100644 (file)
--- a/cmdgen.c
+++ b/cmdgen.c
@@ -763,6 +763,9 @@ int main(int argc, char **argv)
                }
                ssh1key->comment = dupstr(origcomment);
                ssh1key->private_exponent = NULL;
+               ssh1key->p = NULL;
+               ssh1key->q = NULL;
+               ssh1key->iqmp = NULL;
            } else {
                ret = loadrsakey(infilename, ssh1key, passphrase, &error);
            }