Tiny patch from Martin Packman to fix a Windows handle leak in
authorsimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Mon, 28 Nov 2011 19:23:43 +0000 (19:23 +0000)
committersimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Mon, 28 Nov 2011 19:23:43 +0000 (19:23 +0000)
Pageant's IPC mechanism. It's incomplete (he sent a much more
comprehensive set of fixes that I haven't reviewed), but should be
adequate to mitigate a particular issue for Bazaar users.

git-svn-id: svn://svn.tartarus.org/sgt/putty@9355 cda61777-01e9-0310-a592-d414129be87e

windows/winpgnt.c

index e26621c..291593e 100644 (file)
@@ -1938,8 +1938,10 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT message,
                     }
 #endif
                    if (!EqualSid(mapowner, ourself) &&
-                        !EqualSid(mapowner, ourself2))
+                        !EqualSid(mapowner, ourself2)) {
+                        CloseHandle(filemap);
                        return 0;      /* security ID mismatch! */
+                    }
 #ifdef DEBUG_IPC
                    debug(("security stuff matched\n"));
 #endif