snew() always returns non-NULL, so checking if its return value is NULL
authorben <ben@cda61777-01e9-0310-a592-d414129be87e>
Wed, 3 Oct 2007 21:06:00 +0000 (21:06 +0000)
committerben <ben@cda61777-01e9-0310-a592-d414129be87e>
Wed, 3 Oct 2007 21:06:00 +0000 (21:06 +0000)
is pointless.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7758 cda61777-01e9-0310-a592-d414129be87e

ssh.c

diff --git a/ssh.c b/ssh.c
index 92d96f1..63aecbc 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -9228,15 +9228,13 @@ void *new_sock_channel(void *handle, Socket s)
     Ssh ssh = (Ssh) handle;
     struct ssh_channel *c;
     c = snew(struct ssh_channel);
-    c->ssh = ssh;
 
-    if (c) {
-       ssh2_channel_init(c);
-       c->halfopen = TRUE;
-       c->type = CHAN_SOCKDATA_DORMANT;/* identify channel type */
-       c->u.pfd.s = s;
-       add234(ssh->channels, c);
-    }
+    c->ssh = ssh;
+    ssh2_channel_init(c);
+    c->halfopen = TRUE;
+    c->type = CHAN_SOCKDATA_DORMANT;/* identify channel type */
+    c->u.pfd.s = s;
+    add234(ssh->channels, c);
     return c;
 }