XXX comment in the logic which sends failed password auth back to username
authorjacob <jacob@cda61777-01e9-0310-a592-d414129be87e>
Sat, 20 Nov 2004 17:47:40 +0000 (17:47 +0000)
committerjacob <jacob@cda61777-01e9-0310-a592-d414129be87e>
Sat, 20 Nov 2004 17:47:40 +0000 (17:47 +0000)
prompt for keyboard-interactive. I suspect we should do the same with that
method (especially given the apparent number of systems that use it for
regular password auth), but in the absence of systems to test against I've
not actually made the change. (I'm worried that the `partial success' field
might not be set correctly in a multi-stage authentication, for instance.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@4850 cda61777-01e9-0310-a592-d414129be87e

ssh.c

diff --git a/ssh.c b/ssh.c
index 461ade6..8c71e6d 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -5020,6 +5020,8 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                        logevent("Access denied");
                        if (s->type == AUTH_TYPE_PASSWORD &&
                            ssh->cfg.change_username) {
+                           /* XXX perhaps we should allow
+                            * keyboard-interactive to do this too? */
                            s->we_are_in = FALSE;
                            break;
                        }