Rename MP_IS* to MP_*P, for consistency's sake. Use these macros more often.

[u/mdw/catacomb] / f-binpoly.c

diff --git a/f-binpoly.c b/f-binpoly.c
index 45e1449..8fae42a 100644 (file)
--- a/f-binpoly.c
+++ b/f-binpoly.c
@@ -1,6 +1,6 @@
 /* -*-c-*-
  *
- * $Id: f-binpoly.c,v 1.7 2004/04/01 21:28:41 mdw Exp $
+ * $Id$
  *
  * Binary fields with polynomial basis representation
  *
@@ -27,38 +27,6 @@
  * MA 02111-1307, USA.
  */
 
-/*----- Revision history --------------------------------------------------* 
- *
- * $Log: f-binpoly.c,v $
- * Revision 1.7  2004/04/01 21:28:41  mdw
- * Normal basis support (translates to poly basis internally).  Rewrite
- * EC and prime group table generators in awk, so that they can reuse data
- * for repeated constants.
- *
- * Revision 1.6  2004/04/01 12:50:09  mdw
- * Add cyclic group abstraction, with test code.  Separate off exponentation
- * functions for better static linking.  Fix a buttload of bugs on the way.
- * Generally ensure that negative exponents do inversion correctly.  Add
- * table of standard prime-field subgroups.  (Binary field subgroups are
- * currently unimplemented but easy to add if anyone ever finds a good one.)
- *
- * Revision 1.5  2004/03/27 17:54:11  mdw
- * Standard curves and curve checking.
- *
- * Revision 1.4  2004/03/23 15:19:32  mdw
- * Test elliptic curves more thoroughly.
- *
- * Revision 1.3  2004/03/23 12:08:26  mdw
- * Random field-element selection.
- *
- * Revision 1.2  2004/03/21 22:52:06  mdw
- * Merge and close elliptic curve branch.
- *
- * Revision 1.1.2.1  2004/03/21 22:39:46  mdw
- * Elliptic curves on binary fields work.
- *
- */
-
 /*----- Header files ------------------------------------------------------*/
 
 #include <mLib/sub.h>
@@ -84,7 +52,7 @@ static void fdestroy(field *ff)
 static mp *frand(field *f, mp *d, grand *r)
   { return (mprand(d, f->nbits, r, 0)); }
 
-static int fzerop(field *ff, mp *x) { return (!MP_LEN(x)); }
+static int fzerop(field *ff, mp *x) { return (MP_ZEROP(x)); }
 
 static mp *fadd(field *ff, mp *d, mp *x, mp *y) { return (gf_add(d, x, y)); }
 
@@ -99,7 +67,7 @@ static mp *fsqr(field *ff, mp *d, mp *x) {
 }
 
 static mp *finv(field *ff, mp *d, mp *x)
-  { fctx *f = (fctx *)ff; gf_gcd(0, 0, &d, f->r.p, x); return (d); }
+  { fctx *f = (fctx *)ff; d = gf_modinv(d, x, f->r.p); return (d); }
 
 static mp *freduce(field *ff, mp *d, mp *x)
   { fctx *f = (fctx *)ff; return (gfreduce_do(&f->r, d, x)); }
@@ -112,7 +80,7 @@ static mp *fquadsolve(field *ff, mp *d, mp *x)
 
 /* --- Field operations table --- */
 
-static field_ops fops = {
+static const field_ops fops = {
   FTY_BINARY, "binpoly",
   fdestroy, frand, field_stdsamep,
   freduce, field_id,
@@ -171,7 +139,7 @@ static mp *fnout(field *ff, mp *d, mp *x)
 
 /* --- Field operations table --- */
 
-static field_ops fnops = {
+static const field_ops fnops = {
   FTY_BINARY, "binnorm",
   fndestroy, frand, fnsamep,
   fnin, fnout,