factorial: Fix usage message to fit in with conventions.

[u/mdw/catacomb] / group-exp.c

diff --git a/group-exp.c b/group-exp.c
index 72bd5a0..ca9cfb0 100644 (file)
--- a/group-exp.c
+++ b/group-exp.c
@@ -1,6 +1,6 @@
 /* -*-c-*-
  *
- * $Id: group-exp.c,v 1.1 2004/04/01 12:50:09 mdw Exp $
+ * $Id$
  *
  * Exponentiation for abstract groups
  *
@@ -27,18 +27,6 @@
  * MA 02111-1307, USA.
  */
 
-/*----- Revision history --------------------------------------------------* 
- *
- * $Log: group-exp.c,v $
- * Revision 1.1  2004/04/01 12:50:09  mdw
- * Add cyclic group abstraction, with test code.  Separate off exponentation
- * functions for better static linking.  Fix a buttload of bugs on the way.
- * Generally ensure that negative exponents do inversion correctly.  Add
- * table of standard prime-field subgroups.  (Binary field subgroups are
- * currently unimplemented but easy to add if anyone ever finds a good one.)
- *
- */
-
 /*----- Header files ------------------------------------------------------*/
 
 #include "group.h"
@@ -67,10 +55,10 @@ void group_stdexp(group *gg, ge *d, ge *x, mp *n)
   G_COPY(gg, d, gg->i);
   if (n->f & MP_BURN)
     G_BURN(gg, t);
-  if (MP_LEN(n) == 0)
+  if (MP_ZEROP(n))
     ;
   else {
-    if (n->f & MP_NEG)
+    if (MP_NEGP(n))
       G_INV(gg, t, t);
     if (MP_LEN(n) < EXP_THRESH)
       EXP_SIMPLE(d, t, n);
@@ -103,7 +91,7 @@ void group_stdmexp(group *gg, ge *d, const group_expfactor *f, size_t n)
   for (i = 0; i < n; i++) {
     ff[i].base = G_CREATE(gg);
     MP_SHRINK(f[i].exp);
-    if (f[i].exp->f & MP_NEG)
+    if (MP_NEGP(f[i].exp))
       G_INV(gg, ff[i].base, f[i].base);
     else
       G_COPY(gg, ff[i].base, f[i].base);