return (err);
}
+/* --- @p_updateaddr@ --- *
+ *
+ * Arguments: @peer *p@ = pointer to peer block
+ * @const addr *a@ = address to associate with this peer
+ *
+ * Returns: Zero if the address was changed; @+1@ if it was already
+ * right.
+ *
+ * Use: Updates our idea of @p@'s address.
+ */
+
+int p_updateaddr(peer *p, const addr *a)
+{
+ peer *q;
+ peer_byaddr *pa, *qa;
+ unsigned f;
+
+ /* --- Figure out how to proceed --- *
+ *
+ * If this address already belongs to a different peer, then swap the
+ * addresses over. This doesn't leave the displaced peer in an especially
+ * good state, but it ought to get sorted out soon enough.
+ */
+
+ pa = am_find(&byaddr, a, sizeof(peer_byaddr), &f);
+ if (f && pa->p == p)
+ return (+1);
+ else if (!f) {
+ T( trace(T_PEER, "peer: updating address for `%s'", p_name(p)); )
+ am_remove(&byaddr, p->byaddr);
+ p->byaddr = pa; p->spec.sa = *a; pa->p = p;
+ a_notify("NEWADDR", "?PEER", p, "?ADDR", a, A_END);
+ return (0);
+ } else {
+ q = pa->p; qa = p->byaddr;
+ T( trace(T_PEER, "peer: swapping addresses for `%s' and `%s'",
+ p_name(p), p_name(q)); )
+ q->byaddr = qa; qa->p = q; q->spec.sa = p->spec.sa;
+ p->byaddr = pa; pa->p = p; p->spec.sa = *a;
+ a_notify("NEWADDR", "?PEER", p, "?ADDR", a, A_END);
+ a_notify("NEWADDR", "?PEER", q, "?ADDR", &q->spec.sa, A_END);
+ return (0);
+ }
+}
+
/* --- @p_decrypt@ --- *
*
* Arguments: @peer **pp@ = pointer to peer to decrypt message from
int ty, buf *bin, buf *bout)
{
peer *p, *q;
- peer_byaddr *pa, *qa;
int err = KSERR_DECRYPT;
- unsigned f;
/* --- If we have a match on the source address then try that first --- */
return (-1);
}
- /* --- We found one that accepted, so update the peer's address --- *
- *
- * If we had an initial guess of which peer this packet came from -- i.e.,
- * @q@ is not null -- then swap the addresses over. This doesn't leave the
- * evicted peer in an especially good state, but it ought to get sorted out
- * soon enough.
- */
+ /* --- We found one that accepted, so update the peer's address --- */
if (!err) {
*pp = p;
- if (!q) {
- T( trace(T_PEER, "peer: updating address for `%s'", p_name(p)); )
- pa = am_find(&byaddr, a, sizeof(peer_byaddr), &f); assert(!f);
- am_remove(&byaddr, p->byaddr);
- p->byaddr = pa;
- pa->p = p;
- p->spec.sa = *a;
- a_notify("NEWADDR", "?PEER", p, "?ADDR", a, A_END);
- } else {
- T( trace(T_PEER, "peer: swapping addresses for `%s' and `%s'",
- p_name(p), p_name(q)); )
- pa = p->byaddr; qa = q->byaddr;
- pa->p = q; q->byaddr = pa; q->spec.sa = p->spec.sa;
- qa->p = p; p->byaddr = qa; p->spec.sa = *a;
- a_notify("NEWADDR", "?PEER", p, "?ADDR", a, A_END);
- a_notify("NEWADDR", "?PEER", q, "?ADDR", &q->spec.sa, A_END);
- }
+ p_updateaddr(p, a);
}
match:
static int p_dotxend(peer *p)
{
+ socklen_t sasz = addrsz(&p->spec.sa);
+
if (!BOK(&p->b)) {
a_warn("PEER", "?PEER", p, "packet-build-failed", A_END);
return (0);
IF_TRACING(T_PEER, trace_block(T_PACKET, "peer: sending packet",
BBASE(&p->b), BLEN(&p->b)); )
if (sendto(sock.fd, BBASE(&p->b), BLEN(&p->b),
- 0, &p->spec.sa.sa, p->spec.sasz) < 0) {
+ 0, &p->spec.sa.sa, sasz) < 0) {
a_warn("PEER", "?PEER", p, "socket-write-error", "?ERRNO", A_END);
return (0);
} else {