From: Jonas Fonseca <fonseca@diku.dk>
Date: Sun, 21 May 2006 01:18:56 +0000 (+0200)
Subject: Cache all queries for refs based on ID
X-Git-Tag: tig-0.4~70
X-Git-Url: https://git.distorted.org.uk/~mdw/tig/commitdiff_plain/1307df1af77c922db546e9743bf0839de55f676a

Cache all queries for refs based on ID

At least then they won't appear as a source of leaking and in the future
the main view can be reloaded without having to deal freeing them.
---

diff --git a/tig.c b/tig.c
index be165b9..faf9193 100644
--- a/tig.c
+++ b/tig.c
@@ -2197,39 +2197,57 @@ init_display(void)
 static struct ref *refs;
 static size_t refs_size;
 
+/* Id <-> ref store */
+static struct ref ***id_refs;
+static size_t id_refs_size;
+
 static struct ref **
 get_refs(char *id)
 {
-	struct ref **id_refs = NULL;
-	size_t id_refs_size = 0;
+	struct ref ***tmp_id_refs;
+	struct ref **ref_list = NULL;
+	size_t ref_list_size = 0;
 	size_t i;
 
+	for (i = 0; i < id_refs_size; i++)
+		if (!strcmp(id, id_refs[i][0]->id))
+			return id_refs[i];
+
+	tmp_id_refs = realloc(id_refs, (id_refs_size + 1) * sizeof(*id_refs));
+	if (!tmp_id_refs)
+		return NULL;
+
+	id_refs = tmp_id_refs;
+
 	for (i = 0; i < refs_size; i++) {
 		struct ref **tmp;
 
 		if (strcmp(id, refs[i].id))
 			continue;
 
-		tmp = realloc(id_refs, (id_refs_size + 1) * sizeof(*id_refs));
+		tmp = realloc(ref_list, (ref_list_size + 1) * sizeof(*ref_list));
 		if (!tmp) {
-			if (id_refs)
-				free(id_refs);
+			if (ref_list)
+				free(ref_list);
 			return NULL;
 		}
 
-		id_refs = tmp;
-		if (id_refs_size > 0)
-			id_refs[id_refs_size - 1]->next = 1;
-		id_refs[id_refs_size] = &refs[i];
+		ref_list = tmp;
+		if (ref_list_size > 0)
+			ref_list[ref_list_size - 1]->next = 1;
+		ref_list[ref_list_size] = &refs[i];
 
 		/* XXX: The properties of the commit chains ensures that we can
 		 * safely modify the shared ref. The repo references will
 		 * always be similar for the same id. */
-		id_refs[id_refs_size]->next = 0;
-		id_refs_size++;
+		ref_list[ref_list_size]->next = 0;
+		ref_list_size++;
 	}
 
-	return id_refs;
+	if (ref_list)
+		id_refs[id_refs_size++] = ref_list;
+
+	return ref_list;
 }
 
 static int