Introduce struct line and use it for view->line
[tig] / tig.c
diff --git a/tig.c b/tig.c
index 7e5f9ae..7fca9a8 100644 (file)
--- a/tig.c
+++ b/tig.c
@@ -113,11 +113,11 @@ enum request {
        REQ_TOGGLE_LINE_NUMBERS,
        REQ_VIEW_NEXT,
        REQ_VIEW_CLOSE,
+       REQ_NEXT,
+       REQ_PREVIOUS,
 
        REQ_MOVE_UP,
-       REQ_MOVE_UP_ENTER,
        REQ_MOVE_DOWN,
-       REQ_MOVE_DOWN_ENTER,
        REQ_MOVE_PAGE_UP,
        REQ_MOVE_PAGE_DOWN,
        REQ_MOVE_FIRST_LINE,
@@ -136,13 +136,7 @@ struct ref {
        unsigned int next:1;    /* For ref lists: are there more refs? */
 };
 
-struct commit {
-       char id[41];            /* SHA1 ID. */
-       char title[75];         /* The first line of the commit message. */
-       char author[75];        /* The author of the commit. */
-       struct tm time;         /* Date from the author ident. */
-       struct ref **refs;      /* Repository references; tags & branch heads. */
-};
+static struct ref **get_refs(char *id);
 
 
 /*
@@ -548,6 +542,11 @@ init_colors(void)
        }
 }
 
+struct line {
+       enum line_type type;
+       void *data;             /* User data */
+};
+
 
 /**
  * ENVIRONMENT VARIABLES
@@ -644,6 +643,7 @@ init_colors(void)
  **/
 
 struct view;
+struct view_ops;
 
 /* The display array of active views and the index of the current view. */
 static struct view *display[2];
@@ -652,6 +652,7 @@ static unsigned int current_view;
 #define foreach_view(view, i) \
        for (i = 0; i < ARRAY_SIZE(display) && (view = display[i]); i++)
 
+#define displayed_views()      (display[1] != NULL ? 2 : 1)
 
 /**
  * Current head and commit ID
@@ -668,25 +669,13 @@ static unsigned int current_view;
 static char ref_commit[SIZEOF_REF]     = "HEAD";
 static char ref_head[SIZEOF_REF]       = "HEAD";
 
-
 struct view {
        const char *name;       /* View name */
        const char *cmd_fmt;    /* Default command line format */
        const char *cmd_env;    /* Command line set via environment */
        const char *id;         /* Points to either of ref_{head,commit} */
-       size_t objsize;         /* Size of objects in the line index */
-
-       struct view_ops {
-               /* What type of content being displayed. Used in the
-                * title bar. */
-               const char *type;
-               /* Draw one line; @lineno must be < view->height. */
-               bool (*draw)(struct view *view, unsigned int lineno);
-               /* Read one line; updates view->line. */
-               bool (*read)(struct view *view, char *line);
-               /* Depending on view, change display based on current line. */
-               bool (*enter)(struct view *view);
-       } *ops;
+
+       struct view_ops *ops;   /* View operations */
 
        char cmd[SIZEOF_CMD];   /* Command buffer */
        char ref[SIZEOF_REF];   /* Hovered commit reference */
@@ -700,9 +689,13 @@ struct view {
        unsigned long offset;   /* Offset of the window top */
        unsigned long lineno;   /* Current line number */
 
+       /* If non-NULL, points to the view that opened this view. If this view
+        * is closed tig will switch back to the parent view. */
+       struct view *parent;
+
        /* Buffering */
        unsigned long lines;    /* Total number of lines */
-       void **line;            /* Line index; each line contains user data */
+       struct line *line;      /* Line index */
        unsigned int digits;    /* Number of digits in the lines member. */
 
        /* Loading */
@@ -710,14 +703,25 @@ struct view {
        time_t start_time;
 };
 
+struct view_ops {
+       /* What type of content being displayed. Used in the title bar. */
+       const char *type;
+       /* Draw one line; @lineno must be < view->height. */
+       bool (*draw)(struct view *view, struct line *line, unsigned int lineno);
+       /* Read one line; updates view->line. */
+       bool (*read)(struct view *view, struct line *prev, char *data);
+       /* Depending on view, change display based on current line. */
+       bool (*enter)(struct view *view, struct line *line);
+};
+
 static struct view_ops pager_ops;
 static struct view_ops main_ops;
 
-#define VIEW_STR(name, cmd, env, ref, objsize, ops) \
-       { name, cmd, #env, ref, objsize, ops }
+#define VIEW_STR(name, cmd, env, ref, ops) \
+       { name, cmd, #env, ref, ops }
 
-#define VIEW_(id, name, ops, ref, objsize) \
-       VIEW_STR(name, TIG_##id##_CMD,  TIG_##id##_CMD, ref, objsize, ops)
+#define VIEW_(id, name, ops, ref) \
+       VIEW_STR(name, TIG_##id##_CMD,  TIG_##id##_CMD, ref, ops)
 
 /**
  * Views
@@ -750,23 +754,32 @@ static struct view_ops main_ops;
  **/
 
 static struct view views[] = {
-       VIEW_(MAIN,  "main",  &main_ops,  ref_head,   sizeof(struct commit)),
-       VIEW_(DIFF,  "diff",  &pager_ops, ref_commit, sizeof(char)),
-       VIEW_(LOG,   "log",   &pager_ops, ref_head,   sizeof(char)),
-       VIEW_(HELP,  "help",  &pager_ops, "static",   sizeof(char)),
-       VIEW_(PAGER, "pager", &pager_ops, "static",   sizeof(char)),
+       VIEW_(MAIN,  "main",  &main_ops,  ref_head),
+       VIEW_(DIFF,  "diff",  &pager_ops, ref_commit),
+       VIEW_(LOG,   "log",   &pager_ops, ref_head),
+       VIEW_(HELP,  "help",  &pager_ops, "static"),
+       VIEW_(PAGER, "pager", &pager_ops, "static"),
 };
 
 #define VIEW(req) (&views[(req) - REQ_OFFSET - 1])
 
 
+static bool
+draw_view_line(struct view *view, unsigned int lineno)
+{
+       if (view->offset + lineno >= view->lines)
+               return FALSE;
+
+       return view->ops->draw(view, &view->line[view->offset + lineno], lineno);
+}
+
 static void
 redraw_view_from(struct view *view, int lineno)
 {
        assert(0 <= lineno && lineno < view->height);
 
        for (; lineno < view->height; lineno++) {
-               if (!view->ops->draw(view, lineno))
+               if (!draw_view_line(view, lineno))
                        break;
        }
 
@@ -809,14 +822,27 @@ update_view_title(struct view *view)
        else
                wprintw(view->title, "[%s]", view->name);
 
-       if (view->lines) {
+       if (view->lines || view->pipe) {
+               unsigned int lines = view->lines
+                                  ? (view->lineno + 1) * 100 / view->lines
+                                  : 0;
+
                wprintw(view->title, " - %s %d of %d (%d%%)",
                        view->ops->type,
                        view->lineno + 1,
                        view->lines,
-                       (view->lineno + 1) * 100 / view->lines);
+                       lines);
+       }
+
+       if (view->pipe) {
+               time_t secs = time(NULL) - view->start_time;
+
+               /* Three git seconds are a long time ... */
+               if (secs > 2)
+                       wprintw(view->title, " %lds", secs);
        }
 
+
        wrefresh(view->title);
 }
 
@@ -850,11 +876,8 @@ resize_display(void)
        offset = 0;
 
        foreach_view (view, i) {
-               /* Keep the height of all view->win windows one larger than is
-                * required so that the cursor can wrap-around on the last line
-                * without scrolling the window. */
                if (!view->win) {
-                       view->win = newwin(view->height + 1, 0, offset, 0);
+                       view->win = newwin(view->height, 0, offset, 0);
                        if (!view->win)
                                die("Failed to create %s view", view->name);
 
@@ -865,7 +888,7 @@ resize_display(void)
                                die("Failed to create title window");
 
                } else {
-                       wresize(view->win, view->height + 1, view->width);
+                       wresize(view->win, view->height, view->width);
                        mvwin(view->win,   offset, 0);
                        mvwin(view->title, offset + view->height, 0);
                        wrefresh(view->win);
@@ -894,7 +917,7 @@ redraw_display(void)
 
 /* Scrolling backend */
 static void
-do_scroll_view(struct view *view, int lines)
+do_scroll_view(struct view *view, int lines, bool redraw)
 {
        /* The rendering expects the new offset. */
        view->offset += lines;
@@ -913,7 +936,7 @@ do_scroll_view(struct view *view, int lines)
                wscrl(view->win, lines);
 
                for (; line < end; line++) {
-                       if (!view->ops->draw(view, line))
+                       if (!draw_view_line(view, line))
                                break;
                }
        }
@@ -921,7 +944,7 @@ do_scroll_view(struct view *view, int lines)
        /* Move current line into the view. */
        if (view->lineno < view->offset) {
                view->lineno = view->offset;
-               view->ops->draw(view, 0);
+               draw_view_line(view, 0);
 
        } else if (view->lineno >= view->offset + view->height) {
                if (view->lineno == view->offset + view->height) {
@@ -931,11 +954,14 @@ do_scroll_view(struct view *view, int lines)
                        wclrtoeol(view->win);
                }
                view->lineno = view->offset + view->height - 1;
-               view->ops->draw(view, view->lineno - view->offset);
+               draw_view_line(view, view->lineno - view->offset);
        }
 
        assert(view->offset <= view->lineno && view->lineno < view->lines);
 
+       if (!redraw)
+               return;
+
        redrawwin(view->win);
        wrefresh(view->win);
        report("");
@@ -978,12 +1004,12 @@ scroll_view(struct view *view, enum request request)
                die("request %d not handled in switch", request);
        }
 
-       do_scroll_view(view, lines);
+       do_scroll_view(view, lines, TRUE);
 }
 
 /* Cursor moving */
 static void
-move_view(struct view *view, enum request request)
+move_view(struct view *view, enum request request, bool redraw)
 {
        int steps;
 
@@ -1007,12 +1033,10 @@ move_view(struct view *view, enum request request)
                break;
 
        case REQ_MOVE_UP:
-       case REQ_MOVE_UP_ENTER:
                steps = -1;
                break;
 
        case REQ_MOVE_DOWN:
-       case REQ_MOVE_DOWN_ENTER:
                steps = 1;
                break;
 
@@ -1039,7 +1063,7 @@ move_view(struct view *view, enum request request)
 
                wmove(view->win, prev_lineno, 0);
                wclrtoeol(view->win);
-               view->ops->draw(view, prev_lineno);
+               draw_view_line(view,  prev_lineno);
        }
 
        /* Check whether the view needs to be scrolled */
@@ -1057,12 +1081,15 @@ move_view(struct view *view, enum request request)
                        }
                }
 
-               do_scroll_view(view, steps);
+               do_scroll_view(view, steps, redraw);
                return;
        }
 
        /* Draw the current line */
-       view->ops->draw(view, view->lineno - view->offset);
+       draw_view_line(view, view->lineno - view->offset);
+
+       if (!redraw)
+               return;
 
        redrawwin(view->win);
        wrefresh(view->win);
@@ -1074,11 +1101,27 @@ move_view(struct view *view, enum request request)
  * Incremental updating
  */
 
+static void
+end_update(struct view *view)
+{
+       if (!view->pipe)
+               return;
+       set_nonblocking_input(FALSE);
+       if (view->pipe == stdin)
+               fclose(view->pipe);
+       else
+               pclose(view->pipe);
+       view->pipe = NULL;
+}
+
 static bool
 begin_update(struct view *view)
 {
        const char *id = view->id;
 
+       if (view->pipe)
+               end_update(view);
+
        if (opt_cmd[0]) {
                string_copy(view->cmd, opt_cmd);
                opt_cmd[0] = 0;
@@ -1115,8 +1158,8 @@ begin_update(struct view *view)
                int i;
 
                for (i = 0; i < view->lines; i++)
-                       if (view->line[i])
-                               free(view->line[i]);
+                       if (view->line[i].data)
+                               free(view->line[i].data);
 
                free(view->line);
                view->line = NULL;
@@ -1127,25 +1170,12 @@ begin_update(struct view *view)
        return TRUE;
 }
 
-static void
-end_update(struct view *view)
-{
-       if (!view->pipe)
-               return;
-       set_nonblocking_input(FALSE);
-       if (view->pipe == stdin)
-               fclose(view->pipe);
-       else
-               pclose(view->pipe);
-       view->pipe = NULL;
-}
-
 static bool
 update_view(struct view *view)
 {
        char buffer[BUFSIZ];
        char *line;
-       void **tmp;
+       struct line *tmp;
        /* The number of lines to read. If too low it will cause too much
         * redrawing (and possible flickering), if too high responsiveness
         * will suffer. */
@@ -1168,10 +1198,14 @@ update_view(struct view *view)
        while ((line = fgets(buffer, sizeof(buffer), view->pipe))) {
                int linelen = strlen(line);
 
+               struct line *prev = view->lines
+                                 ? &view->line[view->lines - 1]
+                                 : NULL;
+
                if (linelen)
                        line[linelen - 1] = 0;
 
-               if (!view->ops->read(view, line))
+               if (!view->ops->read(view, prev, line))
                        goto alloc_error;
 
                if (lines-- == 1)
@@ -1212,8 +1246,6 @@ update_view(struct view *view)
                goto end;
 
        } else if (feof(view->pipe)) {
-               time_t secs = time(NULL) - view->start_time;
-
                if (view == VIEW(REQ_VIEW_HELP)) {
                        const char *msg = TIG_HELP;
 
@@ -1228,8 +1260,7 @@ update_view(struct view *view)
                        goto end;
                }
 
-               report("Loaded %d lines in %ld second%s", view->lines, secs,
-                      secs == 1 ? "" : "s");
+               report("");
                goto end;
        }
 
@@ -1257,21 +1288,8 @@ open_view(struct view *prev, enum request request, enum open_flags flags)
        bool split = !!(flags & OPEN_SPLIT);
        bool reload = !!(flags & OPEN_RELOAD);
        struct view *view = VIEW(request);
-       struct view *displayed;
-       int nviews;
-
-       /* Cycle between displayed views and count the views. */
-       foreach_view (displayed, nviews) {
-               if (prev != view &&
-                   view == displayed &&
-                   !strcmp(view->vid, prev->vid)) {
-                       current_view = nviews;
-                       /* Blur out the title of the previous view. */
-                       update_view_title(prev);
-                       report("");
-                       return;
-               }
-       }
+       int nviews = displayed_views();
+       struct view *base_view = display[0];
 
        if (view == prev && nviews == 1 && !reload) {
                report("Already in %s view", view->name);
@@ -1295,7 +1313,11 @@ open_view(struct view *prev, enum request request, enum open_flags flags)
                display[current_view] = view;
        }
 
-       resize_display();
+       /* Resize the view when switching between split- and full-screen,
+        * or when switching between two different full-screen views. */
+       if (nviews != displayed_views() ||
+           (nviews == 1 && base_view != display[0]))
+               resize_display();
 
        if (split && prev->lineno - prev->offset >= prev->height) {
                /* Take the title line into account. */
@@ -1303,24 +1325,25 @@ open_view(struct view *prev, enum request request, enum open_flags flags)
 
                /* Scroll the view that was split if the current line is
                 * outside the new limited view. */
-               do_scroll_view(prev, lines);
+               do_scroll_view(prev, lines, TRUE);
        }
 
        if (prev && view != prev) {
-               /* "Blur" the previous view. */
-               if (!backgrounded)
-                       update_view_title(prev);
-
                /* Continue loading split views in the background. */
                if (!split)
                        end_update(prev);
+               else if (!backgrounded)
+                       /* "Blur" the previous view. */
+                       update_view_title(prev);
+
+               view->parent = prev;
        }
 
        if (view->pipe) {
                /* Clear the old view and let the incremental updating refill
                 * the screen. */
                wclear(view->win);
-               report("Loading...");
+               report("");
        } else {
                redraw_view(view);
                if (view == VIEW(REQ_VIEW_HELP))
@@ -1352,7 +1375,7 @@ view_driver(struct view *view, enum request request)
        case REQ_MOVE_PAGE_DOWN:
        case REQ_MOVE_FIRST_LINE:
        case REQ_MOVE_LAST_LINE:
-               move_view(view, request);
+               move_view(view, request, TRUE);
                break;
 
        case REQ_SCROLL_LINE_DOWN:
@@ -1370,9 +1393,22 @@ view_driver(struct view *view, enum request request)
                open_view(view, request, OPEN_DEFAULT);
                break;
 
-       case REQ_MOVE_UP_ENTER:
-       case REQ_MOVE_DOWN_ENTER:
-               move_view(view, request);
+       case REQ_NEXT:
+       case REQ_PREVIOUS:
+               request = request == REQ_NEXT ? REQ_MOVE_DOWN : REQ_MOVE_UP;
+
+               if (view == VIEW(REQ_VIEW_DIFF) &&
+                   view->parent == VIEW(REQ_VIEW_MAIN)) {
+                       bool redraw = display[1] == view;
+
+                       view = view->parent;
+                       move_view(view, request, redraw);
+                       if (redraw)
+                               update_view_title(view);
+               } else {
+                       move_view(view, request, TRUE);
+                       break;
+               }
                /* Fall-through */
 
        case REQ_ENTER:
@@ -1380,11 +1416,11 @@ view_driver(struct view *view, enum request request)
                        report("Nothing to enter");
                        break;
                }
-               return view->ops->enter(view);
+               return view->ops->enter(view, &view->line[view->lineno]);
 
        case REQ_VIEW_NEXT:
        {
-               int nviews = display[1] ? 2 : 1;
+               int nviews = displayed_views();
                int next_view = (current_view + 1) % nviews;
 
                if (next_view == current_view) {
@@ -1432,11 +1468,11 @@ view_driver(struct view *view, enum request request)
                return TRUE;
 
        case REQ_VIEW_CLOSE:
-               if (display[1]) {
-                       view = display[(current_view + 1) % ARRAY_SIZE(display)];
+               if (view->parent) {
                        memset(display, 0, sizeof(display));
                        current_view = 0;
-                       display[current_view] = view;
+                       display[current_view] = view->parent;
+                       view->parent = NULL;
                        resize_display();
                        redraw_display();
                        break;
@@ -1456,28 +1492,22 @@ view_driver(struct view *view, enum request request)
 
 
 /*
- * View backend handlers
+ * Pager backend
  */
 
 static bool
-pager_draw(struct view *view, unsigned int lineno)
+pager_draw(struct view *view, struct line *line, unsigned int lineno)
 {
-       enum line_type type;
-       char *line;
-       int linelen;
+       char *text = line->data;
+       enum line_type type = line->type;
+       int textlen = strlen(text);
        int attr;
 
-       if (view->offset + lineno >= view->lines)
-               return FALSE;
-
-       line = view->line[view->offset + lineno];
-       type = get_line_type(line);
-
        wmove(view->win, lineno, 0);
 
        if (view->offset + lineno == view->lineno) {
                if (type == LINE_COMMIT) {
-                       string_copy(view->ref, line + 7);
+                       string_copy(view->ref, text + 7);
                        string_copy(ref_commit, view->ref);
                }
 
@@ -1488,8 +1518,6 @@ pager_draw(struct view *view, unsigned int lineno)
        attr = get_line_attr(type);
        wattrset(view->win, attr);
 
-       linelen = strlen(line);
-
        if (opt_line_number || opt_tab_size < TABSIZE) {
                static char spaces[] = "                    ";
                int col_offset = 0, col = 0;
@@ -1509,66 +1537,65 @@ pager_draw(struct view *view, unsigned int lineno)
                        col_offset = view->digits + 2;
                }
 
-               while (line && col_offset + col < view->width) {
+               while (text && col_offset + col < view->width) {
                        int cols_max = view->width - col_offset - col;
-                       char *text = line;
+                       char *pos = text;
                        int cols;
 
-                       if (*line == '\t') {
+                       if (*text == '\t') {
+                               text++;
                                assert(sizeof(spaces) > TABSIZE);
-                               line++;
-                               text = spaces;
+                               pos = spaces;
                                cols = opt_tab_size - (col % opt_tab_size);
 
                        } else {
-                               line = strchr(line, '\t');
-                               cols = line ? line - text : strlen(text);
+                               text = strchr(text, '\t');
+                               cols = line ? text - pos : strlen(pos);
                        }
 
-                       waddnstr(view->win, text, MIN(cols, cols_max));
+                       waddnstr(view->win, pos, MIN(cols, cols_max));
                        col += cols;
                }
 
        } else {
                int col = 0, pos = 0;
 
-               for (; pos < linelen && col < view->width; pos++, col++)
-                       if (line[pos] == '\t')
+               for (; pos < textlen && col < view->width; pos++, col++)
+                       if (text[pos] == '\t')
                                col += TABSIZE - (col % TABSIZE) - 1;
 
-               waddnstr(view->win, line, pos);
+               waddnstr(view->win, text, pos);
        }
 
        return TRUE;
 }
 
 static bool
-pager_read(struct view *view, char *line)
+pager_read(struct view *view, struct line *prev, char *line)
 {
        /* Compress empty lines in the help view. */
        if (view == VIEW(REQ_VIEW_HELP) &&
-           !*line &&
-           view->lines &&
-           !*((char *) view->line[view->lines - 1]))
+           !*line && prev && !*((char *) prev->data))
                return TRUE;
 
-       view->line[view->lines] = strdup(line);
-       if (!view->line[view->lines])
+       view->line[view->lines].data = strdup(line);
+       if (!view->line[view->lines].data)
                return FALSE;
 
+       view->line[view->lines].type = get_line_type(line);
+
        view->lines++;
        return TRUE;
 }
 
 static bool
-pager_enter(struct view *view)
+pager_enter(struct view *view, struct line *line)
 {
-       char *line = view->line[view->lineno];
        int split = 0;
 
        if ((view == VIEW(REQ_VIEW_LOG) ||
-            view == VIEW(REQ_VIEW_LOG)) &&
-           get_line_type(line) == LINE_COMMIT) {
+            view == VIEW(REQ_VIEW_PAGER)) &&
+           line->type == LINE_COMMIT) {
                open_view(view, REQ_VIEW_DIFF, OPEN_SPLIT);
                split = 1;
        }
@@ -1595,23 +1622,29 @@ static struct view_ops pager_ops = {
 };
 
 
-static struct ref **get_refs(char *id);
+/*
+ * Main view backend
+ */
+
+struct commit {
+       char id[41];            /* SHA1 ID. */
+       char title[75];         /* The first line of the commit message. */
+       char author[75];        /* The author of the commit. */
+       struct tm time;         /* Date from the author ident. */
+       struct ref **refs;      /* Repository references; tags & branch heads. */
+};
 
 static bool
-main_draw(struct view *view, unsigned int lineno)
+main_draw(struct view *view, struct line *line, unsigned int lineno)
 {
        char buf[DATE_COLS + 1];
-       struct commit *commit;
+       struct commit *commit = line->data;
        enum line_type type;
        int col = 0;
        size_t timelen;
        size_t authorlen;
        int trimmed;
 
-       if (view->offset + lineno >= view->lines)
-               return FALSE;
-
-       commit = view->line[view->offset + lineno];
        if (!*commit->author)
                return FALSE;
 
@@ -1695,7 +1728,7 @@ main_draw(struct view *view, unsigned int lineno)
 
 /* Reads git log --pretty=raw output and parses it into the commit struct. */
 static bool
-main_read(struct view *view, char *line)
+main_read(struct view *view, struct line *prev, char *line)
 {
        enum line_type type = get_line_type(line);
        struct commit *commit;
@@ -1708,7 +1741,7 @@ main_read(struct view *view, char *line)
 
                line += STRING_SIZE("commit ");
 
-               view->line[view->lines++] = commit;
+               view->line[view->lines++].data = commit;
                string_copy(commit->id, line);
                commit->refs = get_refs(commit->id);
                break;
@@ -1718,12 +1751,16 @@ main_read(struct view *view, char *line)
                char *ident = line + STRING_SIZE("author ");
                char *end = strchr(ident, '<');
 
+               if (!prev)
+                       break;
+
+               commit = prev->data;
+
                if (end) {
                        for (; end > ident && isspace(end[-1]); end--) ;
                        *end = 0;
                }
 
-               commit = view->line[view->lines - 1];
                string_copy(commit->author, ident);
 
                /* Parse epoch and timezone */
@@ -1757,13 +1794,12 @@ main_read(struct view *view, char *line)
                break;
        }
        default:
-               /* We should only ever end up here if there has already been a
-                * commit line, however, be safe. */
-               if (view->lines == 0)
+               if (!prev)
                        break;
 
+               commit = prev->data;
+
                /* Fill in the commit title if it has not already been set. */
-               commit = view->line[view->lines - 1];
                if (commit->title[0])
                        break;
 
@@ -1782,9 +1818,11 @@ main_read(struct view *view, char *line)
 }
 
 static bool
-main_enter(struct view *view)
+main_enter(struct view *view, struct line *line)
 {
-       open_view(view, REQ_VIEW_DIFF, OPEN_SPLIT);
+       enum open_flags flags = display[0] == view ? OPEN_SPLIT : OPEN_DEFAULT;
+
+       open_view(view, REQ_VIEW_DIFF, flags);
        return TRUE;
 }
 
@@ -1821,8 +1859,20 @@ static struct keymap keymap[] = {
         *      Switch to pager view.
         * h::
         *      Show man page.
+        **/
+       { 'm',          REQ_VIEW_MAIN },
+       { 'd',          REQ_VIEW_DIFF },
+       { 'l',          REQ_VIEW_LOG },
+       { 'p',          REQ_VIEW_PAGER },
+       { 'h',          REQ_VIEW_HELP },
+
+       /**
+        * View manipulation
+        * ~~~~~~~~~~~~~~~~~
         * q::
-        *      Close view if multiple views are open, else quit.
+        *      Close view, if multiple views are open it will jump back to the
+        *      previous view in the view stack. If it is the last open view it
+        *      will quit. Use 'Q' to quit all views at once.
         * Enter::
         *      This key is "context sensitive" depending on what view you are
         *      currently in. When in log view on a commit line or in the main
@@ -1830,30 +1880,28 @@ static struct keymap keymap[] = {
         *      pressing Enter will simply scroll the view one line down.
         * Tab::
         *      Switch to next view.
+        * Up::
+        *      This key is "context sensitive" and will move the cursor one
+        *      line up. However, uf you opened a diff view from the main view
+        *      (split- or full-screen) it will change the cursor to point to
+        *      the previous commit in the main view and update the diff view
+        *      to display it.
+        * Down::
+        *      Similar to 'Up' but will move down.
         **/
-       { 'm',          REQ_VIEW_MAIN },
-       { 'd',          REQ_VIEW_DIFF },
-       { 'l',          REQ_VIEW_LOG },
-       { 'p',          REQ_VIEW_PAGER },
-       { 'h',          REQ_VIEW_HELP },
-
        { 'q',          REQ_VIEW_CLOSE },
        { KEY_TAB,      REQ_VIEW_NEXT },
        { KEY_RETURN,   REQ_ENTER },
+       { KEY_UP,       REQ_PREVIOUS },
+       { KEY_DOWN,     REQ_NEXT },
 
        /**
         * Cursor navigation
         * ~~~~~~~~~~~~~~~~~
-        * Up::
+        * j::
         *      Move cursor one line up.
-        * Down::
-        *      Move cursor one line down.
         * k::
-        *      Move cursor one line up and enter. When used in the main view
-        *      this will always show the diff of the current commit in the
-        *      split diff view.
-        * j::
-        *      Move cursor one line down and enter.
+        *      Move cursor one line down.
         * PgUp::
         * b::
         * -::
@@ -1866,10 +1914,8 @@ static struct keymap keymap[] = {
         * End::
         *      Jump to last line.
         **/
-       { KEY_UP,       REQ_MOVE_UP },
-       { KEY_DOWN,     REQ_MOVE_DOWN },
-       { 'k',          REQ_MOVE_UP_ENTER },
-       { 'j',          REQ_MOVE_DOWN_ENTER },
+       { 'k',          REQ_MOVE_UP },
+       { 'j',          REQ_MOVE_DOWN },
        { KEY_HOME,     REQ_MOVE_FIRST_LINE },
        { KEY_END,      REQ_MOVE_LAST_LINE },
        { KEY_NPAGE,    REQ_MOVE_PAGE_DOWN },
@@ -1963,7 +2009,7 @@ unicode_width(unsigned long c)
            || c == 0x2329
            || c == 0x232a
            || (c >= 0x2e80  && c <= 0xa4cf && c != 0x303f)
-                                               /* CJK ... Yi */
+                                               /* CJK ... Yi */
            || (c >= 0xac00  && c <= 0xd7a3)    /* Hangul Syllables */
            || (c >= 0xf900  && c <= 0xfaff)    /* CJK Compatibility Ideographs */
            || (c >= 0xfe30  && c <= 0xfe6f)    /* CJK Compatibility Forms */
@@ -2205,39 +2251,57 @@ init_display(void)
 static struct ref *refs;
 static size_t refs_size;
 
+/* Id <-> ref store */
+static struct ref ***id_refs;
+static size_t id_refs_size;
+
 static struct ref **
 get_refs(char *id)
 {
-       struct ref **id_refs = NULL;
-       size_t id_refs_size = 0;
+       struct ref ***tmp_id_refs;
+       struct ref **ref_list = NULL;
+       size_t ref_list_size = 0;
        size_t i;
 
+       for (i = 0; i < id_refs_size; i++)
+               if (!strcmp(id, id_refs[i][0]->id))
+                       return id_refs[i];
+
+       tmp_id_refs = realloc(id_refs, (id_refs_size + 1) * sizeof(*id_refs));
+       if (!tmp_id_refs)
+               return NULL;
+
+       id_refs = tmp_id_refs;
+
        for (i = 0; i < refs_size; i++) {
                struct ref **tmp;
 
                if (strcmp(id, refs[i].id))
                        continue;
 
-               tmp = realloc(id_refs, (id_refs_size + 1) * sizeof(*id_refs));
+               tmp = realloc(ref_list, (ref_list_size + 1) * sizeof(*ref_list));
                if (!tmp) {
-                       if (id_refs)
-                               free(id_refs);
+                       if (ref_list)
+                               free(ref_list);
                        return NULL;
                }
 
-               id_refs = tmp;
-               if (id_refs_size > 0)
-                       id_refs[id_refs_size - 1]->next = 1;
-               id_refs[id_refs_size] = &refs[i];
+               ref_list = tmp;
+               if (ref_list_size > 0)
+                       ref_list[ref_list_size - 1]->next = 1;
+               ref_list[ref_list_size] = &refs[i];
 
                /* XXX: The properties of the commit chains ensures that we can
                 * safely modify the shared ref. The repo references will
                 * always be similar for the same id. */
-               id_refs[id_refs_size]->next = 0;
-               id_refs_size++;
+               ref_list[ref_list_size]->next = 0;
+               ref_list_size++;
        }
 
-       return id_refs;
+       if (ref_list)
+               id_refs[id_refs_size++] = ref_list;
+
+       return ref_list;
 }
 
 static int
@@ -2305,9 +2369,6 @@ load_refs(void)
 
        pclose(pipe);
 
-       if (refs_size == 0)
-               die("Not a git repository");
-
        return OK;
 }
 
@@ -2361,6 +2422,10 @@ main(int argc, char *argv[])
        if (load_refs() == ERR)
                die("Failed to load refs.");
 
+       /* Require a git repository unless when running in pager mode. */
+       if (refs_size == 0 && opt_request != REQ_VIEW_PAGER)
+               die("Not a git repository");
+
        for (i = 0; i < ARRAY_SIZE(views) && (view = &views[i]); i++)
                view->cmd_env = getenv(view->cmd_env);
 
@@ -2528,6 +2593,9 @@ main(int argc, char *argv[])
  *   outside the current view causing bad wrapping. Same goes
  *   for title and status windows.
  *
+ * - The cursor can wrap-around on the last line and cause the
+ *   window to scroll.
+ *
  * TODO
  * ----
  * Features that should be explored.