Drop -D_FILE_OFFSET_BITS=64 support for now
authorFredrik Fornwall <fredrik@fornwall.net>
Fri, 7 Jul 2017 01:52:46 +0000 (03:52 +0200)
committerFredrik Fornwall <fredrik@fornwall.net>
Fri, 7 Jul 2017 01:52:46 +0000 (03:52 +0200)
commit2173f7301d6332bbdb7c9c4d1aa25ddce6ff5964
treeeef5f20d4ffce1232057fd2e7812282fc51ddcec
parentfd11c5fbfaadceb2e3c18b96e30db070044eaebd
Drop -D_FILE_OFFSET_BITS=64 support for now

32-bit android uses 32-bit off_t by default. When building with
-D_FILE_OFFSET_BITS=64 with unified headers off_t are promoted
to 64-bit, but there are bugs in the toolchain and spotty support
for it in the platform (not all functions are available until
android-24, and the platform zlib is compiled with 32-bit off_t).

Also, unless every library&program is rebuilt with 64-bit off_t,
including user-built ones, we risk a mismatch between programs and
libraries which can cause serious (but sometimes subtle) runtime
failures.

As -D_FILE_OFFSET_BITS=64 is not that important for most users
(with mariadb requiring it as an exception), we drop the support
for now by patching it away in <sys/cdefs.h>.
build-package.sh
ndk-patches/sys-cdefs.h.patch [new file with mode: 0644]
packages/coreutils/build.sh
packages/mariadb/build.sh
packages/ndk-sysroot/build.sh
packages/openssh/build.sh