X-Git-Url: https://git.distorted.org.uk/~mdw/termux-packages/blobdiff_plain/8dc2f0d66c661c426ba23b0adf7a2d91df5edebd..320bee67d1f27bf221c6066be4ae8a4179b11ca1:/packages/clang/build.sh

diff --git a/packages/clang/build.sh b/packages/clang/build.sh
index 125314c9..4a622508 100644
--- a/packages/clang/build.sh
+++ b/packages/clang/build.sh
@@ -11,6 +11,12 @@ TERMUX_PKG_DEPENDS="binutils, ncurses, ndk-sysroot, ndk-stl, libgcc"
 # Replace gcc since gcc is deprecated by google on android and is not maintained upstream.
 TERMUX_PKG_CONFLICTS=gcc
 TERMUX_PKG_REPLACES=gcc
+# We would like to use LLVM_LINK_LLVM_DYLIB instead of BUILD_SHARED_LIBS,
+# as http://llvm.org/docs/CMake.html says
+# "BUILD_SHARED_LIBS is only recommended for use by LLVM developers. If you want
+# to build LLVM as a shared library, you should use the LLVM_BUILD_LLVM_DYLIB option."
+# and using fewer shared libraries will make it easier to split up llvm from clang.
+# But switching to LLVM_LINK_LLVM_DYLIB currently causes linker errors.
 TERMUX_PKG_EXTRA_CONFIGURE_ARGS="
 -DLLVM_ENABLE_PIC=ON
 -DLLVM_BUILD_TESTS=OFF
@@ -36,6 +42,7 @@ termux_step_post_extract_package () {
 }
 
 termux_step_host_build () {
+	termux_setup_cmake
 	cmake -G "Unix Makefiles" $TERMUX_PKG_SRCDIR \
 		-DLLVM_BUILD_TESTS=OFF \
 		-DLLVM_INCLUDE_TESTS=OFF