From: Karl Hasselström Date: Tue, 7 Nov 2006 19:03:47 +0000 (+0000) Subject: Generate shorter patch names X-Git-Tag: v0.14.3~436 X-Git-Url: https://git.distorted.org.uk/~mdw/stgit/commitdiff_plain/f9a2b5dae96b05071105a9b84e98bcc8942960ed Generate shorter patch names Not all commits are blessed with a really short first-line summary in their commit messages. This means that we shouldn't blindly take the entire first line of the comment, since that sometimes results in truly spectacular patch names. I chose 30 characters as a reasonable value, considering that we don't yet have any tab-completion on patch names. There's probably not much point in making it configurable. Signed-off-by: Karl Hasselström --- diff --git a/stgit/commands/common.py b/stgit/commands/common.py index 88b1b94..0e1bb44 100644 --- a/stgit/commands/common.py +++ b/stgit/commands/common.py @@ -286,10 +286,10 @@ def name_email_date(address): def make_patch_name(msg): """Return a string to be used as a patch name. This is generated - from the top line of the string passed as argument. - """ + from the first 30 characters of the top line of the string passed + as argument.""" if not msg: return None - subject_line = msg.lstrip().split('\n', 1)[0].lower() + subject_line = msg[:30].lstrip().split('\n', 1)[0].lower() return re.sub('[\W]+', '-', subject_line).strip('-')