[PATCH] Really fix import --edit invoking editor twice
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Fri, 2 Sep 2005 09:25:30 +0000 (11:25 +0200)
committerCatalin Marinas <catalin.marinas@gmail.com>
Fri, 2 Sep 2005 16:17:25 +0000 (17:17 +0100)
commit95742cfc06832ec30191567c5b83247a28f6ec64
treeb89a2c5c3935c8c24864a885ae884b39a011c0c9
parent6ad48e4898f40d58a236de38f0f49a9f8bfb7ab2
[PATCH] Really fix import --edit invoking editor twice

A typo prevented the previous patch for this (commit
9d15ccd85e36ef5cd554aaf98f1c37ef0433697f) from working (edit is never used,
you should have set options.edit). Ah, nice Python! No var declarations and
these are the effects (yes, I reproduced this).

However, if the description is left empty, refresh_patch will again invoke
the editor. Also, with --showpatch, the first invocation shows the topmost
patch, not the one to be imported.

So better stop new_patch from invoking the editor, and call it only on
refresh.

Btw, clean the old unused "edit" parameter of Series.new_patch.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
stgit/commands/imprt.py
stgit/stack.py