X-Git-Url: https://git.distorted.org.uk/~mdw/stgit/blobdiff_plain/d650d6ed4c969d0d5127544e5236f83e21608ca5..6dd8fafabb5b8e266a85f13c8851ca8a66a1a405:/stgit/commands/mail.py diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py index 762829c..4a4158a 100644 --- a/stgit/commands/mail.py +++ b/stgit/commands/mail.py @@ -15,12 +15,13 @@ along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA """ -import sys, os, re, time, datetime, smtplib +import sys, os, re, time, datetime, socket, smtplib, getpass import email, email.Utils, email.Header from optparse import OptionParser, make_option from stgit.commands.common import * from stgit.utils import * +from stgit.out import * from stgit import stack, git, version, templates from stgit.config import config @@ -28,10 +29,11 @@ from stgit.config import config help = 'send a patch or series of patches by e-mail' usage = """%prog [options] [] [] [..] -Send a patch or a range of patches by e-mail using the 'smtpserver' -configuration option. The From address and the e-mail format are -generated from the template file passed as argument to '--template' -(defaulting to '.git/patchmail.tmpl' or +Send a patch or a range of patches by e-mail using the SMTP server +specified by the 'stgit.smtpserver' configuration option, or the +'--smtp-server' command line option. The From address and the e-mail +format are generated from the template file passed as argument to +'--template' (defaulting to '.git/patchmail.tmpl' or '~/.stgit/templates/patchmail.tmpl' or '/usr/share/stgit/templates/patchmail.tmpl'). @@ -53,31 +55,40 @@ replies to a different e-mail by using the '--refid' option. SMTP authentication is also possible with '--smtp-user' and '--smtp-password' options, also available as configuration settings: -'smtpuser' and 'smtppassword'. +'smtpuser' and 'smtppassword'. TLS encryption can be enabled by +'--smtp-tls' option and 'smtptls' setting. -The patch e-mail template accepts the following variables: +The following variables are accepted by both the preamble and the +patch e-mail templates: - %(patch)s - patch name - %(sender)s - 'sender' or 'authname ' as per the config file - %(shortdescr)s - the first line of the patch description - %(longdescr)s - the rest of the patch description, after the first line - %(diff)s - unified diff of the patch %(diffstat)s - diff statistics - %(version)s - ' version' string passed on the command line (or empty) - %(prefix)s - 'prefix ' string passed on the command line + %(number)s - empty if only one patch is sent or ' patchnr/totalnr' %(patchnr)s - patch number + %(sender)s - 'sender' or 'authname ' as per the config file %(totalnr)s - total number of patches to be sent - %(number)s - empty if only one patch is sent or ' patchnr/totalnr' - %(fromauth)s - 'From: author\\n\\n' if different from sender - %(authname)s - author's name - %(authemail)s - author's email + %(version)s - ' version' string passed on the command line (or empty) + +In addition to the common variables, the preamble e-mail template +accepts the following: + + %(shortlog)s - first line of each patch description, listed by author + +In addition to the common variables, the patch e-mail template accepts +the following: + %(authdate)s - patch creation date - %(commname)s - committer's name + %(authemail)s - author's email + %(authname)s - author's name %(commemail)s - committer's e-mail + %(commname)s - committer's name + %(diff)s - unified diff of the patch + %(fromauth)s - 'From: author\\n\\n' if different from sender + %(longdescr)s - the rest of the patch description, after the first line + %(patch)s - patch name + %(prefix)s - 'prefix ' string passed on the command line + %(shortdescr)s - the first line of the patch description""" -For the preamble e-mail template, only the %(sender)s, %(version)s, -%(patchnr)s, %(totalnr)s and %(number)s variables are supported.""" - +directory = DirectoryHasRepository() options = [make_option('-a', '--all', help = 'e-mail all the applied patches', action = 'store_true'), @@ -96,6 +107,9 @@ options = [make_option('-a', '--all', make_option('--noreply', help = 'do not send subsequent messages as replies', action = 'store_true'), + make_option('--unrelated', + help = 'send patches without sequence numbering', + action = 'store_true'), make_option('-v', '--version', metavar = 'VERSION', help = 'add VERSION to the [PATCH ...] prefix'), make_option('--prefix', metavar = 'PREFIX', @@ -114,12 +128,19 @@ options = [make_option('-a', '--all', help = 'sleep for SECONDS between e-mails sending'), make_option('--refid', help = 'use REFID as the reference id'), + make_option('--smtp-server', metavar = 'HOST[:PORT]', + help = 'SMTP server to use for sending mail'), make_option('-u', '--smtp-user', metavar = 'USER', help = 'username for SMTP authentication'), make_option('-p', '--smtp-password', metavar = 'PASSWORD', help = 'username for SMTP authentication'), + make_option('-T', '--smtp-tls', + help = 'use SMTP with TLS encryption', + action = 'store_true'), make_option('-b', '--branch', help = 'use BRANCH instead of the default one'), + make_option('-O', '--diff-opts', + help = 'options to pass to git-diff'), make_option('-m', '--mbox', help = 'generate an mbox file instead of sending', action = 'store_true')] @@ -160,7 +181,7 @@ def __parse_addresses(msg): return (from_addr_list[0], to_addr_list) def __send_message(smtpserver, from_addr, to_addr_list, msg, sleep, - smtpuser, smtppassword): + smtpuser, smtppassword, use_tls): """Send the message using the given SMTP server """ try: @@ -172,9 +193,16 @@ def __send_message(smtpserver, from_addr, to_addr_list, msg, sleep, try: if smtpuser and smtppassword: s.ehlo() + if use_tls: + if not hasattr(socket, 'ssl'): + raise CmdException, "cannot use TLS - no SSL support in Python" + s.starttls() + s.ehlo() s.login(smtpuser, smtppassword) - s.sendmail(from_addr, to_addr_list, msg) + result = s.sendmail(from_addr, to_addr_list, msg) + if len(result): + print "mail server refused delivery for the following recipients: %s" % result # give recipients a chance of receiving patches in the correct order time.sleep(sleep) except Exception, err: @@ -223,7 +251,7 @@ def __get_signers_list(msg): """ addr_list = [] - r = re.compile('^(signed-off-by|acked-by):\s+(.+)$', re.I) + r = re.compile('^(signed-off-by|acked-by|cc):\s+(.+)$', re.I) for line in msg.split('\n'): m = r.match(line) if m: @@ -272,22 +300,7 @@ def __edit_message(msg): f.write(msg) f.close() - # the editor - editor = config.get('stgit.editor') - if editor: - pass - elif 'EDITOR' in os.environ: - editor = os.environ['EDITOR'] - else: - editor = 'vi' - editor += ' %s' % fname - - print 'Invoking the editor: "%s"...' % editor, - sys.stdout.flush() - err = os.system(editor) - if err: - raise CmdException, 'editor failed, exit code: %d' % err - print 'done' + call_editor(fname) # read the message back f = file(fname) @@ -296,7 +309,7 @@ def __edit_message(msg): return msg -def __build_cover(tmpl, total_nr, msg_id, options): +def __build_cover(tmpl, patches, msg_id, options): """Build the cover message (series description) to be sent via SMTP """ sender = __get_sender() @@ -309,11 +322,15 @@ def __build_cover(tmpl, total_nr, msg_id, options): if options.prefix: prefix_str = options.prefix + ' ' else: - prefix_str = '' + confprefix = config.get('stgit.mail.prefix') + if confprefix: + prefix_str = confprefix + ' ' + else: + prefix_str = '' - total_nr_str = str(total_nr) + total_nr_str = str(len(patches)) patch_nr_str = '0'.zfill(len(total_nr_str)) - if total_nr > 1: + if len(patches) > 1: number_str = ' %s/%s' % (patch_nr_str, total_nr_str) else: number_str = '' @@ -329,7 +346,12 @@ def __build_cover(tmpl, total_nr, msg_id, options): 'prefix': prefix_str, 'patchnr': patch_nr_str, 'totalnr': total_nr_str, - 'number': number_str} + 'number': number_str, + 'shortlog': stack.shortlog(crt_series.get_patch(p) + for p in patches), + 'diffstat': git.diffstat( + rev1 = git_id('%s//bottom' % patches[0]), + rev2 = git_id('%s//top' % patches[-1]))} try: msg_string = tmpl % tmpl_dict @@ -387,11 +409,20 @@ def __build_message(tmpl, patch, patch_nr, total_nr, msg_id, ref_id, options): if options.prefix: prefix_str = options.prefix + ' ' else: - prefix_str = '' + confprefix = config.get('stgit.mail.prefix') + if confprefix: + prefix_str = confprefix + ' ' + else: + prefix_str = '' + if options.diff_opts: + diff_flags = options.diff_opts.split() + else: + diff_flags = [] + total_nr_str = str(total_nr) patch_nr_str = str(patch_nr).zfill(len(total_nr_str)) - if total_nr > 1: + if not options.unrelated and total_nr > 1: number_str = ' %s/%s' % (patch_nr_str, total_nr_str) else: number_str = '' @@ -405,7 +436,8 @@ def __build_message(tmpl, patch, patch_nr, total_nr, msg_id, ref_id, options): # for backward template compatibility 'endofheaders': '', 'diff': git.diff(rev1 = git_id('%s//bottom' % patch), - rev2 = git_id('%s//top' % patch)), + rev2 = git_id('%s//top' % patch), + diff_flags = diff_flags ), 'diffstat': git.diffstat(rev1 = git_id('%s//bottom'%patch), rev2 = git_id('%s//top' % patch)), # for backward template compatibility @@ -459,7 +491,7 @@ def func(parser, options, args): """Send the patches by e-mail using the patchmail.tmpl file as a template """ - smtpserver = config.get('stgit.smtpserver') + smtpserver = options.smtp_server or config.get('stgit.smtpserver') applied = crt_series.get_applied() @@ -473,25 +505,34 @@ def func(parser, options, args): smtppassword = options.smtp_password or config.get('stgit.smtppassword') smtpuser = options.smtp_user or config.get('stgit.smtpuser') + smtpusetls = options.smtp_tls or config.get('stgit.smtptls') == 'yes' if (smtppassword and not smtpuser): raise CmdException, 'SMTP password supplied, username needed' + if (smtpusetls and not smtpuser): + raise CmdException, 'SMTP over TLS requested, username needed' if (smtpuser and not smtppassword): - raise CmdException, 'SMTP username supplied, password needed' + smtppassword = getpass.getpass("Please enter SMTP password: ") total_nr = len(patches) if total_nr == 0: raise CmdException, 'No patches to send' - if options.noreply: - ref_id = None - else: + if options.refid: + if options.noreply or options.unrelated: + raise CmdException, \ + '--refid option not allowed with --noreply or --unrelated' ref_id = options.refid + else: + ref_id = None sleep = options.sleep or config.getint('stgit.smtpdelay') # send the cover message (if any) if options.cover or options.edit_cover: + if options.unrelated: + raise CmdException, 'cover sending not allowed with --unrelated' + # find the template file if options.cover: tmpl = file(options.cover).read() @@ -501,7 +542,7 @@ def func(parser, options, args): raise CmdException, 'No cover message template file found' msg_id = email.Utils.make_msgid('stgit') - msg = __build_cover(tmpl, total_nr, msg_id, options) + msg = __build_cover(tmpl, patches, msg_id, options) from_addr, to_addr_list = __parse_addresses(msg) msg_string = msg.as_string(options.mbox) @@ -511,13 +552,12 @@ def func(parser, options, args): ref_id = msg_id if options.mbox: - print msg_string + out.stdout_raw(msg_string + '\n') else: - print 'Sending the cover message...', - sys.stdout.flush() + out.start('Sending the cover message') __send_message(smtpserver, from_addr, to_addr_list, msg_string, - sleep, smtpuser, smtppassword) - print 'done' + sleep, smtpuser, smtppassword, smtpusetls) + out.done() # send the patches if options.template: @@ -536,14 +576,13 @@ def func(parser, options, args): msg_string = msg.as_string(options.mbox) # subsequent e-mails are seen as replies to the first one - if not options.noreply and not ref_id: + if not options.noreply and not options.unrelated and not ref_id: ref_id = msg_id if options.mbox: - print msg_string + out.stdout_raw(msg_string + '\n') else: - print 'Sending patch "%s"...' % p, - sys.stdout.flush() + out.start('Sending patch "%s"' % p) __send_message(smtpserver, from_addr, to_addr_list, msg_string, - sleep, smtpuser, smtppassword) - print 'done' + sleep, smtpuser, smtppassword, smtpusetls) + out.done()