X-Git-Url: https://git.distorted.org.uk/~mdw/sod/blobdiff_plain/aa14a4cddcb96b681d5c19a2ec8bad382f43b264..3f725f73b9ae26a54f49b5feb744d37a8f1dd308:/src/c-types-impl.lisp

diff --git a/src/c-types-impl.lisp b/src/c-types-impl.lisp
index b37833a..ed65110 100644
--- a/src/c-types-impl.lisp
+++ b/src/c-types-impl.lisp
@@ -404,7 +404,7 @@
   "Return whether LIST-A and LIST-B match.
 
    They must have the same number of arguments, and each argument must have
-   the same type, or be :ELLIPSIS.  The argument names are not inspected."
+   the same type, or be `:ellipsis'.  The argument names are not inspected."
   (and (= (length list-a) (length list-b))
        (every (lambda (arg-a arg-b)
 		(if (eq arg-a :ellipsis)
@@ -418,17 +418,30 @@
 (export '(c-function-type c-function-arguments))
 (defclass c-function-type (c-type)
   ((subtype :initarg :subtype :type c-type :reader c-type-subtype)
-   (arguments :initarg :arguments :type list :reader c-function-arguments))
+   (arguments :type list :reader c-function-arguments))
   (:documentation
    "C function types.  The subtype is the return type, as implied by the C
     syntax for function declarations."))
 
+(defmethod shared-initialize :after
+    ((type c-function-type) slot-names &key (arguments nil argsp))
+  (declare (ignore slot-names))
+  (when argsp
+    (setf (slot-value type 'arguments)
+	  (if (and arguments
+		   (null (cdr arguments))
+		   (not (eq (car arguments) :ellipsis))
+		   (eq (argument-type (car arguments)) c-type-void))
+	      nil
+	      arguments))))
+
 ;; Constructor function.
 
 (export 'make-function-type)
 (defun make-function-type (subtype arguments)
   "Return a new function type, returning SUBTYPE and accepting ARGUMENTS."
-  (make-instance 'c-function-type :subtype subtype :arguments arguments))
+  (make-instance 'c-function-type :subtype subtype
+		 :arguments arguments))
 
 ;; Comparison protocol.
 
@@ -440,25 +453,27 @@
 
 ;; C syntax output protocol.
 
-(defmethod pprint-c-type ((type c-function-type) stream kernel)
-  (pprint-c-type (c-type-subtype type) stream
-		 (lambda (stream prio spacep)
-		   (maybe-in-parens (stream (> prio 2))
-		     (when spacep (c-type-space stream))
-		     (funcall kernel stream 2 nil)
-		     (pprint-indent :block 4 stream)
-		     (pprint-logical-block
-			 (stream nil :prefix "(" :suffix ")")
-		       (let ((firstp t))
-			 (dolist (arg (c-function-arguments type))
-			   (if firstp
-			       (setf firstp nil)
-			       (format stream ", ~_"))
-			   (if (eq arg :ellipsis)
-			       (write-string "..." stream)
-			       (pprint-c-type (argument-type arg)
-					      stream
-					      (argument-name arg))))))))))
+(let ((void-arglist (list (make-argument nil c-type-void))))
+  (defmethod pprint-c-type ((type c-function-type) stream kernel)
+    (pprint-c-type (c-type-subtype type) stream
+		   (lambda (stream prio spacep)
+		     (maybe-in-parens (stream (> prio 2))
+		       (when spacep (c-type-space stream))
+		       (funcall kernel stream 2 nil)
+		       (pprint-indent :block 4 stream)
+		       (pprint-logical-block
+			   (stream nil :prefix "(" :suffix ")")
+			 (let ((firstp t))
+			   (dolist (arg (or (c-function-arguments type)
+					    void-arglist))
+			     (if firstp
+				 (setf firstp nil)
+				 (format stream ", ~_"))
+			     (if (eq arg :ellipsis)
+				 (write-string "..." stream)
+				 (pprint-c-type (argument-type arg)
+						stream
+						(argument-name arg)))))))))))
 
 ;; S-expression notation protocol.
 
@@ -476,7 +491,7 @@
 			(list (argument-name arg) (argument-type arg))))
 		  (c-function-arguments type))))
 
-(export '(fun function func fn))
+(export '(fun function () func fn))
 (define-c-type-syntax fun (ret &rest args)
   "Return the type of functions which returns RET and has arguments ARGS.
 
@@ -519,7 +534,8 @@
 (defun commentify-argument-names (arguments)
   "Return an argument list with the arguments commentified.
 
-   That is, with each argument name passed through COMMENTIFY-ARGUMENT-NAME."
+   That is, with each argument name passed through
+   `commentify-argument-name'."
   (mapcar (lambda (arg)
 	    (if (eq arg :ellipsis)
 		arg