X-Git-Url: https://git.distorted.org.uk/~mdw/sod/blobdiff_plain/73eceea64f35d47eeecb808cb7bfecb6bac4299b..944bf9362ff51217b1617f85126d26e821b8aa91:/src/class-make-impl.lisp

diff --git a/src/class-make-impl.lisp b/src/class-make-impl.lisp
index 5a897d4..02fd5f5 100644
--- a/src/class-make-impl.lisp
+++ b/src/class-make-impl.lisp
@@ -84,7 +84,7 @@
 ;;; Slots.
 
 (defmethod make-sod-slot
-    ((class sod-class) name type pset &optional location)
+    ((class sod-class) name type pset &key location)
   (with-default-error-location (location)
     (when (typep type 'c-function-type)
       (error "Slot declarations cannot have function type"))
@@ -99,8 +99,8 @@
       (with-slots (slots) class
 	(setf slots (append slots (list slot))))
       (when initarg-name
-	(make-sod-slot-initarg-using-slot class initarg-name
-					  slot pset location))
+	(make-sod-slot-initarg-using-slot class initarg-name slot pset
+					  :location location))
       slot)))
 
 (defmethod shared-initialize :after ((slot sod-slot) slot-names &key pset)
@@ -115,7 +115,8 @@
 ;;; Slot initializers.
 
 (defmethod make-sod-instance-initializer
-    ((class sod-class) nick name value pset &optional location)
+    ((class sod-class) nick name value pset
+     &key location inhibit-initargs (add-to-class t))
   (with-default-error-location (location)
     (let* ((slot (find-instance-slot-by-name class nick name))
 	   (initarg-name (get-property pset :initarg :id))
@@ -126,24 +127,25 @@
       (with-slots (instance-initializers) class
 	(unless (or initarg-name initializer)
 	  (error "Slot initializer declaration with no effect"))
-	(when initarg-name
-	  (make-sod-slot-initarg-using-slot class initarg-name slot
-					    pset location))
-	(when initializer
+	(when (and initarg-name (not inhibit-initargs))
+	  (make-sod-slot-initarg-using-slot class initarg-name slot pset
+					    :location location))
+	(when (and initializer add-to-class)
 	  (setf instance-initializers
 		(append instance-initializers (list initializer)))))
       initializer)))
 
 (defmethod make-sod-class-initializer
-    ((class sod-class) nick name value pset &optional location)
+    ((class sod-class) nick name value pset &key location (add-to-class t))
   (with-default-error-location (location)
     (let* ((slot (find-class-slot-by-name class nick name))
 	   (initializer (make-sod-initializer-using-slot
 			 class slot 'sod-class-initializer
 			 value pset (file-location location))))
-      (with-slots (class-initializers) class
-	(setf class-initializers
-	      (append class-initializers (list initializer))))
+      (when add-to-class
+	(with-slots (class-initializers) class
+	  (setf class-initializers
+		(append class-initializers (list initializer)))))
       initializer)))
 
 (defmethod make-sod-initializer-using-slot
@@ -165,7 +167,7 @@
   nil)
 
 (defmethod make-sod-user-initarg
-    ((class sod-class) name type pset &optional default location)
+    ((class sod-class) name type pset &key default location)
   (with-slots (initargs) class
     (push (make-instance (get-property pset :initarg-class :symbol
 				       'sod-user-initarg)
@@ -174,19 +176,24 @@
 	  initargs)))
 
 (defmethod make-sod-slot-initarg
-    ((class sod-class) name nick slot-name pset &optional location)
+    ((class sod-class) name nick slot-name pset &key location)
   (let ((slot (find-instance-slot-by-name class nick slot-name)))
-    (make-sod-slot-initarg-using-slot class name slot pset location)))
+    (make-sod-slot-initarg-using-slot class name slot pset
+				      :location location)))
 
 (defmethod make-sod-slot-initarg-using-slot
-    ((class sod-class) name (slot sod-slot) pset &optional location)
+    ((class sod-class) name (slot sod-slot) pset &key location)
   (with-slots (initargs) class
     (with-slots ((type %type)) slot
-      (push (make-instance (get-property pset :initarg-class :symbol
-					 'sod-slot-initarg)
-			   :location (file-location location)
-			   :class class :name name :type type :slot slot)
-	    initargs))))
+      (setf initargs
+	    (append initargs
+		    (cons (make-instance (get-property pset :initarg-class
+						       :symbol
+						       'sod-slot-initarg)
+					 :location (file-location location)
+					 :class class :name name
+					 :type type :slot slot)
+			  nil))))))
 
 (defmethod sod-initarg-default ((initarg sod-initarg)) nil)
 
@@ -199,13 +206,13 @@
 ;;; Initialization and teardown fragments.
 
 (defmethod make-sod-class-initfrag
-    ((class sod-class) frag pset &optional location)
+    ((class sod-class) frag pset &key location)
   (declare (ignore pset location))
   (with-slots (initfrags) class
     (setf initfrags (append initfrags (list frag)))))
 
 (defmethod make-sod-class-tearfrag
-    ((class sod-class) frag pset &optional location)
+    ((class sod-class) frag pset &key location)
   (declare (ignore pset location))
   (with-slots (tearfrags) class
     (setf tearfrags (append tearfrags (list frag)))))
@@ -214,7 +221,7 @@
 ;;; Messages.
 
 (defmethod make-sod-message
-    ((class sod-class) name type pset &optional location)
+    ((class sod-class) name type pset &key location)
   (with-default-error-location (location)
     (let* ((msg-class (or (get-property pset :message-class :symbol)
 			  (and (get-property pset :combination :keyword)
@@ -232,9 +239,11 @@
 
 (defmethod shared-initialize :after
     ((message sod-message) slot-names &key pset)
-  (declare (ignore slot-names pset))
   (with-slots ((type %type)) message
-    (check-message-type message type)))
+    (check-message-type message type))
+  (default-slot-from-property (message 'readonlyp slot-names)
+      (pset :readonly :boolean)
+    nil))
 
 (defmethod check-message-type ((message sod-message) (type c-function-type))
   nil)
@@ -246,7 +255,7 @@
 ;;; Methods.
 
 (defmethod make-sod-method
-    ((class sod-class) nick name type body pset &optional location)
+    ((class sod-class) nick name type body pset &key location)
   (with-default-error-location (location)
     (let* ((message (find-message-by-name class nick name))
 	   (method (make-sod-method-using-message message class
@@ -317,9 +326,9 @@
   "Signal an error unless METHOD-TYPE and MESSAGE-TYPE have matching argument
    lists.
 
-  This checks that (a) the two types have matching lists of mandatory
-  arguments, and (b) that either both or neither types accept keyword
-  arguments."
+   This checks (a) that the two types have matching lists of mandatory
+   arguments, and (b) that either both or neither types accept keyword
+   arguments."
   (let ((message-keywords-p (typep message-type 'c-keyword-function-type))
 	(method-keywords-p (typep method-type 'c-keyword-function-type)))
     (cond (message-keywords-p