Various fixes and cleanups suggested by Ben Hutchings:
authorsimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Fri, 29 Jul 2005 12:07:10 +0000 (12:07 +0000)
committersimon <simon@cda61777-01e9-0310-a592-d414129be87e>
Fri, 29 Jul 2005 12:07:10 +0000 (12:07 +0000)
commit71dbfa3eecafb40c23f27b8f8d0dd40745f6e393
tree8994d1c23ef0b04778b4203a3996adf3a872f40e
parent91cb8434eb76a57ab2906b80114a2870a11dcede
Various fixes and cleanups suggested by Ben Hutchings:
 - clarified wording of messages in validate_params(), including in
   particular a correction from `< 255' to `<= 255'
 - fixed random_upto() in game generation which caused the maximum
   number of balls never to be used when there was uncertainty
 - fixed widespread miscalculation of rectangular-array indices
   (multiplication by h instead of w, which would have broken
   non-square grids rather profoundly)
 - corrected an ANSI namespace violation
 - removed real functionality from the inside of assert()
   statements, so that the game should still work when compiled
   -DNDEBUG
 - couple of unnecessary linear-time loops removed.

git-svn-id: svn://svn.tartarus.org/sgt/puzzles@6149 cda61777-01e9-0310-a592-d414129be87e
blackbox.c