From a4fc0d745f93443ac24698c6bec5c6b5f5da2257 Mon Sep 17 00:00:00 2001
From: simon <simon@cda61777-01e9-0310-a592-d414129be87e>
Date: Wed, 27 Mar 2002 21:43:37 +0000
Subject: [PATCH] Matt Harden's (modified) patch to do getservbyname() lookups
 on port- forwarding port numbers.

git-svn-id: svn://svn.tartarus.org/sgt/putty@1608 cda61777-01e9-0310-a592-d414129be87e
---
 ssh.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 84 insertions(+), 10 deletions(-)

diff --git a/ssh.c b/ssh.c
index 51bbf44e..6a653e5e 100644
--- a/ssh.c
+++ b/ssh.c
@@ -2833,9 +2833,10 @@ static void ssh1_protocol(unsigned char *in, int inlen, int ispkt)
     {
 	char type, *e;
 	int n;
-	int sport,dport;
+	int sport,dport,sserv,dserv;
 	char sports[256], dports[256], host[256];
 	char buf[1024];
+	struct servent *se;
 
 	ssh_rportfwds = newtree234(ssh_rportcmp_ssh1);
         /* Add port forwardings. */
@@ -2860,12 +2861,43 @@ static void ssh1_protocol(unsigned char *in, int inlen, int ispkt)
 	    dports[n] = 0;
 	    e++;
 	    dport = atoi(dports);
+	    dserv = 0;
+	    if (dport == 0) {
+		dserv = 1;
+		se = getservbyname(dports, NULL);
+		if (se != NULL) {
+		    dport = ntohs(se->s_port);
+		} else {
+		    sprintf(buf,
+			    "Service lookup failed for destination port \"%s\"",
+			    dports);
+		    logevent(buf);
+		}
+	    }
 	    sport = atoi(sports);
+	    sserv = 0;
+	    if (sport == 0) {
+		sserv = 1;
+		se = getservbyname(sports, NULL);
+		if (se != NULL) {
+		    sport = ntohs(se->s_port);
+		} else {
+		    sprintf(buf,
+			    "Service lookup failed for source port \"%s\"",
+			    sports);
+		    logevent(buf);
+		}
+	    }
 	    if (sport && dport) {
 		if (type == 'L') {
 		    pfd_addforward(host, dport, sport);
-		    sprintf(buf, "Local port %d forwarding to %s:%d",
-			    sport, host, dport);
+		    sprintf(buf, "Local port %.*s%.*s%d%.*s forwarding to"
+			    " %s:%.*s%.*s%d%.*s",
+			    sserv ? strlen(sports) : 0, sports,
+			    sserv, "(", sport, sserv, ")",
+			    host,
+			    dserv ? strlen(dports) : 0, dports,
+			    dserv, "(", dport, dserv, ")");
 		    logevent(buf);
 		} else {
 		    struct ssh_rportfwd *pf;
@@ -2879,8 +2911,13 @@ static void ssh1_protocol(unsigned char *in, int inlen, int ispkt)
 			logevent(buf);
 			sfree(pf);
 		    } else {
-			sprintf(buf, "Requesting remote port %d forward to %s:%d",
-				sport, host, dport);
+			sprintf(buf, "Requesting remote port %.*s%.*s%d%.*s"
+				" forward to %s:%.*s%.*s%d%.*s",
+			    sserv ? strlen(sports) : 0, sports,
+			    sserv, "(", sport, sserv, ")",
+			    host,
+			    dserv ? strlen(dports) : 0, dports,
+			    dserv, "(", dport, dserv, ")");
 			logevent(buf);
 			send_packet(SSH1_CMSG_PORT_FORWARD_REQUEST,
 				    PKT_INT, sport,
@@ -4714,9 +4751,10 @@ static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
 	static char *e;		       /* preserve across crReturn */
 	char type;
 	int n;
-	int sport,dport;
+	int sport,dport,sserv,dserv;
 	char sports[256], dports[256], host[256];
 	char buf[1024];
+	struct servent *se;
 
 	ssh_rportfwds = newtree234(ssh_rportcmp_ssh2);
         /* Add port forwardings. */
@@ -4741,12 +4779,43 @@ static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
 	    dports[n] = 0;
 	    e++;
 	    dport = atoi(dports);
+	    dserv = 0;
+	    if (dport == 0) {
+		dserv = 1;
+		se = getservbyname(dports, NULL);
+		if (se != NULL) {
+		    dport = ntohs(se->s_port);
+		} else {
+		    sprintf(buf,
+			    "Service lookup failed for destination port \"%s\"",
+			    dports);
+		    logevent(buf);
+		}
+	    }
 	    sport = atoi(sports);
+	    sserv = 0;
+	    if (sport == 0) {
+		sserv = 1;
+		se = getservbyname(sports, NULL);
+		if (se != NULL) {
+		    sport = ntohs(se->s_port);
+		} else {
+		    sprintf(buf,
+			    "Service lookup failed for source port \"%s\"",
+			    sports);
+		    logevent(buf);
+		}
+	    }
 	    if (sport && dport) {
 		if (type == 'L') {
 		    pfd_addforward(host, dport, sport);
-		    sprintf(buf, "Local port %d forwarding to %s:%d",
-			    sport, host, dport);
+		    sprintf(buf, "Local port %.*s%.*s%d%.*s forwarding to"
+			    " %s:%.*s%.*s%d%.*s",
+			    sserv ? strlen(sports) : 0, sports,
+			    sserv, "(", sport, sserv, ")",
+			    host,
+			    dserv ? strlen(dports) : 0, dports,
+			    dserv, "(", dport, dserv, ")");
 		    logevent(buf);
 		} else {
 		    struct ssh_rportfwd *pf;
@@ -4761,8 +4830,13 @@ static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
 			logevent(buf);
 			sfree(pf);
 		    } else {
-			sprintf(buf, "Requesting remote port %d (forwarded to %s:%d)",
-				sport, host, dport);
+			sprintf(buf, "Requesting remote port %.*s%.*s%d%.*s"
+				" forward to %s:%.*s%.*s%d%.*s",
+			    sserv ? strlen(sports) : 0, sports,
+			    sserv, "(", sport, sserv, ")",
+			    host,
+			    dserv ? strlen(dports) : 0, dports,
+			    dserv, "(", dport, dserv, ")");
 			logevent(buf);
 			ssh2_pkt_init(SSH2_MSG_GLOBAL_REQUEST);
 			ssh2_pkt_addstring("tcpip-forward");
-- 
2.11.0