ben [Tue, 8 Feb 2005 14:13:57 +0000 (14:13 +0000)]
We _really_ don't need to hear about WSAECONNABORTED any more.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5276
cda61777-01e9-0310-a592-
d414129be87e
ben [Tue, 8 Feb 2005 12:40:51 +0000 (12:40 +0000)]
Mention that a common reason for keys' being rejected is dodgy permissions.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5274
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 7 Feb 2005 23:43:03 +0000 (23:43 +0000)]
Add the new mk.mpw to the ignore list.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5272
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 7 Feb 2005 20:24:13 +0000 (20:24 +0000)]
Revert my LF->CR change following Owen's comment that it actually
breaks netatalk-based setups (which _swap_ LF and CR). Instead,
setfile.sh (which I have to run _anyway_ on OS X) copies mkputty.mpw
to mk.mpw and then makes that CR-based.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5271
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 7 Feb 2005 15:23:45 +0000 (15:23 +0000)]
Comment explaining location in top-level directory.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5270
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 7 Feb 2005 12:23:10 +0000 (12:23 +0000)]
Petri Kero pointed out a FreeLibrary() call that should be guarded by NO_IPV6.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5268
cda61777-01e9-0310-a592-
d414129be87e
owen [Mon, 7 Feb 2005 10:47:48 +0000 (10:47 +0000)]
Add a comment about the deficiencies of the host key cache implementation.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5263
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 6 Feb 2005 15:52:00 +0000 (15:52 +0000)]
Reinstate the broken -e option in pterm. Also I've just worked out a
much better way of handling pty_argv which doesn't require uxpty.c
to be linked in to Unix PuTTY and PuTTYtel.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5262
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 6 Feb 2005 15:14:34 +0000 (15:14 +0000)]
Encapsulated most of the pty backend's variables into a proper data
structure, in preparation for wanting more than one of them in a
single process. This can't be done cleanly, because the whole
business with pty_pre_init pre-allocating the pty rather assumes we
want a known number of the things before we drop privileges; so
there's a horrid hack to make pty_pre_init work on platforms that
have at most one pty instance per process, but at the same time
things ought to work sensibly with more than one per process _if_
pty_pre_init isn't required.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5261
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 6 Feb 2005 15:00:36 +0000 (15:00 +0000)]
First stab at a host key cache on the Mac.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5260
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 6 Feb 2005 13:33:41 +0000 (13:33 +0000)]
The pty backend won't _always_ be running under X, so it should be
possible to compile it without the WINDOWID variable.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5259
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 5 Feb 2005 15:33:36 +0000 (15:33 +0000)]
When allocating BSD-style ptys, we should not be satisfied with a
/dev/ptyXX we can open: we must also check that we can open and use
the corresponding /dev/ttyXX, because if it's been left in the wrong
mode then we will look terribly silly when we fork and _then_
discover our pty is unusable.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5257
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 5 Feb 2005 14:50:42 +0000 (14:50 +0000)]
Implement refreshing the whole dialogue box with dlg_refresh, so that
if you load a session all the panels in the configuration dialogue
reflect the new settings. However, there's a glitch which paints a white
rectangle between the Saved Sessions listbox and the Close-on-exit radios.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5256
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 5 Feb 2005 14:46:39 +0000 (14:46 +0000)]
Added a small shell script to run enough SetFile commands to make
MPW builds work after checking out on Mac OS X.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5255
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 5 Feb 2005 14:39:22 +0000 (14:39 +0000)]
This file needs to have CR line endings for MPW to be happy with it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5254
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 5 Feb 2005 10:55:09 +0000 (10:55 +0000)]
Mac PuTTY.ppc wouldn't compile for me until I added this prototype.
Not sure why it's been working for Owen and not me, but the
prototype ought to be there anyway, so *shrug*.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5251
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 5 Feb 2005 00:29:20 +0000 (00:29 +0000)]
Times and dates in the event log, fixing ltime() in the process.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5250
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 5 Feb 2005 00:14:24 +0000 (00:14 +0000)]
mac_pollterm() is no longer useful and can be retired.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5249
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 2 Feb 2005 23:51:58 +0000 (23:51 +0000)]
Implement anti-replay protection for XDM-AUTHORIZATION-1, as required by
the specification. We keep a cache of tickets we've seen recently and
reject duplicates. Once a ticket in our cache is old enough that we
wouldn't accept a duplicate anyway, we expire it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5236
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 2 Feb 2005 21:33:13 +0000 (21:33 +0000)]
Flashing things now work as a natural consequence of the timing interface.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5235
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 2 Feb 2005 21:18:39 +0000 (21:18 +0000)]
Make ot_recv less voracious.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5234
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 2 Feb 2005 19:56:29 +0000 (19:56 +0000)]
Update the configuration when the window is resized.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5233
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 30 Jan 2005 14:59:47 +0000 (14:59 +0000)]
Hide/show the scrollbar
git-svn-id: svn://svn.tartarus.org/sgt/putty@5230
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 30 Jan 2005 14:10:05 +0000 (14:10 +0000)]
The HI guidelines seem adamant that the File menu should never be called
anything but File, and two Mac users expressed profound distress at the
thought of it being called Session. File it is.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5229
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 29 Jan 2005 22:50:18 +0000 (22:50 +0000)]
Another compiler pickiness. It feels wrong to be doing this to
perfectly idiomatic code, somehow, and I half wonder whether the
Mac compilers are too stupid to be allowed to treat warnings as
errors.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5228
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 29 Jan 2005 22:46:43 +0000 (22:46 +0000)]
Make Change Settings do something.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5227
cda61777-01e9-0310-a592-
d414129be87e
owen [Fri, 28 Jan 2005 23:39:38 +0000 (23:39 +0000)]
Enable the Open Transport networking implementation unless NO_OT is defined.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5224
cda61777-01e9-0310-a592-
d414129be87e
ben [Fri, 28 Jan 2005 13:47:37 +0000 (13:47 +0000)]
Split discussion of diabling rekeys between time-based and data-based, since
disabling the former is much more useful, and much safer, than disabling the
latter. The new wording on data-based rekeys might need some polishing.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5222
cda61777-01e9-0310-a592-
d414129be87e
owen [Fri, 28 Jan 2005 11:50:56 +0000 (11:50 +0000)]
sfree the memory dupprintf allocated
git-svn-id: svn://svn.tartarus.org/sgt/putty@5221
cda61777-01e9-0310-a592-
d414129be87e
ben [Fri, 28 Jan 2005 11:47:33 +0000 (11:47 +0000)]
Use AF_UNIX, not AF_LOCAL, since the former is in POSIX and the latter is not.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5220
cda61777-01e9-0310-a592-
d414129be87e
ben [Fri, 28 Jan 2005 11:39:45 +0000 (11:39 +0000)]
Overhaul of client-side XDM-AUTHORIZATION-1:
* Make sk_getxdmdata() return an arbitrary string rather than two integers.
This better matches the spec, even if the current version always returns
six bytes
* On Unix, for PF_UNIX sockets, return a counter rather than a constant along
with the PID. This should allow multiple clients to connect within one
second, and is what Xlib does.
* On Unix, interpret AF_INET6 addresses like Xlib does, returning the
embedded IPv4 address for v4-mapped addresses, and six bytes of zeroes
otherwise. The latter is silly, but if I'm going to do anything more sane
I need to check that X servers won't reject it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5219
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 26 Jan 2005 23:49:56 +0000 (23:49 +0000)]
Buffer overruns are embarassing (even if caused by user error), so assert
that this one can't happen until I actually fix it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5217
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 26 Jan 2005 23:30:34 +0000 (23:30 +0000)]
Add a Change Settings dialogue box. Doesn't do anything yet.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5216
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 26 Jan 2005 20:18:33 +0000 (20:18 +0000)]
Move sockaddr_is_loopback() to before sk_address_is_local(), and define the
latter in terms of the former. Also adjust the definition of
ipv4_is_loopback() to avoid using the non-standard inet_netof() and
IN_LOOPBACKNET, and move it next to its remaining uses.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5215
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 26 Jan 2005 19:05:50 +0000 (19:05 +0000)]
Move sk_poll() inside (!gotevent), which is more logical but doesn't have
any actual beneficial effect on event handling, sadly.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5214
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 26 Jan 2005 19:04:42 +0000 (19:04 +0000)]
Add ssh.h for prototypes for the X display stubs
git-svn-id: svn://svn.tartarus.org/sgt/putty@5213
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 26 Jan 2005 18:11:28 +0000 (18:11 +0000)]
Make a few things static
git-svn-id: svn://svn.tartarus.org/sgt/putty@5212
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 23 Jan 2005 15:01:21 +0000 (15:01 +0000)]
Give the config window a title.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5181
cda61777-01e9-0310-a592-
d414129be87e
ben [Sun, 23 Jan 2005 14:31:08 +0000 (14:31 +0000)]
When checking if a connection comes from localhost, don't assume it's an IPv4
connection. Instead, correctly check IPv4 and IPv6 connections, assume that
AF_LOCAL is always local, and anything else is always remote.
This makes trivial local-to-remote forwarding work on my system.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5180
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 16:06:21 +0000 (16:06 +0000)]
Don't abuse a remote channel number of (unsigned)(-1) to indicate a channel
for which we don't yet have a remote number, and instead add a flag to indicate
this fact. Fixes bug ssh-remoteid-minusone.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5171
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 15:32:10 +0000 (15:32 +0000)]
When calling getaddrinfo() for a listening socket, pass in a suggested type
of SOCK_STREAM, since that's what we'll be using.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5170
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 15:20:35 +0000 (15:20 +0000)]
Stupid typo, spotted by GCC.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5168
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 15:19:21 +0000 (15:19 +0000)]
If getaddrinfo() fails, it's not safe to dereference the struct addrinfo* it
passes back to us, so don't.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5167
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 22 Jan 2005 14:51:29 +0000 (14:51 +0000)]
Owen's just pointed out that random_stir() is capable of recursion.
I'm sure I didn't mean that to happen! Added a lock to stop it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5166
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 14:01:01 +0000 (14:01 +0000)]
Explicitly ignore SCI rather than translating it into DECID. Should fix
bug sci-is-not-decid.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5164
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 22 Jan 2005 13:32:41 +0000 (13:32 +0000)]
Probable support for first_kex_packet_follows in KEXINIT. Not significantly
tested since none of the common key-exchange protocols starts with a packet
from the server, so I don't have a server that implements this.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5162
cda61777-01e9-0310-a592-
d414129be87e
owen [Fri, 21 Jan 2005 00:02:59 +0000 (00:02 +0000)]
Colours now work properly, including 256-colour stuff.
Timing stuff now there, but almost certainly bogus.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5160
cda61777-01e9-0310-a592-
d414129be87e
ben [Thu, 20 Jan 2005 21:45:42 +0000 (21:45 +0000)]
Dispose of a variable whose only use was being set to zero.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5156
cda61777-01e9-0310-a592-
d414129be87e
owen [Thu, 20 Jan 2005 16:42:25 +0000 (16:42 +0000)]
Fix/bludgeon Mac compile wrinkles.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5154
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 19 Jan 2005 23:30:38 +0000 (23:30 +0000)]
Add an assertion so that short-rsa2-key-crash at least avoids segfaulting
while we come up with a better solution.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5146
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 19 Jan 2005 17:41:21 +0000 (17:41 +0000)]
While we're here, pad USERAUTH_INFO_RESPONSEs to 256 bytes too.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5145
cda61777-01e9-0310-a592-
d414129be87e
ben [Wed, 19 Jan 2005 12:34:52 +0000 (12:34 +0000)]
Make the outgoing SSH2 sequence number unsigned, so as to avoid depending
on overflow behaviour of signed integers.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5142
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 19 Jan 2005 10:07:58 +0000 (10:07 +0000)]
Add a lengthy comment warning future front-end implementors about
the right and wrong way to implement the timing interface.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5137
cda61777-01e9-0310-a592-
d414129be87e
owen [Tue, 18 Jan 2005 22:01:25 +0000 (22:01 +0000)]
Bits and pieces, mostly stubs, for the Mac port.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5136
cda61777-01e9-0310-a592-
d414129be87e
owen [Tue, 18 Jan 2005 19:09:02 +0000 (19:09 +0000)]
Yes we do mean assignment. Bah.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5135
cda61777-01e9-0310-a592-
d414129be87e
owen [Tue, 18 Jan 2005 19:04:59 +0000 (19:04 +0000)]
The terminal reengineering of r4609 left an unused `start' lying around.
Remove it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5134
cda61777-01e9-0310-a592-
d414129be87e
owen [Tue, 18 Jan 2005 09:38:58 +0000 (09:38 +0000)]
ssh_pkt_getstring wants a boring int rather than an unsigned int. Let's
give it one.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5129
cda61777-01e9-0310-a592-
d414129be87e
ben [Mon, 17 Jan 2005 16:38:55 +0000 (16:38 +0000)]
Currentish ssh.com supports single-DES in SSH2 as "des-cbc@ssh.com". It
seems to be entirely the same as "des-cbc", so supporting it is trivial
and we may as well do so. If nothing else, it makes it clear whose fault
it is.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5128
cda61777-01e9-0310-a592-
d414129be87e
owen [Mon, 17 Jan 2005 10:07:13 +0000 (10:07 +0000)]
Change some function arguments to void * to placate picky compilers.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5124
cda61777-01e9-0310-a592-
d414129be87e
ben [Mon, 17 Jan 2005 00:50:35 +0000 (00:50 +0000)]
In SSH2, rather than sending an SSH_MSG_IGNORE after every password, just
pad the packet out to 256 bytes. Much simpler.
This leavs ssh2_pkt_defer() unused, so ifdef it out.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5122
cda61777-01e9-0310-a592-
d414129be87e
ben [Sun, 16 Jan 2005 14:43:12 +0000 (14:43 +0000)]
Be a little less enthusiastic about sending SSH_MSG_CHANNEL_WINDOW_ADJUST:
only send it when it will significantly increase the server's idea of our
window. This avoids the slew of one-byte WINDOW_ADJUSTs that an interactive
shell typically generates.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5121
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 16 Jan 2005 14:33:43 +0000 (14:33 +0000)]
Mac SC compiler whinges about trailing commas in enums
git-svn-id: svn://svn.tartarus.org/sgt/putty@5120
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 16 Jan 2005 14:29:34 +0000 (14:29 +0000)]
Support for falling back through the list of addresses returned from
a DNS lookup, whether they're IPv4, v6 or a mixture of both.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5119
cda61777-01e9-0310-a592-
d414129be87e
ben [Sun, 16 Jan 2005 14:14:59 +0000 (14:14 +0000)]
Make our SSH2 maximum packet size into a constant, since it's used in several
places.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5118
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 16 Jan 2005 14:02:56 +0000 (14:02 +0000)]
Owen tells me the Mac compiler complains at a char / unsigned char
mismatch in the invocation of hmacmd5_key(). Do it properly with a
void * argument.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5117
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 16 Jan 2005 13:40:36 +0000 (13:40 +0000)]
Add minibidi to Mac PuTTY objects
git-svn-id: svn://svn.tartarus.org/sgt/putty@5116
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 16 Jan 2005 12:37:19 +0000 (12:37 +0000)]
Rewrite of Unix sk_newlistener() which should fix any possible
problems involving trying to bind an IPv6 socket to an IPv4 address.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5115
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 15 Jan 2005 20:39:27 +0000 (20:39 +0000)]
Turn of ICRNL in the client tty when we're not in editing mode. This
means that we send literal CRs and let the remote pty layer work out what to
do with them, so that if it wants raw mode it can have it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5114
cda61777-01e9-0310-a592-
d414129be87e
ben [Sat, 15 Jan 2005 18:30:05 +0000 (18:30 +0000)]
FWHACK has been dead for years. Remove it from the Makefiles.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5113
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 15 Jan 2005 17:28:44 +0000 (17:28 +0000)]
Fix prototypes for mactcp_new and ot_new.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5112
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 15 Jan 2005 17:16:48 +0000 (17:16 +0000)]
Throw away "./" in findfile so that the Mac makefile has valid paths.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5111
cda61777-01e9-0310-a592-
d414129be87e
ben [Fri, 14 Jan 2005 19:28:18 +0000 (19:28 +0000)]
INADDR_NONE is nonstandard. Use (in_addr_t)(-1) instead.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5109
cda61777-01e9-0310-a592-
d414129be87e
ben [Fri, 14 Jan 2005 12:26:38 +0000 (12:26 +0000)]
Don't use GNUish pattern rules in the Unix Makefile, since they're not
supported by non-GNU makes. This allows the standard Solaris /usr/ccs/bin/make
to handle that Makefile.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5108
cda61777-01e9-0310-a592-
d414129be87e
ben [Thu, 13 Jan 2005 21:50:41 +0000 (21:50 +0000)]
Mention Cygwin/X as a potential X server, since it's free.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5107
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 11 Jan 2005 19:33:41 +0000 (19:33 +0000)]
Fix `disconnect': arrange that we keep track of when we're expecting
to see the server slam the TCP connection shut (i.e. almost never,
unless it's just sent us an SSH_MSG_DISCONNECT), and treat an
unexpected closure as a non-clean session termination. Previously
any server-initiated connection closure was being treated as a clean
exit, which was a hangover from the good old Telnet-only days.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5098
cda61777-01e9-0310-a592-
d414129be87e
ben [Tue, 11 Jan 2005 16:33:08 +0000 (16:33 +0000)]
Versions of OpenSSH before 2.5.4 kill the connection if the client attempts
to rekey. Extend the description of SSH2_BUG_REKEY to cover this situation
and apply it to the relevant OpenSSH versions.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5097
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 11 Jan 2005 15:33:35 +0000 (15:33 +0000)]
Bah, I left a rogue event log entry lying around.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5095
cda61777-01e9-0310-a592-
d414129be87e
ben [Tue, 11 Jan 2005 13:24:47 +0000 (13:24 +0000)]
Sun_SSH_1.0.1 also has BUG_SSH2_REKEY.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5094
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 11 Jan 2005 10:45:43 +0000 (10:45 +0000)]
The Unix `make install' target now allows you to define UTMP_GROUP,
in which case pterm will be installed setgid that, or to define
UTMP_USER in which case it will be installed setuid that. If you
define neither, it will be installed without any set-id bits as
before.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5093
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 11 Jan 2005 10:37:55 +0000 (10:37 +0000)]
Servers announcing themselves as `Sun_SSH_1.0' apparently cannot
deal with rekeys at all: they totally ignore mid-session KEXINIT
sent by the client. Hence, a new bug entry so we don't try it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5092
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Jan 2005 14:55:55 +0000 (14:55 +0000)]
sk_namelookup() on Unix was failing to translate from our platform-
independent ADDRTYPE_* constants to real AF_* ones, causing explicit
protocol specification to fail.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5089
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 9 Jan 2005 14:45:00 +0000 (14:45 +0000)]
Remove unwanted underscore.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5088
cda61777-01e9-0310-a592-
d414129be87e
owen [Sun, 9 Jan 2005 14:27:48 +0000 (14:27 +0000)]
New function ltime() returns a struct tm of the current local time.
Fixes crashes when time() returns (time_t)-1 on Windows by using the
Win32 GetLocalTime() function. (The Unix implementation still just
uses time() and localtime().)
git-svn-id: svn://svn.tartarus.org/sgt/putty@5086
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Jan 2005 11:58:36 +0000 (11:58 +0000)]
Having laboriously constructed a hints parameter for getaddrinfo, it
would help to _use_ it!
git-svn-id: svn://svn.tartarus.org/sgt/putty@5085
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 9 Jan 2005 11:44:21 +0000 (11:44 +0000)]
I've changed my mind about what the IP version selection options in
the config should do when IPv6 is configured out. They shouldn't sit
there looking silly with only `Auto' and `IPv4' settings: they
should instead be completely absent. I had thought the former was
acceptable since IPv4-only was a configuration that people should
only be using if their compilers didn't support IPv6, but now it
occurs to me that ports to fundamentally non-IPv6-supporting
platforms are not implausible, and on such ports the presence of a
vestigial config option under the _standard_ build conditions would
be a low-quality solution.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5084
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Jan 2005 14:45:26 +0000 (14:45 +0000)]
For local and dynamic port forwardings (i.e. the ones which listen
on a local port), the `Auto' protocol option on the Tunnels panel
should always produce a port you can connect to in _either_ of IPv4
and v6, because the aim is for the user not to have to know or care
which one they're using. This was not the case on Windows, and now
is. Also, updated the docs to give more detail on issues like this.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5083
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Jan 2005 14:02:06 +0000 (14:02 +0000)]
Cleanups to sk_namelookup(). In particular, it now doesn't segfault
if you explicitly specify IPv6 and then try to look up a hostname
which doesn't have an IPv6 address.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5082
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Jan 2005 13:28:41 +0000 (13:28 +0000)]
Clear the kex-specific context in ssh->pkt_ctx for every new key
exchange. Without doing this, after we have done one specific-group
DH exchange (group1 or group14), ssh2_pkt_type _always_ translates
30 and 31 as KEXDH_INIT and KEXDH_REPLY, making a subsequent
group-exchange kex look rather strange in an SSH packet log.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5081
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 8 Jan 2005 13:08:32 +0000 (13:08 +0000)]
Jacob points out that changing TICKSPERSEC in unix.h changed the
meaning of BellOverload{T,S} in Unix saved sessions. Add a Unix-
specific backwards compatibility wart to settings.c to compensate.
Of course when I do the serious config format revamp, I will ensure
that no config item depends on internal #defines (these time
intervals will be specified as a floating-point number of seconds)
and this horror will be relegated to the old-config-compatibility
code.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5080
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 7 Jan 2005 16:55:45 +0000 (16:55 +0000)]
Simon points out that r5068 broke keyboard-interactive with multiple
INFO_REQUESTs, and for some reason Debian OpenSSH is sending INFO_REQUESTs
containing no prompts after a normal password authentication, so this
should fix Shai's problem.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5078
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 7 Jan 2005 15:25:32 +0000 (15:25 +0000)]
Update faq-bce further for changes in 0.54.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5076
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Jan 2005 14:22:17 +0000 (14:22 +0000)]
Proxy command formatting now recognises `%proxyhost' and
`%proxyport' in addition to the other things it interpolates. This
is useful when using the Unix-only `Local' proxy type: it allows me
to, for example, set up a proxy command such as
ssh %proxyhost nc -q0 %host %port
and then enter the name of the proxy machine in `Proxy hostname',
which makes it marginally more convenient to quickly change to using
a different proxy to get at the same target.
I haven't documented this, because we currently don't document the
Local proxy type at all. Possibly we should, though.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5073
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 7 Jan 2005 09:24:24 +0000 (09:24 +0000)]
Use sk_set_frozen() to ensure that no data will be accepted from an
SSH connection when we're in the middle of asking the user a
dialog-box-type question. Fixes `unix-kex-packet', which has just
bitten me when connecting to one of the work Suns.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5071
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 6 Jan 2005 17:05:54 +0000 (17:05 +0000)]
Add an explicit message about lack of support for PASSWD_CHANGEREQ in a
half-hearted attempt to flush out any uses of it.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5070
cda61777-01e9-0310-a592-
d414129be87e
simon [Thu, 6 Jan 2005 15:47:12 +0000 (15:47 +0000)]
I can't believe that after all this time we still had a rogue set of
`' quotes! Changed to \q{}.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5069
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 6 Jan 2005 13:23:47 +0000 (13:23 +0000)]
`kbdint-failure': we now offer keyboard-interactive auth to the user for as
long as the server offers it, rather than only once, unless the server responds
to our initial USERAUTH_REQUEST("keyboard-interactive") with FAILURE, in which
case we give up on it entirely.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5068
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 6 Jan 2005 12:37:33 +0000 (12:37 +0000)]
Try to make it clearer that "-be" and "-bc" must be specified in _addition_
to "-b batchfile".
git-svn-id: svn://svn.tartarus.org/sgt/putty@5067
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 4 Jan 2005 17:39:35 +0000 (17:39 +0000)]
Don't forget to initialise ret->ai to NULL in sk_nonamelookup. Was
causing segfaults in IPv6-enabled Unix PuTTY connecting through a
proxy when letting the proxy do the DNS.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5064
cda61777-01e9-0310-a592-
d414129be87e
ben [Tue, 4 Jan 2005 14:37:32 +0000 (14:37 +0000)]
If we're going to use select(), we need <sys/select.h>.
git-svn-id: svn://svn.tartarus.org/sgt/putty@5063
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 2 Jan 2005 13:17:22 +0000 (13:17 +0000)]
colon in kex UI
git-svn-id: svn://svn.tartarus.org/sgt/putty@5062
cda61777-01e9-0310-a592-
d414129be87e