simon [Sun, 27 Aug 2006 08:34:04 +0000 (08:34 +0000)]
Call console_provide_logctx _before_ initialising the back end, so
that logevent() will go to stderr in -v mode even during the back
end init function.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6811
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 27 Aug 2006 08:03:19 +0000 (08:03 +0000)]
The `socket' function in the backends is only ever checked to see if
it's NULL. Since we already have one back end (uxpty) which doesn't
in fact talk to a network socket, and may well have more soon, I'm
replacing this TCP/IP-centric function with a nice neutral
`connected' function returning a boolean. Nothing else about its
semantics has currently changed.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6810
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:59:09 +0000 (10:59 +0000)]
It's critically important that the local proxy process should not
inherit _our_ ends of its I/O pipes! Otherwise, closing our copy of
those handles does not cause it to see EOF on its stdin, because
it's holding the pipe open itself.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6808
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:58:13 +0000 (10:58 +0000)]
We _can_ have handle_throttle() called on defunct handles after all,
so it should just do nothing rather than failing an assertion.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6807
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:20:16 +0000 (10:20 +0000)]
ProxyCommand support for Windows, using the new winhandl.c API.
Seems a bit clunky when I actually try to use it - not sure why -
but I think all the actual functionality is there.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6806
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:19:23 +0000 (10:19 +0000)]
Another bug fix: always set the busy flag when telling a subthread
to do something, otherwise handle_get_events will forget to tell the
front end to check for that subthread finishing. This applies even
when we're only setting `busy' to tell the subthread to terminate!
git-svn-id: svn://svn.tartarus.org/sgt/putty@6805
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:18:31 +0000 (10:18 +0000)]
Cleanups to reduce dependency on Windows SFTP tools always having a
real network socket.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6804
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:17:39 +0000 (10:17 +0000)]
On cleanup, PSCP and PSFTP should explicitly check that the back end
is still running rather than relying on ssh_sftp_loop_iteration() to
return a bogus value.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6803
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 10:04:46 +0000 (10:04 +0000)]
Start using notify_remote_exit() in the Windows front end, in place
of the previous ad-hockery which depended on the return value from
select_result() and hence which will not adapt sensibly to a world
in which the primary session is something local rather than a
network connection.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6802
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 09:21:52 +0000 (09:21 +0000)]
Return a non-zero exit code in the event of a fatal-error SSH
session termination. `Close window only on clean exit' was not
working properly on Unix in the absence of this:
notify_remote_exit() was being called and ssh_return_exitcode was
returning zero, causing gtk_main_quit() to be called, _before_
connection_fatal() happened.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6801
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 08:37:42 +0000 (08:37 +0000)]
Always initialise the `addresses' field of a SockAddr to NULL,
because it gets unconditionally sfree()d in sk_addr_free(). This
just bit me when running under the MSVC debugger; not sure how it
hasn't bitten anyone until now!
git-svn-id: svn://svn.tartarus.org/sgt/putty@6800
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 08:15:53 +0000 (08:15 +0000)]
Bug fix: since the input thread does not wait for the event object
until _after_ its first read, we should not start by signalling that
object in order to trigger the first read. Ahem.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6799
cda61777-01e9-0310-a592-
d414129be87e
simon [Sat, 26 Aug 2006 07:41:15 +0000 (07:41 +0000)]
Small tweak to the new handle API: provide a `privdata' field in
each handle structure, set on initialisation and readable by an API
call.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6798
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 25 Aug 2006 22:10:16 +0000 (22:10 +0000)]
New piece of Windows infrastructure: winhandl.c takes Plink's
thread-based approach to stdin and stdout, wraps it in a halfway
sensible API, and makes it a globally available service across all
network tools.
There is no direct functionality enhancement from this checkin:
winplink.c now talks to the new API instead of doing it all
internally, but does nothing different as a result.
However, this should lay the groundwork for several diverse pieces
of work in future: pipe-based ProxyCommand on Windows, a serial port
back end, and (hopefully) a pipe-based means of communicating with
Pageant, which should have sensible blocking behaviour and hence
permit asynchronous agent requests and decrypt-on-demand.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6797
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 15 Aug 2006 22:48:01 +0000 (22:48 +0000)]
Er, ahem. Other half of r6788. :-/
git-svn-id: svn://svn.tartarus.org/sgt/putty@6791
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 15 Aug 2006 20:29:02 +0000 (20:29 +0000)]
Shifts left and right by 32 were tripping a gcc warning (fatal with
-Werror, of course) about shifting by more than the range of a data
type. They only appeared in `if' statements testing sizeof(off_t),
but gcc warns even when the code is unreachable. I've removed the
conditional code (the general case should still work even on 32-bit
machines), and hacked each shift by 32 into a pair of shifts by 16.
Note that the gcc warning is not just a helpful indication that you
may be using the wrong data type; it's actually pointing out ANSI-
undefined behaviour in shifting a signed integer beyond the size of
its type.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6789
cda61777-01e9-0310-a592-
d414129be87e
simon [Tue, 15 Aug 2006 12:45:21 +0000 (12:45 +0000)]
Aha! At long last I've managed to reproduce the intermittent problem
I've been having with the cursor sometimes restoring to the wrong
place when screen(1) terminates. The offending sequence of escape
sequences goes ESC 7 (save cursor), ESC [?47h (switch to alternate
screen), ESC 7 (save cursor _again_), do some stuff, ESC 8 (restore
cursor), run screen session for a bit, ESC [?47l (return to main
screen), ESC 8 (restore cursor). The final ESC 8 is expected to
restore the cursor to where it was saved by the initial ESC 7.
Translation: the ESC 7 saved cursor state is part of the state we
must swap out when switching to the alternate screen. In other
words, we need to track _four_ cursor positions: active and saved,
on each of main and alternate screen. Previously we were tracking
only three.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6788
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 12 Aug 2006 15:20:19 +0000 (15:20 +0000)]
Large file support for psftp and pscp on both Windows and Unix. On Unix
we set _FILE_OFFSET_BITS to 64 on the compiler command line (via mkfiles.pl),
and on Windows we use SetFilePointer and GetFileSize to cope with 64-bit sizes
where possible. Not tested on Win9x.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6783
cda61777-01e9-0310-a592-
d414129be87e
owen [Sat, 5 Aug 2006 13:48:53 +0000 (13:48 +0000)]
Some extra int64 functions.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6778
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 7 Jul 2006 20:56:22 +0000 (20:56 +0000)]
Spell out more explicitly what needs to be done with vanilla VC6, since it
seems to be becoming a FAQ.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6752
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 7 Jul 2006 14:18:47 +0000 (14:18 +0000)]
Random Unix puttygen improvements highlighted by a post to comp.security.ssh:
- fix diagnostic if keyfile and '-t' both specified
- add diagnostic for generating a key but discarding the private part
- document '-q' option
git-svn-id: svn://svn.tartarus.org/sgt/putty@6750
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 20 Jun 2006 21:10:33 +0000 (21:10 +0000)]
In the config dialog, clip RGB values to [0..255] rather than reducing them
mod 256.
Document that the RGB values can be edited, and their range.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6734
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 17 Jun 2006 13:01:04 +0000 (13:01 +0000)]
When Unix PuTTYgen gives brief usage information, it should mention "--help"!
git-svn-id: svn://svn.tartarus.org/sgt/putty@6732
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 17 Jun 2006 12:02:03 +0000 (12:02 +0000)]
Robert Evans spotted that bignum_decimal() failed to cope with being given
a zero input.
This shouldn't matter for PuTTY, as these routines are only used in PuTTYgen,
to output SSH-1 format public key exponents/moduli, which should be nonzero.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6731
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 16 Jun 2006 13:09:47 +0000 (13:09 +0000)]
Update status of our PocketPC port.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6730
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 11 Jun 2006 12:56:52 +0000 (12:56 +0000)]
Do not send raw mouse events in the middle of a selection operation, even if
we otherwise would (for instance, if Shift is released before the mouse button
being used for selection).
git-svn-id: svn://svn.tartarus.org/sgt/putty@6727
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 2 Jun 2006 08:46:34 +0000 (08:46 +0000)]
Lionel Fourquaux offers this very simple patch to speed up SFTP,
simply by upping the packet sizes and maximum in-flight packet
count. Got to be worth a try, I think!
git-svn-id: svn://svn.tartarus.org/sgt/putty@6722
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 26 May 2006 12:45:21 +0000 (12:45 +0000)]
Make it clearer that `psftp -b' doesn't return to the interactive
prompt if the script doesn't end with an explicit `quit'.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6717
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 21 May 2006 12:20:42 +0000 (12:20 +0000)]
Port r6710 from puzzles:
Patch from Ben Hutchings to prevent an ugly special case in
&splitline in which a line is `split' into a line ending in a
backslash followed by a completely blank line.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6714
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 17 May 2006 12:06:08 +0000 (12:06 +0000)]
Link to new `key-formats-natively' wishlist item from appropriate FAQ.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6693
cda61777-01e9-0310-a592-
d414129be87e
owen [Fri, 12 May 2006 11:02:28 +0000 (11:02 +0000)]
pty_init should put _something_ into realhost
git-svn-id: svn://svn.tartarus.org/sgt/putty@6679
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 26 Apr 2006 23:01:06 +0000 (23:01 +0000)]
sbcsgen.pl was giving different results on different machines in the case
where two SBCS code points mapped to a single Unicode point.
Changed so that by default it favours the lower SBCS code point.
On ixion, this highlighted ambiguities in CS_MAC_THAI, CS_MAC_SYMBOL, and
CS_VISCII. Guessed at a preference for the first two and added "sortpriority"
directives. (No idea about VISCII.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6641
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 23 Apr 2006 18:26:03 +0000 (18:26 +0000)]
Sprinkle some header comments in various files in an attempt to explain what
they're for.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6639
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 16 Apr 2006 11:15:20 +0000 (11:15 +0000)]
PocketPuTTY website moved.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6638
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 13 Apr 2006 21:18:09 +0000 (21:18 +0000)]
Everywhere we print an fxp_error(), try to make it clear what we were trying
to do at the time.
(A lot of these say just "canonify:". This isn't a nice thing to show to a
user, but I don't believe canonify() will ever return failure due to a server
error, so users shouldn't actually see it, and it means we have a chance of
tracing it if reported.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6636
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 7 Apr 2006 21:42:30 +0000 (21:42 +0000)]
Remove login name prompt from PSFTP.
ssh.c will prompt for a login name as required, and doing so in psftp.c
before we've even made a connection is incorrect wrt `bypass-ssh2-userauth'.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6634
cda61777-01e9-0310-a592-
d414129be87e
owen [Fri, 31 Mar 2006 09:26:59 +0000 (09:26 +0000)]
ECCN / FIPS - we can't be arsed.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6619
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 29 Mar 2006 17:55:40 +0000 (17:55 +0000)]
Update size when going from maximised to full screen.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6618
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 15 Mar 2006 14:31:39 +0000 (14:31 +0000)]
Explicitly add linking to our website to the "asking permission for things"
section.
Replace the FAQ text with a summary + link to feedback.but.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6613
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 14 Mar 2006 22:01:27 +0000 (22:01 +0000)]
Fix minor memory leak.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6611
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 14 Mar 2006 11:21:59 +0000 (11:21 +0000)]
Pageant docs didn't mention that you could load keys into an existing
Pageant from the command line.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6610
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 12 Mar 2006 22:17:46 +0000 (22:17 +0000)]
Equivalent of r6583 window-border palette-change fix for Gtk.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6609
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 12 Mar 2006 19:24:05 +0000 (19:24 +0000)]
Dimitry Andric spotted that DH gex with SHA-256 was overflowing a buffer.
Fixed, and added paranoia so that this shouldn't happen again.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6606
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 12 Mar 2006 15:39:19 +0000 (15:39 +0000)]
Log the hash used for DH kex (now there's a choice).
git-svn-id: svn://svn.tartarus.org/sgt/putty@6605
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 12 Mar 2006 14:53:18 +0000 (14:53 +0000)]
Fix inadvertent O(N^2) loop within do_paint() which I just
discovered when profiling IPBT.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6602
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 8 Mar 2006 23:16:52 +0000 (23:16 +0000)]
Flesh out `-m' caveats slightly.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6595
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 8 Mar 2006 18:15:16 +0000 (18:15 +0000)]
Oh, and update the docs for NetHack keypad mode too.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6594
cda61777-01e9-0310-a592-
d414129be87e
simon [Wed, 8 Mar 2006 18:10:12 +0000 (18:10 +0000)]
David Damerell tells me I should be using Ctrl-hjklyubn rather than
Shift-hjklyubn for batch movement in NetHack, because they have
subtly different behaviour within the game and the Ctrl-moves are
more useful. Unfortunately, PuTTY's NetHack keypad mode doesn't
support Ctrl-moves. Therefore, it does now :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6593
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 27 Feb 2006 23:55:07 +0000 (23:55 +0000)]
Fix a memory leak in key generation.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6587
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 27 Feb 2006 22:30:38 +0000 (22:30 +0000)]
Change XXX-REMOVE-BEFORE-RELEASE to XXX-REVIEW-BEFORE-RELEASE to allow
more general changes to be queued up.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6586
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 27 Feb 2006 22:27:49 +0000 (22:27 +0000)]
Batch of miscellaneous tweaks to the Windows installer:
- Now we've fixed `win-versioninfo', choose some sensible outcomes from
the installer's comparisons of binary version numbers. Also, give the
installer _itself_ a matching binary version.
In particular, without this change, it would not have been possible
to downgrade PuTTY -- it would have silently left the "newer" files in
place. Now it will make some fuss, but permit it.
- Also remove descriptions from shortcuts, on the grounds that the
binaries have embedded descriptions now. (Although I've not checked
whether those are actually visible in the Start Menu.)
- At the request of various people (e.g., PJB), add flags so that if
files are in use at the time the (un)installer is run, replacement is
deferred to the next restart. (The user may be prompted to restart,
which isn't ideal; see comments).
This is supposed to make centrally-pushed silent upgrades more robust.
- Note some limitations of the installer.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6585
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 25 Feb 2006 14:13:46 +0000 (14:13 +0000)]
Alain Guibert points out that palette changes weren't causing the space
between the text area and the window border to be refreshed.
Fixed on Windows. Gtk still has a similar problem.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6583
cda61777-01e9-0310-a592-
d414129be87e
simon [Thu, 23 Feb 2006 13:38:44 +0000 (13:38 +0000)]
Do proper select-for-write on ptys. Currently, pasting a
sufficiently large string into pterm in any circumstances in which
it's echoed back to the terminal will cause a deadlock once the
pty's write buffer fills up.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6582
cda61777-01e9-0310-a592-
d414129be87e
simon [Mon, 20 Feb 2006 19:54:17 +0000 (19:54 +0000)]
Alain Guibert points out that ESC]P sequences were erroneously
accepting 'G' as a hex digit. (The _first_ digit of the sequence
intentionally goes up further than F, but the remaining ones
shouldn't have.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6581
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 19 Feb 2006 22:37:31 +0000 (22:37 +0000)]
Daniel Meidlinger points out a redundant test :-)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6579
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 19 Feb 2006 14:59:48 +0000 (14:59 +0000)]
Fix `restart-reset-terminal': terminal now restored to a sensible state when
reusing a window to restart a session.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6577
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 19 Feb 2006 14:10:02 +0000 (14:10 +0000)]
Add/tweak a couple of comments.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6576
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 19 Feb 2006 12:52:28 +0000 (12:52 +0000)]
Fix up documentation/usage messages for r6572.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6574
cda61777-01e9-0310-a592-
d414129be87e
simon [Sun, 19 Feb 2006 12:05:12 +0000 (12:05 +0000)]
Introduce a new checkbox and command-line option to inhibit use of
Pageant for local authentication. (This is a `don't use Pageant for
authentication at session startup' button rather than a `pretend
Pageant doesn't exist' button: that is, agent forwarding is
independent of this option.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6572
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 19 Feb 2006 01:37:45 +0000 (01:37 +0000)]
At last, a fix for `large-clipboard-crash'.
A growable buffer was only being grown for actual text, not for newlines or
trailing NULs. A large run of empty lines could lead to newlines overflowing
the buffer (> 100 should be enough to guarantee this on all platforms, after
the initial 5k size of the buffer).
Also fix some valgrind in the same area (was probably harmless), and a memory
leak introduced by the RTF attribute pasting.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6570
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 18 Feb 2006 22:30:10 +0000 (22:30 +0000)]
Pointer type correction in term_clrsb().
(Harmless, as it happens.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6568
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 14 Feb 2006 13:14:08 +0000 (13:14 +0000)]
Typo in r6555 spotted by Daniel Meidlinger.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6558
cda61777-01e9-0310-a592-
d414129be87e
owen [Mon, 13 Feb 2006 22:25:59 +0000 (22:25 +0000)]
RTF pasting now includes colours and style. Say so.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6557
cda61777-01e9-0310-a592-
d414129be87e
owen [Mon, 13 Feb 2006 22:18:17 +0000 (22:18 +0000)]
Preserve more attributes of text copied as RTF. Thanks to Stephen Balousek.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6555
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 11 Feb 2006 19:10:01 +0000 (19:10 +0000)]
Don Heap spotted that our heuristics for dealing with IPv6 literal addresses
in the PSCP command line were bogus, giving "remote to remote not supported"
errors with filenames like '[].txt'. Made the heuristic less bogus.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6551
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 11 Feb 2006 18:29:55 +0000 (18:29 +0000)]
Failure to connect to a Unix-domain socket could cause a segfault. Fixed.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6550
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sat, 11 Feb 2006 18:00:23 +0000 (18:00 +0000)]
A zero-length return from platform_get_x_display() (for instance, a
zero-length DISPLAY variable in the environment) caused an assertion
failure when X11 forwarding was attempted. Fixed (now treated the same
as a NULL return, e.g., a non-existent DISPLAY variable).
git-svn-id: svn://svn.tartarus.org/sgt/putty@6549
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 10 Feb 2006 20:57:40 +0000 (20:57 +0000)]
Oops. Since r6546, old "Special Commands" menus weren't being deleted from the
context menu, and they tended to pile up.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6547
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 9 Feb 2006 23:06:57 +0000 (23:06 +0000)]
Users of Virtual Dimension are reporting that the "Close" menu item and
button tend to get disabled on login.
After a suggestion by "Tkil", change the way we handle the specials menu
to be robust against the window menu being externally modified.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6546
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 27 Jan 2006 20:49:59 +0000 (20:49 +0000)]
Somewhat gruesome tweak to use SetClassLongPtr where available and degrade
nicely elsewhere, which should fix `win64' _properly_.
Tested on recent-ish MinGW (with GetWindowLongPtr but not GetClassLongPtr),
and VC++ 6.0 with a recent SDK, but not with vanilla VC++.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6535
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 25 Jan 2006 22:46:33 +0000 (22:46 +0000)]
Don't explicitly open the logfile on startup; it'll automatically be opened
by logwrite() as necessary. Should fix win-askappend-multi.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6533
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 24 Jan 2006 11:08:34 +0000 (11:08 +0000)]
s/PuTTY/PuTTYgen/ in two places.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6528
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 11 Jan 2006 23:43:04 +0000 (23:43 +0000)]
VC6 doesn't define LONG_PTR
git-svn-id: svn://svn.tartarus.org/sgt/putty@6520
cda61777-01e9-0310-a592-
d414129be87e
owen [Wed, 11 Jan 2006 23:42:02 +0000 (23:42 +0000)]
Configurable font quality on Windows. (Together with a little bit of
macro stuff to cope with the inadequacy of VC++ 6 headers.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6519
cda61777-01e9-0310-a592-
d414129be87e
owen [Tue, 10 Jan 2006 20:02:22 +0000 (20:02 +0000)]
Fix zero-rows-cols-crash
git-svn-id: svn://svn.tartarus.org/sgt/putty@6515
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 8 Jan 2006 18:18:11 +0000 (18:18 +0000)]
It's a new year.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6513
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 18 Dec 2005 17:05:21 +0000 (17:05 +0000)]
Update status of this library wrt other variants.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6500
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 18 Dec 2005 16:57:00 +0000 (16:57 +0000)]
CP866 is popular and small. Add it to both the general and PuTTY
implementations of libcharset, since we've had at least one request for
it in PuTTY.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6499
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 16 Dec 2005 16:43:28 +0000 (16:43 +0000)]
Mention compile-time directives and where they're documented.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6497
cda61777-01e9-0310-a592-
d414129be87e
simon [Fri, 9 Dec 2005 20:04:19 +0000 (20:04 +0000)]
A few small changes to make the PuTTY source base more usable as a
basis for other terminal-involving applications: a stub
implementation of the printing interface, an additional function in
notiming.c, and also I've renamed the front-end function beep() to
do_beep() so as not to clash with beep() in lib[n]curses.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6479
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 7 Dec 2005 18:01:40 +0000 (18:01 +0000)]
Apparently some SSH servers object to our claiming port-forwarded connections
to be from IP "client-side-connection". Claiming "0.0.0.0" instead seems to
work. Spotted by Brant Thomsen.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6477
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 7 Dec 2005 00:24:45 +0000 (00:24 +0000)]
Institutional failure to memset() things pointed at rather than pointers.
Things should now be zeroed and memory not leaked. Spotted by Brant Thomsen.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6476
cda61777-01e9-0310-a592-
d414129be87e
jacob [Tue, 6 Dec 2005 23:18:27 +0000 (23:18 +0000)]
Improvements from Spyros Blanas to the MSVC optimisations of r6469:
don't do a function call for each divmod, and don't rely on details of
the calling convention.
(This didn't actually make any measurable difference to runtime in any
of my tests, but we may as well keep it as it's neater.)
Also document some general caveats of the divmod macro.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6475
cda61777-01e9-0310-a592-
d414129be87e
jacob [Thu, 1 Dec 2005 16:41:49 +0000 (16:41 +0000)]
SSH-2 rekey bug compatibility setting wasn't being saved
(but _was_ being loaded).
git-svn-id: svn://svn.tartarus.org/sgt/putty@6473
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 23 Nov 2005 21:26:05 +0000 (21:26 +0000)]
An MSVC version of the 16->32-bit bignum optimisation, derived from part of
a patch by Lionel Fourquaux. Seems to be about a factor of four improvement
(see wishlist item for details).
I don't claim to understand this in detail, so I can't vouch for its
correctness, but it didn't fall over immediately. It also produces some
compiler warnings, unfortunately.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6469
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 14 Nov 2005 09:41:42 +0000 (09:41 +0000)]
Missing close parenthesis.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6461
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 13 Nov 2005 16:06:41 +0000 (16:06 +0000)]
r6437 broke the case where Pageant is running but contains no SSH-2 keys
that the SSH-2 server is happy with. Fixed, and since I'm here, fix
`pubkeyfile-and-pageant' as well (for SSH-1 and SSH-2).
Also, in SSH-2, we now reexamine "methods that can continue" for every
Pageant key offer, which is technically more correct although it seems
unlikely that it was causing any real problems.
(It's not entirely pretty, but neither was the old code. We could probably
do with some sort of abstraction for public/private keys to avoid carting
lots of fiddly bits of data around.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6459
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 13 Nov 2005 12:13:09 +0000 (12:13 +0000)]
Oops, used \I where I meant \i. I think this is the only instance.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6454
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 9 Nov 2005 23:19:33 +0000 (23:19 +0000)]
I broke the ability to cope with multiple consecutive k-i INFO_REQUESTS
in r6437. This ought to be better (but I can't test that case).
git-svn-id: svn://svn.tartarus.org/sgt/putty@6451
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 4 Nov 2005 23:31:11 +0000 (23:31 +0000)]
Fix minor hiccup in SSH-1 p-k auth.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6447
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 4 Nov 2005 23:21:42 +0000 (23:21 +0000)]
Placate a compiler warning introduced in r6437.
(I forgot we usually compile with -Werror on Unix, oops.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6446
cda61777-01e9-0310-a592-
d414129be87e
jacob [Fri, 4 Nov 2005 14:49:22 +0000 (14:49 +0000)]
Fix for `ssh2-password-expiry'. Success case tested.
(Much easier since r6437, and actually works to boot.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6445
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 2 Nov 2005 23:15:43 +0000 (23:15 +0000)]
When a userpass interaction has finished, make sure the 'prompts' structure
is safe for re-use.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6444
cda61777-01e9-0310-a592-
d414129be87e
jacob [Mon, 31 Oct 2005 22:43:51 +0000 (22:43 +0000)]
(do_ssh2_authconn_state).method is redundant since r6427; remove.
Remove FIXMEs from .type assignments, as they look fine.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6442
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 30 Oct 2005 20:24:09 +0000 (20:24 +0000)]
Revamp SSH authentication code so that user interaction is more
abstracted out; replace loops structured around a single interaction
per loop with less tortuous code (fixes: `ki-multiprompt-crash',
`ssh1-bad-passphrase-crash'; makes `ssh2-password-expiry' and
`proxy-password-prompt' easier).
The new interaction abstraction has a lot of fields that are unused in
the current code (things like window captions); this is groundwork for
`gui-auth'. However, ssh.c still writes directly to stderr; that may
want to be fixed.
In the GUI apps, user interaction is moved to terminal.c. This should
make it easier to fix things like UTF-8 username entry, although I
haven't attempted to do so. Also, control character filtering can be
tailored to be appropriate for individual front-ends; so far I don't
promise anything other than not having made it any worse.
I've tried to test this fairly exhaustively (although Mac stuff is
untested, as usual). It all seems to basically work, but I bet there
are new bugs. (One I know about is that you can no longer make the
PuTTY window go away with a ^D at the password prompt; this should be
fixed.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6437
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 30 Oct 2005 19:13:43 +0000 (19:13 +0000)]
In Unix PuTTYgen, existing SSH-1 key comments were coming out as "(null)"
for operations not performing decryption (e.g., "puttygen rsa1.ppk -L")
(A use for r6434 -- wasn't expecting that.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6436
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 30 Oct 2005 16:28:45 +0000 (16:28 +0000)]
Fixes to make r6434 actually useful.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6435
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 30 Oct 2005 15:16:42 +0000 (15:16 +0000)]
Allow rsakey_pubblob() to return the key comment.
(like r6433 but for SSH-1)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6434
cda61777-01e9-0310-a592-
d414129be87e
jacob [Sun, 30 Oct 2005 13:42:36 +0000 (13:42 +0000)]
Add ability for ssh2_userkey_loadpub() to return the key comment.
(Not actually used currently, but it makes life easier for a patch I'm
working on.)
git-svn-id: svn://svn.tartarus.org/sgt/putty@6433
cda61777-01e9-0310-a592-
d414129be87e
jacob [Wed, 26 Oct 2005 22:18:11 +0000 (22:18 +0000)]
Fix an error I introduced into SSH packet logging in r5642: some outgoing
packets over about 256 bytes would be logged with 12 bytes of preceding
garbage. (But the rest of the packet was logged in its entirety. This
holds for packets where (int(len/256)%2)==1, with an appropriate fudge
factor applied to `len'.) Ahem.
git-svn-id: svn://svn.tartarus.org/sgt/putty@6429
cda61777-01e9-0310-a592-
d414129be87e