From: simon <simon@cda61777-01e9-0310-a592-d414129be87e>
Date: Sun, 14 Jan 2007 13:44:07 +0000 (+0000)
Subject: Remove the loops that close all open fds before running a
X-Git-Url: https://git.distorted.org.uk/~mdw/sgt/putty/commitdiff_plain/90f2ed42275289be8b7b178d5f5b91e5f05fccfd?hp=90f2ed42275289be8b7b178d5f5b91e5f05fccfd

Remove the loops that close all open fds before running a
subprocess. They were intended to make sure the child process didn't
inherit anything embarrassing or inconvenient from us, such as the
master end of its own pty, but now we instead do this by making sure
to set all our own fds to not-FD_CLOEXEC on creation. This should
fix Debian bug #357520.

(This doesn't seem to work _quite_ right in uxproxy.c's invocation
of a local proxy command: both ends of a GTK internal pipe end up in
the child process's fd space. This appears to be another GTK 1 bug,
inasmuch as it goes away when I build with Colin's preliminary GTK 2
patch; for the moment I think leaving that pipe lying around is
probably less harmful than hampering the proxy process's ability to
use extra fds by prior arrangement with PuTTY's parent process.)


git-svn-id: svn://svn.tartarus.org/sgt/putty@7107 cda61777-01e9-0310-a592-d414129be87e
---