From: simon <simon@cda61777-01e9-0310-a592-d414129be87e>
Date: Tue, 18 Dec 2012 09:02:38 +0000 (+0000)
Subject: Use O_NOCTTY (if available) when opening /dev/ptmx, just in case any
X-Git-Url: https://git.distorted.org.uk/~mdw/sgt/putty/commitdiff_plain/193c8d4a7559f40fe0e0c8610cf6832a0e976e77

Use O_NOCTTY (if available) when opening /dev/ptmx, just in case any
OS doesn't automatically assume it.

(It would seem faintly weird to me - surely opening the master end of
a given pty is a fairly good indication that you're _not_ a process
running inside it which wants to have it available as /dev/tty! But
you never know...)


git-svn-id: svn://svn.tartarus.org/sgt/putty@9727 cda61777-01e9-0310-a592-d414129be87e
---

diff --git a/unix/uxpty.c b/unix/uxpty.c
index 36a05fcc..99c1221a 100644
--- a/unix/uxpty.c
+++ b/unix/uxpty.c
@@ -335,7 +335,14 @@ static void pty_open_master(Pty pty)
     chown(pty->name, getuid(), gp ? gp->gr_gid : -1);
     chmod(pty->name, 0600);
 #else
-    pty->master_fd = open("/dev/ptmx", O_RDWR);
+
+    const int flags = O_RDWR
+#ifdef O_NOCTTY
+        | O_NOCTTY
+#endif
+        ;
+
+    pty->master_fd = open("/dev/ptmx", flags);
 
     if (pty->master_fd < 0) {
 	perror("/dev/ptmx: open");