From: simon <simon@cda61777-01e9-0310-a592-d414129be87e>
Date: Sun, 4 Aug 2013 19:33:46 +0000 (+0000)
Subject: Remove some redundant null-pointer checks from code that must have
X-Git-Url: https://git.distorted.org.uk/~mdw/sgt/putty/commitdiff_plain/14ec1d8392d27cd5f9dc923ff7dc6416827d4060

Remove some redundant null-pointer checks from code that must have
been written before I wrote a never-failing snew.


git-svn-id: svn://svn.tartarus.org/sgt/putty@9985 cda61777-01e9-0310-a592-d414129be87e
---

diff --git a/sshdss.c b/sshdss.c
index 8c9f93e3..e634b984 100644
--- a/sshdss.c
+++ b/sshdss.c
@@ -89,8 +89,6 @@ static void *dss_newkey(char *data, int len)
     struct dss_key *dss;
 
     dss = snew(struct dss_key);
-    if (!dss)
-	return NULL;
     getstring(&data, &len, &p, &slen);
 
 #ifdef DEBUG_DSS
@@ -430,8 +428,6 @@ static void *dss_openssh_createkey(unsigned char **blob, int *len)
     struct dss_key *dss;
 
     dss = snew(struct dss_key);
-    if (!dss)
-	return NULL;
 
     dss->p = getmp(b, len);
     dss->q = getmp(b, len);
diff --git a/sshrsa.c b/sshrsa.c
index 07853646..3bd971f8 100644
--- a/sshrsa.c
+++ b/sshrsa.c
@@ -558,8 +558,6 @@ static void *rsa2_newkey(char *data, int len)
     struct RSAKey *rsa;
 
     rsa = snew(struct RSAKey);
-    if (!rsa)
-	return NULL;
     getstring(&data, &len, &p, &slen);
 
     if (!p || slen != 7 || memcmp(p, "ssh-rsa", 7)) {
@@ -694,8 +692,6 @@ static void *rsa2_openssh_createkey(unsigned char **blob, int *len)
     struct RSAKey *rsa;
 
     rsa = snew(struct RSAKey);
-    if (!rsa)
-	return NULL;
     rsa->comment = NULL;
 
     rsa->modulus = getmp(b, len);