X-Git-Url: https://git.distorted.org.uk/~mdw/sgt/putty/blobdiff_plain/f668fdf37d5b25f354c8541c1c6dda7c74cb6444..f8c9f9df8c6d537b3db60823b5920d78705b929b:/mac/mac.c diff --git a/mac/mac.c b/mac/mac.c index a2e89f91..f663deea 100644 --- a/mac/mac.c +++ b/mac/mac.c @@ -694,8 +694,15 @@ int agent_query(void *in, int inlen, void **out, int *outlen, void verify_ssh_host_key(void *frontend, char *host, int port, char *keytype, char *keystr, char *fingerprint) { - Str255 stuff; + Str255 pappname; + Str255 pfingerprint; + Str255 pkeytype; Session *s = frontend; + int ret, alertret; + + c2pstrcpy(pappname, appname); + c2pstrcpy(pkeytype, keytype); + c2pstrcpy(pfingerprint, fingerprint); /* * This function is horribly wrong. For one thing, the alert @@ -703,24 +710,54 @@ void verify_ssh_host_key(void *frontend, char *host, int port, char *keytype, * Aqua. Also, PuTTY might be in the background, in which case we * should use the Notification Manager to wake up the user. In * any case, we shouldn't hold up processing of other connections' - * data just because this one's waiting for the user. It should - * also handle a host key cache, of course, and see the note below - * about closing the connection. All in all, a bit of a mess - * really. + * data just because this one's waiting for the user. Also see the + * note below about closing the connection. All in all, a bit of + * a mess really. */ - stuff[0] = sprintf((char *)(&stuff[1]), - "The server's key fingerprint is: %s\n" - "Continue connecting?", fingerprint); - ParamText(stuff, NULL, NULL, NULL); - if (CautionAlert(wQuestion, NULL) == 2) { - /* - * User chose "Cancel". Unfortunately, if I tear the - * connection down here, Bad Things happen when I return. I - * think this function should actually return something - * telling the SSH code to abandon the connection. - */ + /* Verify the key against the cache */ + + ret = verify_host_key(host, port, keytype, keystr); + + if (ret == 0) /* success - key matched OK */ + return; + if (ret == 2) { /* key was different */ + ParamText(pappname, pkeytype, pfingerprint, NULL); + alertret=CautionAlert(wWrong, NULL); + if (alertret == 8) { + /* Cancel */ + goto cancel; + } else if (alertret == 9) { + /* Connect Just Once */ + } else { + /* Update Key */ + store_host_key(host, port, keytype, keystr); + } + } + if (ret == 1) { /* key was absent */ + ParamText(pkeytype, pfingerprint, pappname, NULL); + alertret=CautionAlert(wAbsent, NULL); + if (alertret == 7) { + /* Cancel */ + goto cancel; + } else if (alertret == 8) { + /* Connect Just Once */ + } else { + /* Update Key */ + store_host_key(host, port, keytype, keystr); + } } + + return; + + cancel: + /* + * User chose "Cancel". Unfortunately, if I tear the + * connection down here, Bad Things happen when I return. I + * think this function should actually return something + * telling the SSH code to abandon the connection. + */ + return; } void askalg(void *frontend, const char *algtype, const char *algname)