X-Git-Url: https://git.distorted.org.uk/~mdw/sgt/putty/blobdiff_plain/4f2b387f9cba569d49559f88e785639d56ea2d66..f21d1674c6cd193198907ae82738fe22983ba869:/psftp.c

diff --git a/psftp.c b/psftp.c
index 37f39ff3..d181af96 100644
--- a/psftp.c
+++ b/psftp.c
@@ -24,6 +24,9 @@
  * send buffer.
  */
 
+static int psftp_connect(char *userhost, char *user, int portnumber);
+static void do_sftp_init(void);
+
 /* ----------------------------------------------------------------------
  * sftp client state.
  */
@@ -130,6 +133,30 @@ char *canonify(char *name)
     }
 }
 
+/*
+ * Return a pointer to the portion of str that comes after the last
+ * slash (or backslash or colon, if `local' is TRUE).
+ */
+static char *stripslashes(char *str, int local)
+{
+    char *p;
+
+    if (local) {
+        p = strchr(str, ':');
+        if (p) str = p+1;
+    }
+
+    p = strrchr(str, '/');
+    if (p) str = p+1;
+
+    if (local) {
+	p = strrchr(str, '\\');
+	if (p) str = p+1;
+    }
+
+    return str;
+}
+
 /* ----------------------------------------------------------------------
  * Actual sftp commands.
  */
@@ -141,13 +168,13 @@ struct sftp_command {
 
 int sftp_cmd_null(struct sftp_command *cmd)
 {
-    return 0;
+    return 1;			       /* success */
 }
 
 int sftp_cmd_unknown(struct sftp_command *cmd)
 {
     printf("psftp: unknown command \"%s\"\n", cmd->words[0]);
-    return 0;
+    return 0;			       /* failure */
 }
 
 int sftp_cmd_quit(struct sftp_command *cmd)
@@ -174,6 +201,11 @@ int sftp_cmd_ls(struct sftp_command *cmd)
     char *dir, *cdir;
     int i;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     if (cmd->nwords < 2)
 	dir = ".";
     else
@@ -237,7 +269,7 @@ int sftp_cmd_ls(struct sftp_command *cmd)
 
     sfree(cdir);
 
-    return 0;
+    return 1;
 }
 
 /*
@@ -249,6 +281,11 @@ int sftp_cmd_cd(struct sftp_command *cmd)
     struct fxp_handle *dirh;
     char *dir;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     if (cmd->nwords < 2)
 	dir = dupstr(homedir);
     else
@@ -272,7 +309,7 @@ int sftp_cmd_cd(struct sftp_command *cmd)
     pwd = dir;
     printf("Remote directory is now %s\n", pwd);
 
-    return 0;
+    return 1;
 }
 
 /*
@@ -280,8 +317,13 @@ int sftp_cmd_cd(struct sftp_command *cmd)
  */
 int sftp_cmd_pwd(struct sftp_command *cmd)
 {
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     printf("Remote directory is %s\n", pwd);
-    return 0;
+    return 1;
 }
 
 /*
@@ -296,6 +338,12 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
     char *fname, *outfname;
     uint64 offset;
     FILE *fp;
+    int ret;
+
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
 
     if (cmd->nwords < 2) {
 	printf("get: expects a filename\n");
@@ -307,7 +355,8 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
 	printf("%s: %s\n", cmd->words[1], fxp_error());
 	return 0;
     }
-    outfname = (cmd->nwords == 2 ? cmd->words[1] : cmd->words[2]);
+    outfname = (cmd->nwords == 2 ?
+		stripslashes(cmd->words[1], 0) : cmd->words[2]);
 
     fh = fxp_open(fname, SSH_FXF_READ);
     if (!fh) {
@@ -345,6 +394,7 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
      * FIXME: we can use FXP_FSTAT here to get the file size, and
      * thus put up a progress bar.
      */
+    ret = 1;
     while (1) {
 	char buffer[4096];
 	int len;
@@ -355,6 +405,7 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
 	    break;
 	if (len == -1) {
 	    printf("error while reading: %s\n", fxp_error());
+	    ret = 0;
 	    break;
 	}
 
@@ -363,12 +414,15 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
 	    wlen = fwrite(buffer, 1, len - wpos, fp);
 	    if (wlen <= 0) {
 		printf("error while writing local file\n");
+		ret = 0;
 		break;
 	    }
 	    wpos += wlen;
 	}
-	if (wpos < len)		       /* we had an error */
+	if (wpos < len) {	       /* we had an error */
+	    ret = 0;
 	    break;
+	}
 	offset = uint64_add32(offset, len);
     }
 
@@ -376,7 +430,7 @@ int sftp_general_get(struct sftp_command *cmd, int restart)
     fxp_close(fh);
     sfree(fname);
 
-    return 0;
+    return ret;
 }
 int sftp_cmd_get(struct sftp_command *cmd)
 {
@@ -399,6 +453,12 @@ int sftp_general_put(struct sftp_command *cmd, int restart)
     char *fname, *origoutfname, *outfname;
     uint64 offset;
     FILE *fp;
+    int ret;
+
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
 
     if (cmd->nwords < 2) {
 	printf("put: expects a filename\n");
@@ -406,7 +466,8 @@ int sftp_general_put(struct sftp_command *cmd, int restart)
     }
 
     fname = cmd->words[1];
-    origoutfname = (cmd->nwords == 2 ? cmd->words[1] : cmd->words[2]);
+    origoutfname = (cmd->nwords == 2 ?
+		    stripslashes(cmd->words[1], 1) : cmd->words[2]);
     outfname = canonify(origoutfname);
     if (!outfname) {
 	printf("%s: %s\n", origoutfname, fxp_error());
@@ -465,6 +526,7 @@ int sftp_general_put(struct sftp_command *cmd, int restart)
      * FIXME: we can use FXP_FSTAT here to get the file size, and
      * thus put up a progress bar.
      */
+    ret = 1;
     while (1) {
 	char buffer[4096];
 	int len;
@@ -472,12 +534,14 @@ int sftp_general_put(struct sftp_command *cmd, int restart)
 	len = fread(buffer, 1, sizeof(buffer), fp);
 	if (len == -1) {
 	    printf("error while reading local file\n");
+	    ret = 0;
 	    break;
 	} else if (len == 0) {
 	    break;
 	}
 	if (!fxp_write(fh, buffer, offset, len)) {
 	    printf("error while writing: %s\n", fxp_error());
+	    ret = 0;
 	    break;
 	}
 	offset = uint64_add32(offset, len);
@@ -487,7 +551,7 @@ int sftp_general_put(struct sftp_command *cmd, int restart)
     fclose(fp);
     sfree(outfname);
 
-    return 0;
+    return ret;
 }
 int sftp_cmd_put(struct sftp_command *cmd)
 {
@@ -503,6 +567,10 @@ int sftp_cmd_mkdir(struct sftp_command *cmd)
     char *dir;
     int result;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
 
     if (cmd->nwords < 2) {
 	printf("mkdir: expects a directory\n");
@@ -523,7 +591,7 @@ int sftp_cmd_mkdir(struct sftp_command *cmd)
     }
 
     sfree(dir);
-    return 0;
+    return 1;
 }
 
 int sftp_cmd_rmdir(struct sftp_command *cmd)
@@ -531,6 +599,10 @@ int sftp_cmd_rmdir(struct sftp_command *cmd)
     char *dir;
     int result;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
 
     if (cmd->nwords < 2) {
 	printf("rmdir: expects a directory\n");
@@ -551,7 +623,7 @@ int sftp_cmd_rmdir(struct sftp_command *cmd)
     }
 
     sfree(dir);
-    return 0;
+    return 1;
 }
 
 int sftp_cmd_rm(struct sftp_command *cmd)
@@ -559,6 +631,11 @@ int sftp_cmd_rm(struct sftp_command *cmd)
     char *fname;
     int result;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     if (cmd->nwords < 2) {
 	printf("rm: expects a filename\n");
 	return 0;
@@ -578,8 +655,7 @@ int sftp_cmd_rm(struct sftp_command *cmd)
     }
 
     sfree(fname);
-    return 0;
-
+    return 1;
 }
 
 int sftp_cmd_mv(struct sftp_command *cmd)
@@ -587,6 +663,11 @@ int sftp_cmd_mv(struct sftp_command *cmd)
     char *srcfname, *dstfname;
     int result;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     if (cmd->nwords < 3) {
 	printf("mv: expects two filenames\n");
 	return 0;
@@ -644,7 +725,7 @@ int sftp_cmd_mv(struct sftp_command *cmd)
 
     sfree(srcfname);
     sfree(dstfname);
-    return 0;
+    return 1;
 }
 
 int sftp_cmd_chmod(struct sftp_command *cmd)
@@ -654,6 +735,11 @@ int sftp_cmd_chmod(struct sftp_command *cmd)
     struct fxp_attrs attrs;
     unsigned attrs_clr, attrs_xor, oldperms, newperms;
 
+    if (back == NULL) {
+	printf("psftp: not connected to a host; use \"open host.name\"\n");
+	return 0;
+    }
+
     if (cmd->nwords < 3) {
 	printf("chmod: expects a mode specifier and a filename\n");
 	return 0;
@@ -795,7 +881,27 @@ int sftp_cmd_chmod(struct sftp_command *cmd)
     printf("%s: %04o -> %04o\n", fname, oldperms, newperms);
 
     sfree(fname);
-    return 0;
+    return 1;
+}
+
+static int sftp_cmd_open(struct sftp_command *cmd)
+{
+    if (back != NULL) {
+	printf("psftp: already connected\n");
+	return 0;
+    }
+
+    if (cmd->nwords < 2) {
+	printf("open: expects a host name\n");
+	return 0;
+    }
+
+    if (psftp_connect(cmd->words[1], NULL, 0)) {
+	back = NULL;		       /* connection is already closed */
+	return -1;		       /* this is fatal */
+    }
+    do_sftp_init();
+    return 1;
 }
 
 static int sftp_cmd_help(struct sftp_command *cmd);
@@ -928,6 +1034,14 @@ static struct sftp_cmd_lookup {
 	    sftp_cmd_put
     },
     {
+	"open", "connect to a host",
+	    " [<user>@]<hostname>\n"
+	    "  Establishes an SFTP connection to a given host. Only usable\n"
+	    "  when you did not already specify a host name on the command\n"
+	    "  line.\n",
+	    sftp_cmd_open
+    },
+    {
 	"pwd", "print your remote working directory",
 	    "\n"
 	    "  Print the current remote working directory for your SFTP session.\n",
@@ -1033,7 +1147,7 @@ static int sftp_cmd_help(struct sftp_command *cmd)
 	    }
 	}
     }
-    return 0;
+    return 1;
 }
 
 /* ----------------------------------------------------------------------
@@ -1047,9 +1161,9 @@ struct sftp_command *sftp_getcmd(FILE *fp, int mode, int modeflags)
     char *p, *q, *r;
     int quoting;
 
-	if ((mode == 0) || (modeflags & 1)) {
-	    printf("psftp> ");
-	}
+    if ((mode == 0) || (modeflags & 1)) {
+	printf("psftp> ");
+    }
     fflush(stdout);
 
     cmd = smalloc(sizeof(struct sftp_command));
@@ -1066,9 +1180,6 @@ struct sftp_command *sftp_getcmd(FILE *fp, int mode, int modeflags)
 	linesize += 512;
 	line = srealloc(line, linesize);
 	ret = fgets(line + linelen, linesize - linelen, fp);
-	if (modeflags & 1) {
-		printf("%s", ret);
-	}
 
 	if (!ret || (linelen == 0 && line[0] == '\0')) {
 	    cmd->obey = sftp_cmd_quit;
@@ -1083,6 +1194,9 @@ struct sftp_command *sftp_getcmd(FILE *fp, int mode, int modeflags)
 	    break;
 	}
     }
+    if (modeflags & 1) {
+	printf("%s\n", line);
+    }
 
     /*
      * Parse the command line into words. The syntax is:
@@ -1147,10 +1261,8 @@ struct sftp_command *sftp_getcmd(FILE *fp, int mode, int modeflags)
     return cmd;
 }
 
-void do_sftp(int mode, int modeflags, char *batchfile)
+static void do_sftp_init(void)
 {
-    FILE *fp;
-
     /*
      * Do protocol initialisation. 
      */
@@ -1173,6 +1285,12 @@ void do_sftp(int mode, int modeflags, char *batchfile)
 	printf("Remote working directory is %s\n", homedir);
     }
     pwd = dupstr(homedir);
+}
+
+void do_sftp(int mode, int modeflags, char *batchfile)
+{
+    FILE *fp;
+    int ret;
 
     /*
      * Batch mode?
@@ -1183,12 +1301,12 @@ void do_sftp(int mode, int modeflags, char *batchfile)
          * Now we're ready to do Real Stuff.
          */
         while (1) {
-    	struct sftp_command *cmd;
-    	cmd = sftp_getcmd(stdin, 0, 0);
-    	if (!cmd)
-    	    break;
-		if (cmd->obey(cmd) < 0)
-		    break;
+	    struct sftp_command *cmd;
+	    cmd = sftp_getcmd(stdin, 0, 0);
+	    if (!cmd)
+		break;
+	    if (cmd->obey(cmd) < 0)
+		break;
 	}
     } else {
         fp = fopen(batchfile, "r");
@@ -1201,9 +1319,10 @@ void do_sftp(int mode, int modeflags, char *batchfile)
 	    cmd = sftp_getcmd(fp, mode, modeflags);
 	    if (!cmd)
 		break;
-	    if (cmd->obey(cmd) < 0)
+	    ret = cmd->obey(cmd);
+	    if (ret < 0)
 		break;
-	    if (fxp_error() != NULL) {
+	    if (ret == 0) {
 		if (!(modeflags & 2))
 		    break;
 	    }
@@ -1336,6 +1455,25 @@ void askcipher(char *ciphername, int cs)
 }
 
 /*
+ * Warn about the obsolescent key file format.
+ */
+void old_keyfile_warning(void)
+{
+    static const char message[] =
+	"You are loading an SSH 2 private key which has an\n"
+	"old version of the file format. This means your key\n"
+	"file is not fully tamperproof. Future versions of\n"
+	"PuTTY may stop supporting this private key format,\n"
+	"so we recommend you convert your key to the new\n"
+	"format.\n"
+	"\n"
+	"Once the key is loaded into PuTTYgen, you can perform\n"
+	"this conversion simply by saving it again.\n";
+
+    fputs(message, stderr);
+}
+
+/*
  *  Print an error message and perform a fatal exit.
  */
 void fatalbox(char *fmt, ...)
@@ -1347,7 +1485,7 @@ void fatalbox(char *fmt, ...)
     vsprintf(str + strlen(str), fmt, ap);
     va_end(ap);
     strcat(str, "\n");
-    fprintf(stderr, str);
+    fputs(stderr, str);
 
     exit(1);
 }
@@ -1360,7 +1498,7 @@ void connection_fatal(char *fmt, ...)
     vsprintf(str + strlen(str), fmt, ap);
     va_end(ap);
     strcat(str, "\n");
-    fprintf(stderr, str);
+    fputs(stderr, str);
 
     exit(1);
 }
@@ -1369,7 +1507,7 @@ void logevent(char *string)
 {
 }
 
-void ldisc_send(char *buf, int len)
+void ldisc_send(char *buf, int len, int interactive)
 {
     /*
      * This is only here because of the calls to ldisc_send(NULL,
@@ -1603,62 +1741,12 @@ static void usage(void)
 }
 
 /*
- * Main program. Parse arguments etc.
+ * Connect to a host.
  */
-int main(int argc, char *argv[])
+static int psftp_connect(char *userhost, char *user, int portnumber)
 {
-    int i;
-    int portnumber = 0;
-    char *user, *host, *userhost, *realhost;
+    char *host, *realhost;
     char *err;
-    int mode = 0;
-    int modeflags = 0;
-    char *batchfile = NULL;
-
-    flags = FLAG_STDERR | FLAG_INTERACTIVE;
-    ssh_get_line = &get_line;
-    init_winsock();
-    sk_init();
-
-    userhost = user = NULL;
-
-    for (i = 1; i < argc; i++) {
-	if (argv[i][0] != '-') {
-	    if (userhost)
-		usage();
-	    else
-		userhost = dupstr(argv[i]);
-	} else if (strcmp(argv[i], "-v") == 0) {
-	    verbose = 1, flags |= FLAG_VERBOSE;
-	} else if (strcmp(argv[i], "-h") == 0 ||
-		   strcmp(argv[i], "-?") == 0) {
-	    usage();
-	} else if (strcmp(argv[i], "-l") == 0 && i + 1 < argc) {
-	    user = argv[++i];
-	} else if (strcmp(argv[i], "-P") == 0 && i + 1 < argc) {
-	    portnumber = atoi(argv[++i]);
-	} else if (strcmp(argv[i], "-pw") == 0 && i + 1 < argc) {
-	    password = argv[++i];
-    } else if (strcmp(argv[i], "-b") == 0 && i + 1 < argc) {
-	    mode = 1;
-        batchfile = argv[++i];
-    } else if (strcmp(argv[i], "-bc") == 0 && i + 1 < argc) {
-	    modeflags = modeflags | 1;
-    } else if (strcmp(argv[i], "-be") == 0 && i + 1 < argc) {
-	    modeflags = modeflags | 2;
-	} else if (strcmp(argv[i], "--") == 0) {
-	    i++;
-	    break;
-	} else {
-	    usage();
-	}
-    }
-    argc -= i;
-    argv += i;
-    back = NULL;
-
-    if (argc > 0 || !userhost)
-	usage();
 
     /* Separate host and username */
     host = userhost;
@@ -1684,6 +1772,32 @@ int main(int argc, char *argv[])
 	cfg.port = 22;
     }
 
+    /*
+     * Trim leading whitespace off the hostname if it's there.
+     */
+    {
+	int space = strspn(cfg.host, " \t");
+	memmove(cfg.host, cfg.host+space, 1+strlen(cfg.host)-space);
+    }
+
+    /* See if host is of the form user@host */
+    if (cfg.host[0] != '\0') {
+	char *atsign = strchr(cfg.host, '@');
+	/* Make sure we're not overflowing the user field */
+	if (atsign) {
+	    if (atsign - cfg.host < sizeof cfg.username) {
+		strncpy(cfg.username, cfg.host, atsign - cfg.host);
+		cfg.username[atsign - cfg.host] = '\0';
+	    }
+	    memmove(cfg.host, atsign + 1, 1 + strlen(atsign + 1));
+	}
+    }
+
+    /*
+     * Trim a colon suffix off the hostname if it's there.
+     */
+    cfg.host[strcspn(cfg.host, ":")] = '\0';
+
     /* Set username */
     if (user != NULL && user[0] != '\0') {
 	strncpy(cfg.username, user, sizeof(cfg.username) - 1);
@@ -1710,6 +1824,15 @@ int main(int argc, char *argv[])
     /* SFTP uses SSH2 by default always */
     cfg.sshprot = 2;
 
+    /*
+     * Disable scary things which shouldn't be enabled for simple
+     * things like SCP and SFTP: agent forwarding, port forwarding,
+     * X forwarding.
+     */
+    cfg.x11_forward = 0;
+    cfg.agentfwd = 0;
+    cfg.portfwd[0] = cfg.portfwd[1] = '\0';
+
     /* Set up subsystem name. */
     strcpy(cfg.remote_cmd, "sftp");
     cfg.ssh_subsys = TRUE;
@@ -1740,14 +1863,83 @@ int main(int argc, char *argv[])
 
     back = &ssh_backend;
 
-    err = back->init(cfg.host, cfg.port, &realhost);
+    err = back->init(cfg.host, cfg.port, &realhost, 0);
     if (err != NULL) {
-	fprintf(stderr, "ssh_init: %s", err);
+	fprintf(stderr, "ssh_init: %s\n", err);
 	return 1;
     }
     ssh_sftp_init();
     if (verbose && realhost != NULL)
 	printf("Connected to %s\n", realhost);
+    return 0;
+}
+
+/*
+ * Main program. Parse arguments etc.
+ */
+int main(int argc, char *argv[])
+{
+    int i;
+    int portnumber = 0;
+    char *userhost, *user;
+    int mode = 0;
+    int modeflags = 0;
+    char *batchfile = NULL;
+
+    flags = FLAG_STDERR | FLAG_INTERACTIVE;
+    ssh_get_line = &get_line;
+    init_winsock();
+    sk_init();
+
+    userhost = user = NULL;
+
+    for (i = 1; i < argc; i++) {
+	if (argv[i][0] != '-') {
+	    if (userhost)
+		usage();
+	    else
+		userhost = dupstr(argv[i]);
+	} else if (strcmp(argv[i], "-v") == 0) {
+	    verbose = 1, flags |= FLAG_VERBOSE;
+	} else if (strcmp(argv[i], "-h") == 0 ||
+		   strcmp(argv[i], "-?") == 0) {
+	    usage();
+	} else if (strcmp(argv[i], "-l") == 0 && i + 1 < argc) {
+	    user = argv[++i];
+	} else if (strcmp(argv[i], "-P") == 0 && i + 1 < argc) {
+	    portnumber = atoi(argv[++i]);
+	} else if (strcmp(argv[i], "-pw") == 0 && i + 1 < argc) {
+	    password = argv[++i];
+	} else if (strcmp(argv[i], "-b") == 0 && i + 1 < argc) {
+	    mode = 1;
+	    batchfile = argv[++i];
+	} else if (strcmp(argv[i], "-bc") == 0 && i + 1 < argc) {
+	    modeflags = modeflags | 1;
+	} else if (strcmp(argv[i], "-be") == 0 && i + 1 < argc) {
+	    modeflags = modeflags | 2;
+	} else if (strcmp(argv[i], "--") == 0) {
+	    i++;
+	    break;
+	} else {
+	    usage();
+	}
+    }
+    argc -= i;
+    argv += i;
+    back = NULL;
+
+    /*
+     * If a user@host string has already been provided, connect to
+     * it now.
+     */
+    if (userhost) {
+	if (psftp_connect(userhost, user, portnumber))
+	    return 1;
+	do_sftp_init();
+    } else {
+	printf("psftp: no hostname specified; use \"open host.name\""
+	    " to connect\n");
+    }
 
     do_sftp(mode, modeflags, batchfile);