~mdw
/
sgt
/
putty
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Richard Boulton's patch for improved correctness in selection
[sgt/putty]
/
proxy.c
diff --git
a/proxy.c
b/proxy.c
index
59f2abb
..
169be0d
100644
(file)
--- a/
proxy.c
+++ b/
proxy.c
@@
-16,7
+16,9
@@
#define do_proxy_dns(cfg) \
(cfg->proxy_dns == FORCE_ON || \
#define do_proxy_dns(cfg) \
(cfg->proxy_dns == FORCE_ON || \
- (cfg->proxy_dns == AUTO && cfg->proxy_type != PROXY_SOCKS))
+ (cfg->proxy_dns == AUTO && \
+ cfg->proxy_type != PROXY_SOCKS4 && \
+ cfg->proxy_type != PROXY_SOCKS5))
/*
* Call this when proxy negotiation is complete, so that this
/*
* Call this when proxy negotiation is complete, so that this
@@
-88,6
+90,7
@@
static void sk_proxy_close (Socket s)
Proxy_Socket ps = (Proxy_Socket) s;
sk_close(ps->sub_socket);
Proxy_Socket ps = (Proxy_Socket) s;
sk_close(ps->sub_socket);
+ sk_addr_free(ps->remote_addr);
sfree(ps);
}
sfree(ps);
}
@@
-232,7
+235,7
@@
static void plug_proxy_sent (Plug p, int bufsize)
plug_sent(ps->plug, bufsize);
}
plug_sent(ps->plug, bufsize);
}
-static int plug_proxy_accepting (Plug p,
void *
sock)
+static int plug_proxy_accepting (Plug p,
OSSocket
sock)
{
Proxy_Plug pp = (Proxy_Plug) p;
Proxy_Socket ps = pp->proxy_socket;
{
Proxy_Plug pp = (Proxy_Plug) p;
Proxy_Socket ps = pp->proxy_socket;
@@
-316,9
+319,9
@@
static int proxy_for_destination (SockAddr addr, char *hostname, int port,
* match (ie. a specific IP)
*/
* match (ie. a specific IP)
*/
- if (addr && str
icmp(hostip, exclude_list +
s) == 0)
+ if (addr && str
nicmp(hostip, exclude_list + s, e -
s) == 0)
return 0; /* IP/hostname excluded. do not use proxy. */
return 0; /* IP/hostname excluded. do not use proxy. */
- if (str
icmp(hostname, exclude_list +
s) == 0)
+ if (str
nicmp(hostname, exclude_list + s, e -
s) == 0)
return 0; /* IP/hostname excluded. do not use proxy. */
}
return 0; /* IP/hostname excluded. do not use proxy. */
}
@@
-347,11
+350,6
@@
SockAddr name_lookup(char *host, int port, char **canonicalname,
return sk_namelookup(host, canonicalname);
}
return sk_namelookup(host, canonicalname);
}
-Socket platform_new_connection(SockAddr addr, char *hostname,
- int port, int privport,
- int oobinline, int nodelay, Plug plug,
- const Config *cfg);
-
Socket new_connection(SockAddr addr, char *hostname,
int port, int privport,
int oobinline, int nodelay, Plug plug,
Socket new_connection(SockAddr addr, char *hostname,
int port, int privport,
int oobinline, int nodelay, Plug plug,
@@
-385,15
+383,16
@@
Socket new_connection(SockAddr addr, char *hostname,
char *proxy_canonical_name;
Socket sret;
char *proxy_canonical_name;
Socket sret;
- if ( (sret = platform_new_connection(addr, hostname, port, privport,
- oobinline, nodelay, plug, cfg)) )
+ if ((sret = platform_new_connection(addr, hostname, port, privport,
+ oobinline, nodelay, plug, cfg)) !=
+ NULL)
return sret;
ret = snew(struct Socket_proxy_tag);
ret->fn = &socket_fn_table;
ret->cfg = *cfg; /* STRUCTURE COPY */
ret->plug = plug;
return sret;
ret = snew(struct Socket_proxy_tag);
ret->fn = &socket_fn_table;
ret->cfg = *cfg; /* STRUCTURE COPY */
ret->plug = plug;
- ret->remote_addr = addr;
+ ret->remote_addr = addr;
/* will need to be freed on close */
ret->remote_port = port;
ret->error = NULL;
ret->remote_port = port;
ret->error = NULL;
@@
-410,11
+409,10
@@
Socket new_connection(SockAddr addr, char *hostname,
if (cfg->proxy_type == PROXY_HTTP) {
ret->negotiate = proxy_http_negotiate;
if (cfg->proxy_type == PROXY_HTTP) {
ret->negotiate = proxy_http_negotiate;
- } else if (cfg->proxy_type == PROXY_SOCKS) {
- if (cfg->proxy_socks_version == 4)
- ret->negotiate = proxy_socks4_negotiate;
- else
- ret->negotiate = proxy_socks5_negotiate;
+ } else if (cfg->proxy_type == PROXY_SOCKS4) {
+ ret->negotiate = proxy_socks4_negotiate;
+ } else if (cfg->proxy_type == PROXY_SOCKS5) {
+ ret->negotiate = proxy_socks5_negotiate;
} else if (cfg->proxy_type == PROXY_TELNET) {
ret->negotiate = proxy_telnet_negotiate;
} else {
} else if (cfg->proxy_type == PROXY_TELNET) {
ret->negotiate = proxy_telnet_negotiate;
} else {
@@
-446,8
+444,6
@@
Socket new_connection(SockAddr addr, char *hostname,
if (sk_socket_error(ret->sub_socket) != NULL)
return (Socket) ret;
if (sk_socket_error(ret->sub_socket) != NULL)
return (Socket) ret;
- sk_addr_free(proxy_addr);
-
/* start the proxy negotiation process... */
sk_set_frozen(ret->sub_socket, 0);
ret->negotiate(ret, PROXY_CHANGE_NEW);
/* start the proxy negotiation process... */
sk_set_frozen(ret->sub_socket, 0);
ret->negotiate(ret, PROXY_CHANGE_NEW);