From 6e3fd952d7052293905334a3bb3911c775222ea6 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sun, 13 Apr 2014 15:43:15 +0100 Subject: [PATCH] netlink: Only complain about initial frags for us secnet has no reassembly code and logs whenever it receives fragments. Change this to only log when receiving initial fragments; this reduces noise in the log. Signed-off-by: Ian Jackson --- netlink.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/netlink.c b/netlink.c index 55eef5c..2c3d12d 100644 --- a/netlink.c +++ b/netlink.c @@ -775,9 +775,12 @@ static void netlink_packet_local(struct netlink *st, } h=(struct icmphdr *)buf->start; - if ((ntohs(h->iph.frag)&(IPHDR_FRAG_OFF|IPHDR_FRAG_MORE))!=0) { - Message(M_WARNING,"%s: fragmented packet addressed to secnet; " - "ignoring it\n",st->name); + unsigned fraginfo = ntohs(h->iph.frag); + if ((fraginfo&(IPHDR_FRAG_OFF|IPHDR_FRAG_MORE))!=0) { + if (!(fraginfo & IPHDR_FRAG_OFF)) + /* report only for first fragment */ + Message(M_WARNING,"%s: fragmented packet addressed to secnet; " + "ignoring it\n",st->name); BUF_FREE(buf); return; } -- 2.11.0