X-Git-Url: https://git.distorted.org.uk/~mdw/secnet/blobdiff_plain/c1ddd026a2cc6d68a0d47033817a3d9b7670a71e..763e458ff3a1cb4f9d11226db91f17069f7b8f7a:/udp.c

diff --git a/udp.c b/udp.c
index d2c0aad..9101e49 100644
--- a/udp.c
+++ b/udp.c
@@ -23,38 +23,15 @@
 #include "unaligned.h"
 #include "ipaddr.h"
 #include "magic.h"
+#include "comm-common.h"
 
 static beforepoll_fn udp_beforepoll;
 static afterpoll_fn udp_afterpoll;
-static comm_request_notify_fn request_notify;
-static comm_release_notify_fn release_notify;
 static comm_sendmsg_fn udp_sendmsg;
 
-struct comm_notify_entry {
-    comm_notify_fn *fn;
-    void *state;
-    LIST_ENTRY(comm_notify_entry) entry;
-};
-LIST_HEAD(comm_notify_list, comm_notify_entry) notify;
-
-#define UDP_MAX_SOCKETS 3 /* 2 ought to do really */
-
-struct udpsock {
-    union iaddr addr;
-    int fd;
-};
-
 struct udp {
-    closure_t cl;
-    struct comm_if ops;
-    struct cloc loc;
-    int n_socks;
-    struct udpsock socks[UDP_MAX_SOCKETS];
-    string_t authbind;
-    struct buffer_if *rbuf;
-    struct comm_notify_list notify;
-    bool_t use_proxy;
-    union iaddr proxy;
+    struct udpcommon uc;
+    struct udpsocks socks;
 };
 
 /*
@@ -69,9 +46,10 @@ struct udp {
  * description of the source of an incoming packet.
  */
 
-static const char *addr_to_string(void *commst, const struct comm_addr *ca) {
+static const char *udp_addr_to_string(void *commst, const struct comm_addr *ca)
+{
     struct udp *st=commst;
-    struct udp *socks=st; /* for now */
+    struct udpsocks *socks=&st->socks;
     static char sbuf[100];
     int ix=ca->ix>=0 ? ca->ix : 0;
 
@@ -83,12 +61,11 @@ static const char *addr_to_string(void *commst, const struct comm_addr *ca) {
     return sbuf;
 }
 
-static int udp_beforepoll(void *state, struct pollfd *fds, int *nfds_io,
-			  int *timeout_io)
+int udp_socks_beforepoll(struct udpsocks *socks,
+			 struct pollfd *fds, int *nfds_io,
+			 int *timeout_io)
 {
     int i;
-    struct udp *st=state;
-    struct udp *socks=st; /* for now */
     BEFOREPOLL_WANT_FDS(socks->n_socks);
     for (i=0; i<socks->n_socks; i++) {
 	fds[i].fd=socks->socks[i].fd;
@@ -97,20 +74,25 @@ static int udp_beforepoll(void *state, struct pollfd *fds, int *nfds_io,
     return 0;
 }
 
-static void udp_afterpoll(void *state, struct pollfd *fds, int nfds)
+static int udp_beforepoll(void *state, struct pollfd *fds, int *nfds_io,
+			  int *timeout_io)
 {
     struct udp *st=state;
-    struct udp *socks=st; /* for now */
-    struct udp *cc=st; /* for now */
-    struct udp *uc=st; /* for now */
+    return udp_socks_beforepoll(&st->socks,fds,nfds_io,timeout_io);
+}
+
+void udp_socks_afterpoll(struct udpcommon *uc, struct udpsocks *socks,
+			 struct pollfd *fds, int nfds)
+{
     union iaddr from;
     socklen_t fromlen;
-    struct comm_notify_entry *n;
     bool_t done;
     int rv;
     int i;
 
-    for (i=0; i<st->n_socks; i++) {
+    struct commcommon *cc=&uc->cc;
+
+    for (i=0; i<socks->n_socks; i++) {
 	if (i>=nfds) continue;
 	if (!(fds[i].revents & POLLIN)) continue;
 	assert(fds[i].fd == socks->socks[i].fd);
@@ -145,13 +127,7 @@ static void udp_afterpoll(void *state, struct pollfd *fds, int nfds)
 		ca.comm=&cc->ops;
 		ca.ia=from;
 		ca.ix=i;
-		done=False;
-		LIST_FOREACH(n, &cc->notify, entry) {
-		    if (n->fn(n->state, cc->rbuf, &ca)) {
-			done=True;
-			break;
-		    }
-		}
+		done=comm_notify(&cc->notify, cc->rbuf, &ca);
 		if (!done) {
 		    uint32_t msgtype;
 		    if (cc->rbuf->size>12 /* prevents traffic amplification */
@@ -173,39 +149,18 @@ static void udp_afterpoll(void *state, struct pollfd *fds, int nfds)
     }
 }
 
-static void request_notify(void *commst, void *nst, comm_notify_fn *fn)
-{
-    struct udp *st=commst;
-    struct udp *cc=st; /* for now */
-    struct comm_notify_entry *n;
-    
-    n=safe_malloc(sizeof(*n),"request_notify");
-    n->fn=fn;
-    n->state=nst;
-    LIST_INSERT_HEAD(&cc->notify, n, entry);
-}
-
-static void release_notify(void *commst, void *nst, comm_notify_fn *fn)
+static void udp_afterpoll(void *state, struct pollfd *fds, int nfds)
 {
-    struct udp *st=commst;
-    struct udp *cc=st; /* for now */
-    struct comm_notify_entry *n, *t;
-
-    /* XXX untested */
-    LIST_FOREACH_SAFE(n, &cc->notify, entry, t) {
-	if (n->state==nst && n->fn==fn) {
-	    LIST_REMOVE(n, entry);
-	    free(n);
-	}
-    }
+    struct udp *st=state;
+    return udp_socks_afterpoll(&st->uc,&st->socks,fds,nfds);
 }
 
 static bool_t udp_sendmsg(void *commst, struct buffer_if *buf,
 			  const struct comm_addr *dest)
 {
     struct udp *st=commst;
-    struct udp *uc=st; /* for now */
-    struct udp *socks=st; /* for now */
+    struct udpcommon *uc=&st->uc;
+    struct udpsocks *socks=&st->socks;
     uint8_t *sa;
 
     if (uc->use_proxy) {
@@ -245,8 +200,9 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf,
 static void udp_make_socket(struct udp *st, struct udpsock *us)
 {
     const union iaddr *addr=&us->addr;
-    struct udp *cc=st; /* for now */
-    struct udp *uc=st; /* for now */
+    struct udpcommon *uc=&st->uc;
+    struct commcommon *cc=&uc->cc;
+
     us->fd=socket(addr->sa.sa_family, SOCK_DGRAM, IPPROTO_UDP);
     if (us->fd<0) {
 	fatal_perror("udp (%s:%d): socket",cc->loc.file,cc->loc.line);
@@ -333,7 +289,7 @@ static void udp_make_socket(struct udp *st, struct udpsock *us)
 static void udp_phase_hook(void *sst, uint32_t new_phase)
 {
     struct udp *st=sst;
-    struct udp *socks=st; /* for now */
+    struct udpsocks *socks=&st->socks;
     int i;
     for (i=0; i<socks->n_socks; i++)
 	udp_make_socket(st,&socks->socks[i]);
@@ -345,46 +301,27 @@ static list_t *udp_apply(closure_t *self, struct cloc loc, dict_t *context,
 			 list_t *args)
 {
     struct udp *st;
-    item_t *item;
     list_t *caddrl;
-    dict_t *d;
     list_t *l;
     uint32_t a;
     int i;
 
-    st=safe_malloc(sizeof(*st),"udp_apply(st)");
-    struct udp *cc=st; /* for now */
-    struct udp *uc=st; /* for now */
-    struct udp *socks=st; /* for now */
-    cc->loc=loc;
-    cc->cl.description="udp";
-    cc->cl.type=CL_COMM;
-    cc->cl.apply=NULL;
-    cc->cl.interface=&cc->ops;
-    cc->ops.st=st;
-    cc->ops.request_notify=request_notify;
-    cc->ops.release_notify=release_notify;
-    cc->ops.sendmsg=udp_sendmsg;
-    cc->ops.addr_to_string=addr_to_string;
-    uc->use_proxy=False;
-    LIST_INIT(&cc->notify);
-
-    item=list_elem(args,0);
-    if (!item || item->type!=t_dict) {
-	cfgfatal(cc->loc,"udp","first argument must be a dictionary\n");
-    }
-    d=item->data.dict;
+    COMM_APPLY(st,&st->uc.cc,udp_,"udp",loc);
+    COMM_APPLY_STANDARD(st,&st->uc.cc,"udp",args);
+    UDP_APPLY_STANDARD(st,&st->uc,"udp");
 
-    int port=dict_read_number(d,"port",True,"udp",cc->loc,0);
+    struct udpcommon *uc=&st->uc;
+    struct udpsocks *socks=&st->socks;
+    struct commcommon *cc=&uc->cc;
 
     union iaddr defaultaddrs[] = {
 #ifdef CONFIG_IPV6
 	{ .sin6 = { .sin6_family=AF_INET6,
-		    .sin6_port=htons(port),
+		    .sin6_port=htons(uc->port),
 		    .sin6_addr=IN6ADDR_ANY_INIT } },
 #endif
 	{ .sin = { .sin_family=AF_INET,
-		   .sin_port=htons(port),
+		   .sin_port=htons(uc->port),
 		   .sin_addr= { .s_addr=INADDR_ANY } } }
     };
 
@@ -399,13 +336,11 @@ static list_t *udp_apply(closure_t *self, struct cloc loc, dict_t *context,
 	if (!list_length(caddrl)) {
 	    us->addr=defaultaddrs[i];
 	} else {
-	    string_item_to_iaddr(list_elem(caddrl,i),port,&us->addr,"udp");
+	    string_item_to_iaddr(list_elem(caddrl,i),uc->port,&us->addr,"udp");
 	}
 	us->fd=-1;
     }
 
-    cc->rbuf=find_cl_if(d,"buffer",CL_BUFFER,True,"udp",cc->loc);
-    uc->authbind=dict_read_string(d,"authbind",False,"udp",cc->loc);
     l=dict_lookup(d,"proxy");
     if (l) {
 	uc->use_proxy=True;