X-Git-Url: https://git.distorted.org.uk/~mdw/secnet/blobdiff_plain/ba703386fd742f46f83430a7c48a9bfe53167eae..c20710ab7a759a23cd0ce8be63a732eff89e5692:/slip.c

diff --git a/slip.c b/slip.c
index 4c0cac1..fad0a7e 100644
--- a/slip.c
+++ b/slip.c
@@ -273,8 +273,6 @@ static void userv_entry(void *sst)
     dup2(st->out,1);
 
     setsid();
-    /* XXX We really should strdup() all of argv[] but because we'll just
-       exit anyway if execvp() fails it doesn't seem worth bothering. */
     execvp(st->path,(char *const*)st->argv);
     perror("userv-entry: execvp()");
     exit(1);
@@ -385,6 +383,9 @@ static void userv_invoke_userv(struct userv *st)
     }
     setnonblock(st->txfd);
     setnonblock(st->rxfd);
+
+    add_hook(PHASE_CHILDPERSIST,childpersist_closefd_hook,&st->txfd);
+    add_hook(PHASE_CHILDPERSIST,childpersist_closefd_hook,&st->rxfd);
 }
 
 static void userv_kill_userv(struct userv *st)