netlink: Make ip_csum and ip_fast_csum const-correct

[secnet] / netlink.c

diff --git a/netlink.c b/netlink.c
index 61841b0..0dd4450 100644 (file)
--- a/netlink.c
+++ b/netlink.c
@@ -120,7 +120,7 @@ their use.
 #define ICMP_CODE_TTL_EXCEEDED           0
 
 /* Generic IP checksum routine */
-static inline uint16_t ip_csum(uint8_t *iph,int32_t count)
+static inline uint16_t ip_csum(const uint8_t *iph,int32_t count)
 {
     register uint32_t sum=0;
 
@@ -144,7 +144,7 @@ static inline uint16_t ip_csum(uint8_t *iph,int32_t count)
  *      By Jorge Cwik <jorge@laser.satlink.net>, adapted for linux by
  *      Arnt Gulbrandsen.
  */
-static inline uint16_t ip_fast_csum(uint8_t *iph, int32_t ihl) {
+static inline uint16_t ip_fast_csum(const uint8_t *iph, int32_t ihl) {
     uint32_t sum;
 
     __asm__ __volatile__(
@@ -210,7 +210,7 @@ struct icmphdr {
     uint8_t type;
     uint8_t code;
     uint16_t check;
-    union {
+    union icmpinfofield {
        uint32_t unused;
        struct {
            uint8_t pointer;
@@ -224,6 +224,8 @@ struct icmphdr {
        } echo;
     } d;
 };
+
+static const union icmpinfofield icmp_noinfo;
     
 static void netlink_packet_deliver(struct netlink *st,
                                   struct netlink_client *client,
@@ -302,9 +304,17 @@ static bool_t netlink_icmp_may_reply(struct buffer_if *buf)
     icmph=(struct icmphdr *)buf->start;
     if (iph->protocol==1) {
        switch(icmph->type) {
-       case 3: /* Destination unreachable */
-       case 11: /* Time Exceeded */
-       case 12: /* Parameter Problem */
+           /* Based on http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp-parameters-types
+            * as retrieved Thu, 20 Mar 2014 00:16:44 +0000.
+            * Deprecated, reserved, unassigned and experimental
+            * options are treated as not safe to reply to.
+            */
+       case 0: /* Echo Reply */
+       case 8: /* Echo */
+       case 13: /* Timestamp */
+       case 14: /* Timestamp Reply */
+           return True;
+       default:
            return False;
        }
     }
@@ -358,7 +368,8 @@ static uint16_t netlink_icmp_reply_len(struct buffer_if *buf)
    comes from. NULL indicates the host. */
 static void netlink_icmp_simple(struct netlink *st, struct buffer_if *buf,
                                struct netlink_client *client,
-                               uint8_t type, uint8_t code)
+                               uint8_t type, uint8_t code,
+                               union icmpinfofield info)
 {
     struct icmphdr *h;
     uint16_t len;
@@ -367,7 +378,7 @@ static void netlink_icmp_simple(struct netlink *st, struct buffer_if *buf,
        struct iphdr *iph=(struct iphdr *)buf->start;
        len=netlink_icmp_reply_len(buf);
        h=netlink_icmp_tmpl(st,ntohl(iph->saddr),len);
-       h->type=type; h->code=code;
+       h->type=type; h->code=code; h->d=info;
        memcpy(buf_append(&st->icmp,len),buf->start,len);
        netlink_icmp_csum(h);
        netlink_packet_deliver(st,NULL,&st->icmp);
@@ -525,7 +536,7 @@ static void netlink_packet_deliver(struct netlink *st,
                    "(s=%s, d=%s)\n", st->name, s, d);
            free(s); free(d);
            netlink_icmp_simple(st,buf,client,ICMP_TYPE_UNREACHABLE,
-                               ICMP_CODE_NET_UNREACHABLE);
+                               ICMP_CODE_NET_UNREACHABLE, icmp_noinfo);
            BUF_FREE(buf);
        }
     } else {
@@ -542,7 +553,7 @@ static void netlink_packet_deliver(struct netlink *st,
            free(s); free(d);
                    
            netlink_icmp_simple(st,buf,client,ICMP_TYPE_UNREACHABLE,
-                               ICMP_CODE_NET_PROHIBITED);
+                               ICMP_CODE_NET_PROHIBITED, icmp_noinfo);
            BUF_FREE(buf);
        } else {
            if (best_quality>0) {
@@ -552,8 +563,10 @@ static void netlink_packet_deliver(struct netlink *st,
                BUF_ASSERT_FREE(buf);
            } else {
                /* Generate ICMP destination unreachable */
-               netlink_icmp_simple(st,buf,client,ICMP_TYPE_UNREACHABLE,
-                                   ICMP_CODE_NET_UNREACHABLE); /* client==NULL */
+               netlink_icmp_simple(st,buf,client,/* client==NULL */
+                                   ICMP_TYPE_UNREACHABLE,
+                                   ICMP_CODE_NET_UNREACHABLE,
+                                   icmp_noinfo);
                BUF_FREE(buf);
            }
        }
@@ -574,7 +587,7 @@ static void netlink_packet_forward(struct netlink *st,
     if (iph->ttl<=1) {
        /* Generate ICMP time exceeded */
        netlink_icmp_simple(st,buf,client,ICMP_TYPE_TIME_EXCEEDED,
-                           ICMP_CODE_TTL_EXCEEDED);
+                           ICMP_CODE_TTL_EXCEEDED,icmp_noinfo);
        BUF_FREE(buf);
        return;
     }
@@ -629,7 +642,7 @@ static void netlink_packet_local(struct netlink *st,
     } else {
        /* Send ICMP protocol unreachable */
        netlink_icmp_simple(st,buf,client,ICMP_TYPE_UNREACHABLE,
-                           ICMP_CODE_PROTOCOL_UNREACHABLE);
+                           ICMP_CODE_PROTOCOL_UNREACHABLE,icmp_noinfo);
        BUF_FREE(buf);
        return;
     }