From 1e082a8681747b3968d0af6ce6a55283460bc641 Mon Sep 17 00:00:00 2001 From: Mark Wooding Date: Tue, 7 Mar 2006 14:25:03 +0000 Subject: [PATCH] Remove the various `getuNN' functions and replace them with getulong(). They weren't doing any real good anyway, and the implementation was randomly buggy. --- catacomb-python.h | 3 +-- util.c | 16 +++++++--------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/catacomb-python.h b/catacomb-python.h index fa99298..722d7ad 100644 --- a/catacomb-python.h +++ b/catacomb-python.h @@ -237,8 +237,7 @@ extern int convszt(PyObject *, void *); extern int convbool(PyObject *, void *); extern PyObject *abstract_pynew(PyTypeObject *, PyObject *, PyObject *); extern PyObject *getbool(int); -#define DECL_GETU_(n) extern PyObject *getu##n(uint##n); -DOUINTSZ(DECL_GETU_) +extern PyObject *getulong(unsigned long); extern void *newtype(PyTypeObject *, const PyTypeObject *, const char *); extern PyObject * mkexc(PyObject *, PyObject *, const char *, PyMethodDef *); diff --git a/util.c b/util.c index 27af83a..166cdbb 100644 --- a/util.c +++ b/util.c @@ -32,15 +32,13 @@ /*----- Conversions -------------------------------------------------------*/ -#define GETU_(n) \ - PyObject *getu##n(uint##n w) \ - { \ - if (w <= MASK##n) \ - return (PyInt_FromLong(w)); \ - else \ - return (PyLong_FromUnsignedLong(w)); \ - } -DOUINTSZ(GETU_) +PyObject *getulong(unsigned long w) +{ + if (w <= MASK32) + return (PyInt_FromLong(w)); + else + return (PyLong_FromUnsignedLong(w)); +} PyObject *getbool(int b) { -- 2.11.0