From: Mark Wooding Date: Thu, 11 May 2017 09:42:15 +0000 (+0100) Subject: utils.c: Raise exceptions from `convTHING' with null arguments. X-Git-Url: https://git.distorted.org.uk/~mdw/pyke/commitdiff_plain/2ed3b5080980781d53c9f50aed97934c0f589474 utils.c: Raise exceptions from `convTHING' with null arguments. This can happen as a result of using `convTHING' in an attribute `set' function, and the Python program trying to `del' the attribute. Unfortunately, these conversion functions are already being used in this context, and it leads to segfaults, e.g., from del C.Key(C.KeyFile('', C.KOPEN_WRITE | C.KOPEN_NOFILE), 0, 'k').exptime Easy fix. --- diff --git a/util.c b/util.c index d4b7fb0..7118bfb 100644 --- a/util.c +++ b/util.c @@ -133,6 +133,7 @@ int convk64(PyObject *o, void *pp) int rc = 0; uint32 lo, hi; + if (!o) VALERR("can't delete"); if (init_i32()) goto end; if ((i = PyNumber_Int(o)) == 0) goto end; lo = PyInt_AsUnsignedLongMask(i);