#include <assert.h>
#include <ctype.h>
#include <errno.h>
+#include <stdarg.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
_(recvfrom, ssize_t, (int, void *buf, size_t, int, \
struct sockaddr *from, socklen_t *fromlen)) \
_(sendmsg, ssize_t, (int, const struct msghdr *, int)) \
- _(recvmsg, ssize_t, (int, struct msghdr *, int))
+ _(recvmsg, ssize_t, (int, struct msghdr *, int)) \
+ _(ioctl, int, (int, unsigned long, ...))
/* Function pointers to set up. */
#define DECL(imp, ret, args) static ret (*real_##imp) args;
default: abort();
}
}
+
/* Extract the address part from SA and store it in A. */
static void ipaddr_from_sockaddr(ipaddr *a, const struct sockaddr *sa)
{
} break;
case AF_INET6: {
struct sockaddr_in6 *sin6 = SIN6(sa);
- memset(sin6, 0, sizeof(sin6));
+ memset(sin6, 0, sizeof(*sin6));
sin6->sin6_family = AF_INET6;
sin6->sin6_port = 0;
sin6->sin6_addr = in6addr_any;
#ifdef DEBUG
/* Write to standard error a description of the ACL node A. */
-static void dump_aclnode(aclnode *a)
+static void dump_aclnode(const aclnode *a)
{
char buf[ADDRBUFSZ];
const char *p;
fputc('\n', stderr);
}
-static void dump_acl(aclnode *a)
+static void dump_acl(const aclnode *a)
{
int act = ALLOW;
#endif
/* Returns nonzero if the ACL A allows the socket address SA. */
-static int acl_allows_p(aclnode *a, const struct sockaddr *sa)
+static int acl_allows_p(const aclnode *a, const struct sockaddr *sa)
{
unsigned short port = port_from_sockaddr(sa);
int act = ALLOW;
}
/* Decode the Unix address SUN to an Internet address SIN. If AF_HINT is
- * nonzero, an empty address (indicative of an unbound Unix-domain socket) of
- * the is translated to a wildcard Internet address of the appropriate
- * family. Returns zero on success; -1 on failure (e.g., it wasn't one of
- * our addresses).
+ * nonzero, an empty address (indicative of an unbound Unix-domain socket) is
+ * translated to a wildcard Internet address of the appropriate family.
+ * Returns zero on success; -1 on failure (e.g., it wasn't one of our
+ * addresses).
*/
static int decode_inet_addr(struct sockaddr *sa, int af_hint,
const struct sockaddr_un *sun,
/* SK is (or at least might be) a Unix-domain socket we created when an
* Internet socket was asked for. We've decided it should be an Internet
- * socket after all, with family AF_HINT, so convert it.
+ * socket after all, with family AF_HINT, so convert it. If TMP is not null,
+ * then don't replace the existing descriptor: store the new socket in *TMP
+ * and return zero.
*/
-static int fixup_real_ip_socket(int sk, int af_hint)
+static int fixup_real_ip_socket(int sk, int af_hint, int *tmp)
{
int nsk;
int type;
} while (0);
OPTS(FIX)
#undef FIX
- if ((f = fcntl(sk, F_GETFL)) < 0 ||
- (fd = fcntl(sk, F_GETFD)) < 0 ||
- fcntl(nsk, F_SETFL, f) < 0 ||
- dup2(nsk, sk) < 0) {
+ if (tmp)
+ *tmp = nsk;
+ else {
+ if ((f = fcntl(sk, F_GETFL)) < 0 ||
+ (fd = fcntl(sk, F_GETFD)) < 0 ||
+ fcntl(nsk, F_SETFL, f) < 0 ||
+ dup2(nsk, sk) < 0) {
+ close(nsk);
+ return (-1);
+ }
+ unlink(sun.sun_path);
close(nsk);
- return (-1);
- }
- unlink(sun.sun_path);
- close(nsk);
- if (fcntl(sk, F_SETFD, fd) < 0) {
- perror("noip: fixup_real_ip_socket F_SETFD");
- abort();
+ if (fcntl(sk, F_SETFD, fd) < 0) {
+ perror("noip: fixup_real_ip_socket F_SETFD");
+ abort();
+ }
}
return (0);
}
socklen_t mylen = sizeof(*sun);
if (acl_allows_p(connect_real, *sa)) {
- if (fixup_real_ip_socket(sk, (*sa)->sa_family)) return (-1);
+ if (fixup_real_ip_socket(sk, (*sa)->sa_family, 0)) return (-1);
} else {
if (real_getsockname(sk, SA(sun), &mylen) < 0) return (-1);
if (sun->sun_family == AF_UNIX) {
maxaddr = minaddr;
mask_address(af, &minaddr, n, 0);
mask_address(af, &maxaddr, n, 1);
+ RESCAN(del);
} else
maxaddr = minaddr;
parse_ports(&p, &minport, &maxport);
}
SKIPSPC;
if (*p != ',') break;
- p++;
+ if (*p) p++;
}
+ *pp = p;
return;
bad:
if (*p != '-') goto bad; p++;
NEXTNUMBER(q, del); y = strtoul(q, 0, 0); RESCAN(del);
minautoport = x; maxautoport = y;
+ *pp = p;
return;
bad:
int socketpair(int pf, int ty, int proto, int *sk)
{
- if (pf == PF_INET) {
+ if (family_known_p(pf)) {
pf = PF_UNIX;
proto = 0;
}
if (family_known_p(sa->sa_family)) {
PRESERVING_ERRNO({
if (acl_allows_p(bind_real, sa)) {
- if (fixup_real_ip_socket(sk, sa->sa_family))
+ if (fixup_real_ip_socket(sk, sa->sa_family, 0))
return (-1);
} else {
encode_inet_addr(&sun, sa, WANT_FRESH);
{
struct sockaddr_un sun;
- if (to && to->sa_family == AF_INET) {
+ if (to && family_known_p(to->sa_family)) {
PRESERVING_ERRNO({
do_implicit_bind(sk, &to, &tolen, &sun);
});
const struct sockaddr *sa;
struct msghdr mymsg;
- if (msg->msg_name && SA(msg->msg_name)->sa_family == AF_INET) {
+ if (msg->msg_name && family_known_p(SA(msg->msg_name)->sa_family)) {
PRESERVING_ERRNO({
sa = SA(msg->msg_name);
mymsg = *msg;
return (real_setsockopt(sk, lev, opt, p, len));
}
+int ioctl(int fd, unsigned long op, ...)
+{
+ va_list ap;
+ void *arg;
+ int sk;
+ int rc;
+
+ va_start(ap, op);
+ arg = va_arg(ap, void *);
+
+ switch (op) {
+ case SIOCGIFADDR:
+ case SIOCGIFBRDADDR:
+ case SIOCGIFDSTADDR:
+ case SIOCGIFNETMASK:
+ PRESERVING_ERRNO({
+ if (fixup_real_ip_socket(fd, AF_INET, &sk)) goto real;
+ });
+ rc = real_ioctl(sk, op, arg);
+ PRESERVING_ERRNO({ close(sk); });
+ break;
+ default:
+ real:
+ rc = real_ioctl(fd, op, arg);
+ break;
+ }
+ va_end(ap);
+ return (rc);
+}
+
/*----- Initialization ----------------------------------------------------*/
/* Clean up the socket directory, deleting stale sockets. */
{
struct stat st;
- if (stat(sockdir, &st)) {
+ if (lstat(sockdir, &st)) {
if (errno == ENOENT) {
if (mkdir(sockdir, 0700)) {
perror("noip: creating socketdir");
exit(127);
}
- if (!stat(sockdir, &st))
+ if (!lstat(sockdir, &st))
goto check;
}
perror("noip: checking socketdir");
~mdw / preload-hacks / blobdiff