~mdw
/
hippotat
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
rename "password" to "secret" everywhere
[hippotat]
/
hippotatd
diff --git
a/hippotatd
b/hippotatd
index
1865dad
..
bbc8666
100755
(executable)
--- a/
hippotatd
+++ b/
hippotatd
@@
-25,7
+25,7
@@
# the file AGPLv3+CAFv2. If not, email Ian Jackson
# <ijackson@chiark.greenend.org.uk>.
# the file AGPLv3+CAFv2. If not, email Ian Jackson
# <ijackson@chiark.greenend.org.uk>.
-#@
sys.path.append(@PYBUILD_INSTALL_DIR@
)
+#@
import sys; sys.path.append('@PYBUILD_INSTALL_DIR@'
)
from hippotatlib import *
import os
from hippotatlib import *
import os
@@
-38,7
+38,6
@@
import twisted.internet
from twisted.web.server import NOT_DONE_YET
import twisted.web.static
from twisted.web.server import NOT_DONE_YET
import twisted.web.static
-import twisted.python.syslog
import hippotatlib.ownsource
from hippotatlib.ownsource import SourceShipmentPreparer
import hippotatlib.ownsource
from hippotatlib.ownsource import SourceShipmentPreparer
@@
-65,7
+64,7
@@
def route(packet, iface, saddr, daddr):
elif daddr == c.vaddr or daddr not in c.vnetwork:
lt('inbound')
queue_inbound(ipif, packet)
elif daddr == c.vaddr or daddr not in c.vnetwork:
lt('inbound')
queue_inbound(ipif, packet)
- elif daddr == c.relay:
+ elif daddr == c.
v
relay:
lt('discard relay')
log_discard(packet, iface, saddr, daddr, 'relay')
else:
lt('discard relay')
log_discard(packet, iface, saddr, daddr, 'relay')
else:
@@
-105,7
+104,8
@@
class Client():
def _req_cancel(self, request):
self._log(DBG.HTTP_CTRL, 'cancel', idof=request)
def _req_cancel(self, request):
self._log(DBG.HTTP_CTRL, 'cancel', idof=request)
- request.finish()
+ try: request.finish()
+ except Exception: pass
def _req_error(self, err, request):
self._log(DBG.HTTP_CTRL, 'error %s' % err, idof=request)
def _req_error(self, err, request):
self._log(DBG.HTTP_CTRL, 'error %s' % err, idof=request)
@@
-126,7
+126,7
@@
class Client():
nf = request.notifyFinish()
nf.addErrback(self._req_error, request)
nf.addCallback(self._req_fin, request, cl)
nf = request.notifyFinish()
nf.addErrback(self._req_error, request)
nf.addCallback(self._req_fin, request, cl)
- self._rq.append(
request
)
+ self._rq.append(
(request,nf)
)
self._check_outbound()
def _req_write(self, req, d):
self._check_outbound()
def _req_write(self, req, d):
@@
-136,9
+136,9
@@
class Client():
def _check_outbound(self):
log_debug(DBG.HTTP_CTRL, 'CHKO')
while True:
def _check_outbound(self):
log_debug(DBG.HTTP_CTRL, 'CHKO')
while True:
- try:
request
= self._rq[0]
+ try:
(request,nf)
= self._rq[0]
except IndexError: request = None
except IndexError: request = None
- if request and
request.finish
ed:
+ if request and
nf.call
ed:
self._log(DBG.HTTP_CTRL, 'CHKO req finished, discard', idof=request)
self._rq.popleft()
continue
self._log(DBG.HTTP_CTRL, 'CHKO req finished, discard', idof=request)
self._rq.popleft()
continue
@@
-166,7
+166,7
@@
class Client():
# round again, looking for more to do
while len(self._rq) > self.cc.target_requests_outstanding:
# round again, looking for more to do
while len(self._rq) > self.cc.target_requests_outstanding:
-
request
= self._rq.popleft()
+
(request, nf)
= self._rq.popleft()
self._log(DBG.HTTP, 'CHKO above target, returning empty', idof=request)
request.finish()
self._log(DBG.HTTP, 'CHKO above target, returning empty', idof=request)
request.finish()
@@
-182,7
+182,7
@@
def process_request(request, desca):
ci = ipaddr(ci_s)
desca['ci'] = ci
cl = clients[ci]
ci = ipaddr(ci_s)
desca['ci'] = ci
cl = clients[ci]
- if pw != cl.cc.
password: raise ValueError('bad password
')
+ if pw != cl.cc.
secret: raise ValueError('bad secret
')
desca['pwok']=True
if tro != cl.cc.target_requests_outstanding:
desca['pwok']=True
if tro != cl.cc.target_requests_outstanding:
@@
-218,7
+218,7
@@
class NotStupidResource(twisted.web.resource.Resource):
# why this is not the default is a mystery!
def getChild(self, name, request):
if name == b'': return self
# why this is not the default is a mystery!
def getChild(self, name, request):
if name == b'': return self
- else: return twisted.web.resource.Resource.getChild(name, request)
+ else: return twisted.web.resource.Resource.getChild(
self,
name, request)
class IphttpResource(NotStupidResource):
def render_POST(self, request):
class IphttpResource(NotStupidResource):
def render_POST(self, request):
@@
-297,9
+297,10
@@
def process_cfg(_opts, putative_servers, putative_clients):
global c
c = ConfigResults()
global c
c = ConfigResults()
- c.server = cfg.get('SERVER','server')
+ try: c.server = cfg1get('SERVER','server')
+ except NoOptionError: c.server = 'SERVER'
- cfg_process_
common
(c, c.server)
+ cfg_process_
general
(c, c.server)
cfg_process_saddrs(c, c.server)
cfg_process_vnetwork(c, c.server)
cfg_process_vaddr(c, c.server)
cfg_process_saddrs(c, c.server)
cfg_process_vnetwork(c, c.server)
cfg_process_vaddr(c, c.server)
@@
-313,21
+314,24
@@
def process_cfg(_opts, putative_servers, putative_clients):
Client(ci, cc)
try:
Client(ci, cc)
try:
- c.vrelay = cfg
.
get(c.server, 'vrelay')
+ c.vrelay = cfg
1
get(c.server, 'vrelay')
except NoOptionError:
for search in c.vnetwork.hosts():
if search == c.vaddr: continue
c.vrelay = search
break
except NoOptionError:
for search in c.vnetwork.hosts():
if search == c.vaddr: continue
c.vrelay = search
break
+ try: c.ifname = cfg1get(c.server, 'ifname_server', raw=True)
+ except NoOptionError: pass
+
cfg_process_ipif(c,
cfg_process_ipif(c,
- [c.server, '
DEFAULT
'],
+ [c.server, '
COMMON
'],
(('local','vaddr'),
('peer', 'vrelay'),
('rnets','vnetwork')))
if opts.printconfig is not None:
(('local','vaddr'),
('peer', 'vrelay'),
('rnets','vnetwork')))
if opts.printconfig is not None:
- try: val = cfg
.
get(c.server, opts.printconfig)
+ try: val = cfg
1
get(c.server, opts.printconfig)
except NoOptionError: pass
else: print(val)
sys.exit(0)
except NoOptionError: pass
else: print(val)
sys.exit(0)
@@
-347,7
+351,9
@@
def catch_termination():
raise RuntimeError('did not die due to signal %s !' % name)
for sig in (signal.SIGINT, signal.SIGTERM):
raise RuntimeError('did not die due to signal %s !' % name)
for sig in (signal.SIGINT, signal.SIGTERM):
- signal.signal(sig, partial(signal_handler, sig.name))
+ try: signame = sig.name
+ except AttributeError: signame = "signal %d" % sig
+ signal.signal(sig, partial(signal_handler, signame))
def daemonise():
global syslogfacility
def daemonise():
global syslogfacility
@@
-360,6
+366,7
@@
def daemonise():
facility=facilnum,
logoption=syslog.LOG_PID)
def emit(event):
facility=facilnum,
logoption=syslog.LOG_PID)
def emit(event):
+ if logevent_is_boringtwisted(event): return
m = twisted.logger.formatEvent(event)
#print(repr(event), m, file=org_stderr)
level = event.get('log_level')
m = twisted.logger.formatEvent(event)
#print(repr(event), m, file=org_stderr)
level = event.get('log_level')
@@
-369,6
+376,10
@@
def daemonise():
elif level == LogLevel.warn : sl = syslog.LOG_WARNING
else : sl = syslog.LOG_INFO
syslog.syslog(sl,m)
elif level == LogLevel.warn : sl = syslog.LOG_WARNING
else : sl = syslog.LOG_INFO
syslog.syslog(sl,m)
+ failure = event.get('log_failure')
+ if failure is not None:
+ for l in failure.getTraceback().split('\n'):
+ syslog.syslog(sl,l)
glp = twisted.logger.globalLogPublisher
glp.addObserver(emit)
log_debug(DBG.INIT, 'starting to log to syslog')
glp = twisted.logger.globalLogPublisher
glp.addObserver(emit)
log_debug(DBG.INIT, 'starting to log to syslog')
@@
-398,16
+409,15
@@
def daemonise():
if grandchildpid:
# we are the intermediate child
if opts.pidfile is not None:
if grandchildpid:
# we are the intermediate child
if opts.pidfile is not None:
- print(grandchildpid, file=p
f
h)
- p
f
h.close()
+ print(grandchildpid, file=p
idfile_
h)
+ p
idfile_
h.close()
os._exit(0)
os._exit(0)
- mypid = os.getpid()
-
pf
h.close()
+ if opts.pidfile is not None:
+
pidfile_
h.close()
logger = subprocess.Popen(['logger','-d',
logger = subprocess.Popen(['logger','-d',
- '-t','hippotat(stderr)',
- '--id=%d' % mypid,
+ '-t','hippotat[%d](stderr)' % os.getpid(),
'-p',opts.syslogfacility + '.err'],
stdin=subprocess.PIPE,
stdout=subprocess.DEVNULL,
'-p',opts.syslogfacility + '.err'],
stdin=subprocess.PIPE,
stdout=subprocess.DEVNULL,