spam.m4: The ${run ...} expansion doesn't do PATH lookup.

[exim-config] / spam.m4

diff --git a/spam.m4 b/spam.m4
index b219a28..7be5a36 100644 (file)
--- a/spam.m4
+++ b/spam.m4
@@ -25,6 +25,15 @@ DIVERT(null)
 ###--------------------------------------------------------------------------
 ### Spam filtering.
 
+## The Exim documentation tells lies.
+##
+## : *${run{*<_command_>* *<_args_>*}{*<_string1_>*}{*<_string2_>*}}*
+## :     The command and its arguments are first expanded separately, [...]
+##
+## They aren't.  The whole command-and-args are expanded together, and then
+## split at unquoted spaces.  This unpleasant hack sorts out the mess.
+m4_define(<:SHQUOTE:>, <:"${rxquote:$1}":>)
+
 SECTION(global, policy)m4_dnl
 spamd_address = CONF_spamd_address CONF_spamd_port
 
@@ -43,25 +52,29 @@ fetch_spam_limit:
        check_local_user
        address_data = \
                ${if def:address_data {$address_data}{}} \
-               ${if exists {CONF_userconf_dir/spam-limit} \
+               ${if and {{!eq{$acl_c_mode}{submission}} \
+                         {exists {CONF_userconf_dir/spam-limit}}} \
                     {${lookup {$local_part_prefix\
                                        $local_part\
                                        $local_part_suffix\
                                        @$domain/\
                                        $sender_address} \
                               nwildlsearch {CONF_userconf_dir/spam-limit} \
-                              {spam_limit=$value} \
+                              {${if match{$value}{\N^-?[0-9]+$\N} \
+                                    {spam_limit=$value} \
+                                    {}}} \
                               {}}} \
                     {}} \
-               ${if exists {CONF_userconf_dir/spam-limit.userv} \
-                    {${run {timeout 5s -- \
-                               userv $local_part exim-spam-limit \
-                                       $sender_address \
-                                       $local_part_prefix \
-                                       $local_part \
-                                       $local_part_suffix \
-                                       @$domain} \
-                           {${if match{$value}{\N^[0-9]+$\N} \
+               ${if and {{!eq{$acl_c_mode}{submission}} \
+                         {exists {CONF_userconf_dir/spam-limit.userv}}} \
+                    {${run {/usr/bin/timeout 5s -- \
+                               userv SHQUOTE($local_part) exim-spam-limit \
+                                       SHQUOTE($sender_address) \
+                                       SHQUOTE($local_part_prefix) \
+                                       SHQUOTE($local_part) \
+                                       SHQUOTE($local_part_suffix) \
+                                       SHQUOTE(@$domain)} \
+                           {${if match{$value}{\N^-?[0-9]+$\N} \
                                  {spam_limit=$value} \
                                  {}}} \
                            {}}} \
@@ -72,10 +85,26 @@ SECTION(acl, rcpt-hooks)m4_dnl
        require  acl = rcpt_spam
 
 SECTION(acl, misc)m4_dnl
-rcpt_spam:
+skip_spam_check:
 
-       ## If the client is trusted, don't bother with any of this.
+       ## If the client is trusted, or this is a new submission, don't
+       ## bother with any of this.  We will have verified the sender
+       ## fairly aggressively before granting this level of trust.
        accept   hosts = +trusted
+       accept   condition = ${if eq{$acl_c_mode}{submission}}
+
+       ## Otherwise we should check.
+       deny
+
+rcpt_spam:
+
+       ## See if we should do this check.
+       accept   acl = skip_spam_check
+
+       ## Always accept mail to `postmaster'.  Currently this is not
+       ## negotiable; maybe a tweak can be added to `domains.conf' if
+       ## necessary.
+       accept   local_parts = postmaster
 
        ## Collect the user's spam threshold from the `address_data'
        ## variable, where it was left by the `fetch_spam_limit' router
@@ -113,8 +142,8 @@ SECTION(acl, data-spam)m4_dnl
 SECTION(acl, misc)m4_dnl
 data_spam:
 
-       ## If the client is trusted, don't bother with any of this.
-       accept   hosts = +trusted
+       ## See if we should do this check.
+       accept   acl = skip_spam_check
 
        ## Check header validity.
        require  verify = header_syntax
@@ -159,7 +188,7 @@ data_spam:
                 ## their scores.  Leave `<<...>>' around everything else.
                 set acl_m_spam_tests = \
                        ${sg{$acl_m_spam_tests} \
-                           {\N(?s)\n\s*([\d.]+)\s+([-\w]+)\s\N} \
+                           {\N(?s)\n\s*(-?[\d.]+)\s+([-\w]+)\s\N} \
                            {>>\$2:\$1,<<}}
 
                 ## Strip everything still in `<<...>>' pairs, including any