}
}
+static void open_file_on_demand(const char *file, FILE **fp_inout,
+ const char *what)
+{
+ FILE *fp;
+
+ if (!*fp_inout) {
+ fp = fopen(file, "w");
+ if (!fp)
+ bail_syserr(errno, "failed to open %s file `%s'", what, file);
+ fprintf(fp, "## %s\n\n", what);
+ *fp_inout = fp;
+ }
+}
+
+static void check_write(FILE *fp, const char *what)
+{
+ fflush(fp);
+ if (ferror(fp)) bail_syserr(errno, "error writing %s file", what);
+}
+
+static void carefully_fclose(FILE *fp, const char *what)
+{
+ if (fp && (ferror(fp) || fclose(fp)))
+ bail_syserr(errno, "error writing %s file", what);
+}
+
#define DEFVEC(vtype, etype) \
typedef struct { etype *v; size_t n, sz; } vtype
#define VEC_INIT { 0, 0, 0 }
("copied %.1f%% (%"PRIuSEC" of %"PRIuSEC"; %.1f %sB/s, ETA %s)",
percent, pos, limit, rate, unit, etastr);
if (file && id_kind(file->id) == VOB) {
- append_progress(" -- %s %d %3.1f%%",
+ append_progress(" -- %s %d %.1f%%",
id_part(file->id) ? "title" : "menu",
id_title(file->id),
(pos - file->start)*100.0/
moan("skipping %"PRIuSEC" bad sectors (%"PRIuSEC" .. %"PRIuSEC")",
bad_hi - bad_lo, bad_lo, bad_hi);
if (mapfile) {
- if (!mapfp) {
- mapfp = fopen(mapfile, "w");
- if (!mapfp)
- bail_syserr(errno, "failed to open bad-sector map file `%s'",
- optarg);
- fprintf(mapfp, "## bad sector map\n\n");
- }
+ open_file_on_demand(mapfile, &mapfp, "bad-sector region map");
fprintf(mapfp, "%"PRIuSEC" %"PRIuSEC"\n", bad_lo, bad_hi);
- fflush(mapfp);
- if (ferror(mapfp))
- bail_syserr(errno, "error writing bad-sector map file");
+ check_write(mapfp, "bad-sector region map");
}
if (lseek(outfd, (off_t)(bad_hi - bad_lo)*SECTORSZ, SEEK_CUR) < 0)
bail_syserr(errno, "failed to seek past bad sectors");
r->pos + pp, pp, nn);
fflush(stdout);
#endif
- n = recovery_read_sectors(r, pos + pp, pp, nn);
+ n = recovery_read_sectors(r, r->pos + pp, pp, nn);
#ifdef DEBUG
printf(" -> %zd\n", n);
#endif
if (dvd) DVDClose(dvd);
if (dvdfd >= 0) close(dvdfd);
if (outfd >= 0) close(outfd);
- if (mapfp) {
- if (ferror(mapfp) || fclose(mapfp))
- bail_syserr(errno, "error writing bad-sector map file");
- }
+ carefully_fclose(mapfp, "bad-sector region map");
#undef f_bogus
#undef f_continue