more TODOs

[disorder] / disobedience / users.c

diff --git a/disobedience/users.c b/disobedience/users.c
index 589716e..af42858 100644 (file)
--- a/disobedience/users.c
+++ b/disobedience/users.c
@@ -33,9 +33,10 @@
  * When you select 'add' a new empty set of details are displayed to be edited.
  * Again Apply will commit them.
  *
- * TODO: it would be really nice if the Username entry could be removed and new
- * user names entered in the list, rather off in the details panel.  This may
- * be possible with a sufficiently clever GtkCellRenderer.
+ * TODO:
+ * - enter new username in the GtkTreeView
+ * - escape and enter keys should work
+ * - should have a cancel or close button, consistent with properties and login
  */
 
 #include "disobedience.h"
@@ -109,10 +110,16 @@ static int users_find_user(const char *user,
  *
  * If users_deferred_select is set then that user is selected.
  */
-static void users_got_list(void attribute((unused)) *v, int nvec, char **vec) {
+static void users_got_list(void attribute((unused)) *v,
+                           const char *error,
+                           int nvec, char **vec) {
   int n;
   GtkTreeIter iter;
 
+  if(error) {
+    popup_protocol_error(0, error);
+    return;
+  }
   /* Present users in alphabetical order */
   qsort(vec, nvec, sizeof (char *), usercmp);
   /* Set the list contents */