From: Rupert Swarbrick <rswarbrick@gmail.com>
Date: Wed, 29 Feb 2012 17:48:37 +0000 (+0000)
Subject: Allow string setters for virtual slots.
X-Git-Url: https://git.distorted.org.uk/~mdw/clg/commitdiff_plain/b9f34364da134a8e58be17c4937543afb1da5d09

Allow string setters for virtual slots.

This extends the nasty vsc-slot-x-using-class macro to deal with setf
stuff too, so I only have to write the string check code once.
---

diff --git a/gffi/virtual-slots.lisp b/gffi/virtual-slots.lisp
index ef2208c..796521b 100644
--- a/gffi/virtual-slots.lisp
+++ b/gffi/virtual-slots.lisp
@@ -283,32 +283,31 @@
      (append '(:special t) (call-next-method)))
     (t (call-next-method))))
 
-(defmacro vsc-slot-x-using-class (x x-slot-name computer &key allow-string-fun-p)
+(defmacro vsc-slot-x-using-class (x x-slot-name computer
+                                  &key allow-string-fun-p setf-p)
   (let ((generic-name (intern (concatenate 'string
                                            "SLOT-" (string x) "-USING-CLASS"))))
-    `(defmethod ,generic-name
-         ((class virtual-slots-class) (object virtual-slots-object)
+    `(defmethod ,(if setf-p `(setf ,generic-name) generic-name)
+         (,@(when setf-p '(value))
+          (class virtual-slots-class) (object virtual-slots-object)
           (slotd effective-virtual-slot-definition))
        (unless (and (slot-boundp slotd ',x-slot-name)
                     ,@(when allow-string-fun-p
-                         `((not
-                            (stringp (slot-value slotd ',x-slot-name))))))
+                         `((not (stringp (slot-value slotd ',x-slot-name))))))
          (setf (slot-value slotd ',x-slot-name) (,computer slotd)))
-       (funcall (slot-value slotd ',x-slot-name) object))))
+       (funcall (slot-value slotd ',x-slot-name)
+                ,@(when setf-p '(value))
+                object))))
 
 (vsc-slot-x-using-class value getter compute-slot-reader-function
                         :allow-string-fun-p t)
+(vsc-slot-x-using-class value setter compute-slot-writer-function
+                        :allow-string-fun-p t :setf-p t)
+
 (vsc-slot-x-using-class boundp boundp-function compute-slot-boundp-function)
 (vsc-slot-x-using-class makunbound makunbound-function
                         compute-slot-makunbound-function)
 
-(defmethod (setf slot-value-using-class) (value (class virtual-slots-class)
-                                          (object virtual-slots-object)
-                                          (slotd effective-virtual-slot-definition))
-  (unless (slot-boundp slotd 'setter)
-    (setf (slot-value slotd 'setter) (compute-slot-writer-function slotd)))
-  (funcall (slot-value slotd 'setter) value object))
-
 ;; In CLISP and SBCL (0.9.15 or newler) a class may not have been
 ;; finalized when update-slots are called. So to avoid the possibility
 ;; of finalize-instance being called recursivly we have to delay the