X-Git-Url: https://git.distorted.org.uk/~mdw/checkpath/blobdiff_plain/efa7a97bf01444f8bfdf25f488932912d3710974..b4809431cd3c454bb205d2ed9b02df95c633707a:/tmpdir.c diff --git a/tmpdir.c b/tmpdir.c index 453ebf3..f0fcb5f 100644 --- a/tmpdir.c +++ b/tmpdir.c @@ -1,13 +1,11 @@ /* -*-c-*- * - * $Id: tmpdir.c,v 1.1 1999/04/06 20:12:07 mdw Exp $ - * * Choose and check temporary directories * * (c) 1999 Mark Wooding */ -/*----- Licensing notice --------------------------------------------------* +/*----- Licensing notice --------------------------------------------------* * * This file is part of chkpath. * @@ -15,28 +13,23 @@ * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. - * + * * chkpath is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * + * * You should have received a copy of the GNU General Public License * along with chkpath; if not, write to the Free Software Foundation, * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/*----- Revision history --------------------------------------------------* - * - * $Log: tmpdir.c,v $ - * Revision 1.1 1999/04/06 20:12:07 mdw - * Initial revision - * - */ - /*----- Header files ------------------------------------------------------*/ +#include "config.h" + #include +#include #include #include #include @@ -45,19 +38,21 @@ #include #include #include +#include #include #include +#include #include #include #include -#include "path.h" +#include "checkpath.h" /*----- Static variables --------------------------------------------------*/ static uid_t me; -static struct chkpath cp; +static struct checkpath cp; static struct passwd *pw; /*----- Main code ---------------------------------------------------------*/ @@ -128,7 +123,7 @@ static char *trytmp(const char *parent, const char *base) "ABCDEFGHIJKLMNOPQRSTUVWXYZ" }; char *p, *q; char *qq; - dstr d; + dstr d = DSTR_INIT; int createflag = 1; /* --- Make sure the parent directory is sane --- * @@ -139,12 +134,11 @@ static char *trytmp(const char *parent, const char *base) * safe. */ - if (path_check(parent, &cp)) + if (checkpath(parent, &cp)) return (0); /* --- See whether the trivial version will work --- */ - dstr_create(&d); dstr_putf(&d, "%s/%s", parent, base); if (ok(d.buf, &createflag)) goto good; @@ -189,9 +183,7 @@ good: */ static int fullcheck(const char *p) -{ - return (path_check(p, &cp) == 0 && ok(p, 0)); -} + { return (checkpath(p, &cp) == 0 && ok(p, 0)); } /* --- @goodtmp@ --- * * @@ -214,16 +206,12 @@ static char *goodtmp(void) /* --- Try making a directory in `/tmp' --- */ - if (!(q = getenv("USER")) && !(q = getenv("LOGNAME"))) - q = pw->pw_name; - if ((q = trytmp("/tmp", q)) != 0) + if ((q = trytmp("/tmp", pw->pw_name)) != 0) return (q); /* --- That failed: try a directory in the user's home --- */ - if (!(q = getenv("HOME"))) - q = pw->pw_dir; - if ((q = trytmp(q, "tmp")) != 0) + if ((q = trytmp(pw->pw_dir, "tmp")) != 0) return (q); /* --- Still no joy: give up --- * @@ -235,19 +223,22 @@ static char *goodtmp(void) return (0); } +/* --- @report@ --- */ + +static void report(unsigned what, int verbose, + const char *p, const char *msg, + void *arg) + { moan("%s", msg); } + /* --- @usage@ --- */ static void usage(FILE *fp) -{ - fprintf(fp, "Usage: %s [-bc] [-v PATH]\n", QUIS); -} + { fprintf(fp, "Usage: %s [-bc] [-v PATH]\n", QUIS); } /* --- @version@ --- */ static void version(FILE *fp) -{ - fprintf(fp, "%s version %s\n", QUIS, VERSION); -} + { fprintf(fp, "%s version %s\n", QUIS, VERSION); } /* --- @help@ --- */ @@ -271,7 +262,9 @@ Options supported:\n\ \n\ -b, --bourne Output a `TMPDIR' setting for Bourne shell users.\n\ -c, --cshell Output a `TMPDIR' setting for C shell users.\n\ --v, --verify PATH Check whether PATH is good, setting exit status.\n\ +-v, --verbose Report problems to standard error.\n\ +-g, --group NAME Trust group NAME to be honest and true.\n\ +-C, --check PATH Check whether PATH is good, setting exit status.\n\ \n\ The default action is to examine the caller's shell and output a suitable\n\ setting for that shell type.\n\ @@ -279,6 +272,46 @@ setting for that shell type.\n\ fp); } +/* --- @allowgroup@ --- * + * + * Arguments: @const char *gname@ = trust group @gname@ + * + * Returns: --- + * + * Use: Adds the gid corresponding to @gname@ (which may be a number) + * to the list of things we trust. + */ + +static void allowgroup(const char *gname) +{ + struct group *gr; + const char *p; + gid_t g; + + /* --- Check for numeric group spec --- */ + + for (p = gname; *p; p++) { + if (!isdigit((unsigned char)*p)) + goto lookup; + } + g = atoi(gname); + goto insert; + + /* --- Look up a group by name --- */ + +lookup: + if ((gr = getgrnam(gname)) == 0) + die(1, "group %s not found", gname); + g = gr->gr_gid; + + /* --- Insert the group into the table --- */ + +insert: + if (cp.cp_gids >= N(cp.cp_gid)) + die(1, "too many groups"); + cp.cp_gid[cp.cp_gids++] = g; +} + /* --- @main@ --- * * * Arguments: @int argc@ = number of command line arguments @@ -293,6 +326,7 @@ int main(int argc, char *argv[]) { int shell = 0; int duff = 0; + char *p; enum { sh_unknown, @@ -303,11 +337,13 @@ int main(int argc, char *argv[]) /* --- Initialize variables --- */ ego(argv[0]); - me = getuid(); - cp.cp_what = CP_WRWORLD | CP_WRGRP | CP_WROTHUSR | CP_STICKYOK; + me = geteuid(); + cp.cp_what = (CP_WRWORLD | CP_WROTHGRP | CP_WROTHUSR | + CP_STICKYOK | CP_REPORT); cp.cp_verbose = 0; - cp.cp_report = 0; - path_setids(&cp); + cp.cp_report = report; + checkpath_setids(&cp); + cp.cp_gids = 0; /* ignore group membership */ pw = getpwuid(me); if (!pw) die(1, "you don't exist"); @@ -321,10 +357,14 @@ int main(int argc, char *argv[]) { "usage", 0, 0, 'u' }, { "bourne", 0, 0, 'b' }, { "cshell", 0, 0, 'c' }, - { "verify", gFlag_argReq, 0, 'v' }, + { "check", OPTF_ARGREQ, 0, 'C' }, + { "verify", OPTF_ARGREQ, 0, 'C' }, + { "verbose", 0, 0, 'v' }, + { "trust-groups", 0, 0, 't' }, + { "group", OPTF_ARGREQ, 0, 'g' }, { 0, 0, 0, 0 } }; - int i = mdwopt(argc, argv, "hVu bcv:", opts, 0, 0, 0); + int i = mdwopt(argc, argv, "hVu" "bcvtg:c:", opts, 0, 0, 0); if (i < 0) break; @@ -344,9 +384,15 @@ int main(int argc, char *argv[]) case 'c': shell = sh_csh; break; - case 'v': + case 'C': return (!fullcheck(optarg)); break; + case 'g': + allowgroup(optarg); + break; + case 'v': + cp.cp_verbose++; + break; default: duff = 1; break; @@ -361,7 +407,6 @@ int main(int argc, char *argv[]) /* --- Choose a shell --- */ if (!shell) { - char *p; if (!(p = getenv("SHELL"))) p = pw->pw_shell; if (strstr(p, "csh")) @@ -372,19 +417,16 @@ int main(int argc, char *argv[]) /* --- Start the checking --- */ - { - char *p = goodtmp(); - if (!p) - die(1, "no good tmp directory"); - switch (shell) { - case sh_bourne: - printf("TMPDIR=\"%s\"; export TMPDIR\n", p); - break; - case sh_csh: - printf("setenv TMPDIR \"%s\"\n", p); + if ((p = goodtmp()) == 0) + die(1, "no good tmp directory"); + switch (shell) { + case sh_bourne: + printf("TMPDIR=\"%s\"; export TMPDIR\n", p); + break; + case sh_csh: + printf("setenv TMPDIR \"%s\"\n", p); break; - } - } + } return (0); }