From 92edc356a312bc64abca0c30bc03d4b6676f3d39 Mon Sep 17 00:00:00 2001 From: Mark Wooding Date: Thu, 7 Nov 2019 01:43:46 +0000 Subject: [PATCH 1/1] math/mpx-mul4-*-sse2.S: Remove an unhelpful comment. It's not actually wrong, but it's misleading because we don't actually care that the flags are preserved at this point, because the next instruction clobbers them anyway. I think this was cut-and-paste lossage from the earlier code which relies on `mov' preserving the carry flag. --- math/mpx-mul4-amd64-sse2.S | 2 +- math/mpx-mul4-x86-sse2.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/math/mpx-mul4-amd64-sse2.S b/math/mpx-mul4-amd64-sse2.S index 0f2dbd32..a37aba69 100644 --- a/math/mpx-mul4-amd64-sse2.S +++ b/math/mpx-mul4-amd64-sse2.S @@ -1262,7 +1262,7 @@ FUNC(mpxmont_redc4_amd64_sse2) // Deal with the tail end. 7: add [rdi], C - mov C, 0 // preserves flags + mov C, 0 add rdi, 4 adc C, 0 cmp rdi, DVL diff --git a/math/mpx-mul4-x86-sse2.S b/math/mpx-mul4-x86-sse2.S index b1072ff2..9e1d4782 100644 --- a/math/mpx-mul4-x86-sse2.S +++ b/math/mpx-mul4-x86-sse2.S @@ -1064,7 +1064,7 @@ FUNC(mpxmont_redc4_x86_sse2) // Deal with the tail end. 7: add [edi], eax - mov eax, 0 // preserves flags + mov eax, 0 add edi, 4 adc eax, 0 cmp edi, edx -- 2.11.0