From: Mark Wooding <mdw@distorted.org.uk>
Date: Tue, 8 Aug 2017 22:41:44 +0000 (+0100)
Subject: rand/noise.c, progs/pixie.c: Don't ignore return codes from setuid(2) etc.
X-Git-Tag: 2.4.2~29
X-Git-Url: https://git.distorted.org.uk/~mdw/catacomb/commitdiff_plain/ffb29736d0a30a22cc3214779a953ac38079c4d8?hp=68ea1def22170f19da0ac7e590560a003704ae7e

rand/noise.c, progs/pixie.c: Don't ignore return codes from setuid(2) etc.

Legitimate warnings, I think, but not worth doing anything complicated
about.
---

diff --git a/progs/pixie.c b/progs/pixie.c
index 43807037..7694d74d 100644
--- a/progs/pixie.c
+++ b/progs/pixie.c
@@ -1244,7 +1244,7 @@ int main(int argc, char *argv[])
   /* --- Set up the locked memory area --- */
 
   l_init(&lm, 16384);
-  setuid(getuid());
+  if (setuid(getuid())) _exit(125);
 
   /* --- Parse command line arguments --- */
 
diff --git a/rand/noise.c b/rand/noise.c
index de120d8b..280c49cb 100644
--- a/rand/noise.c
+++ b/rand/noise.c
@@ -388,16 +388,15 @@ int noise_filter(rand_pool *r, int good, const char *c)
     /* --- Play games with uids --- */
 
     if (noise_gid != NOISE_NOSETGID) {
-      setgid(noise_gid);
-      setegid(noise_gid);
+      if (setgid(noise_gid) || setegid(noise_gid)
 #ifdef HAVE_SETGROUPS
-      setgroups(1, &noise_gid);
+	  || setgroups(1, &noise_gid)
 #endif
+	) _exit(127);
     }
 
     if (noise_uid != NOISE_NOSETUID) {
-      setuid(noise_uid);
-      seteuid(noise_uid);
+      if (setuid(noise_uid) || seteuid(noise_uid)) _exit(127);
     }
 
     /* --- Start the process up --- */