From: Mark Wooding <mdw@distorted.org.uk>
Date: Tue, 8 Oct 2019 10:45:56 +0000 (+0100)
Subject: Merge branch '2.4.x' into 2.5.x
X-Git-Tag: 2.5.2~9
X-Git-Url: https://git.distorted.org.uk/~mdw/catacomb/commitdiff_plain/e2f967aeff8b2c0b42d0b0a209f47543d61e48b1?hp=2eed595914ae2ec6f26832d9c55c226220a8c6b5

Merge branch '2.4.x' into 2.5.x

* 2.4.x:
  key/key-io.c: Mark `exptime' function `static'.
  key/key-io.c (key_new): Don't leak attribute `sym_table' on error.
---

diff --git a/debian/catacomb2.symbols b/debian/catacomb2.symbols
index 02e84ed2..36f4a565 100644
--- a/debian/catacomb2.symbols
+++ b/debian/catacomb2.symbols
@@ -4406,7 +4406,6 @@ libcatacomb.so.2 catacomb2 #MINVER#
 ## key-io
 	key_new@Base 2.1.1
 	key_open@Base 2.3.1
-	exptime@Base 2.1.1
 	key_close@Base 2.1.1
 	key_discard@Base 2.1.1
 	key_extract@Base 2.3.1
diff --git a/key/key-io.c b/key/key-io.c
index c79c8e06..5a7ce5c3 100644
--- a/key/key-io.c
+++ b/key/key-io.c
@@ -139,7 +139,7 @@ static int insert(key_file *f, key *k)
  * Use:		Translates an expiry or deletion time.
  */
 
-time_t exptime(const char *p)
+static time_t exptime(const char *p)
 {
   size_t sz = strlen(p);
   if (strncmp(p, "expired", sz) == 0)
@@ -552,12 +552,12 @@ int key_new(key_file *f, uint32 id, const char *type, time_t exp, key **kk)
     k->exp = k->del = exp;
     k->c = 0;
     k->type = (char *)type; /* temporarily */
-    sym_create(&k->a);
     if ((e = insert(f, k)) != 0)
       DESTROY(k);
     else {
       k->k = key_newstring(KCAT_SHARE, "<unset>");
       k->type = xstrdup(type);
+      sym_create(&k->a);
       *kk = k;
       f->f |= KF_MODIFIED;
     }