From: Mark Wooding <mdw@distorted.org.uk>
Date: Tue, 8 Oct 2019 10:36:34 +0000 (+0100)
Subject: key/key-io.c (key_new): Don't leak attribute `sym_table' on error.
X-Git-Tag: 2.4.5~24
X-Git-Url: https://git.distorted.org.uk/~mdw/catacomb/commitdiff_plain/2b74e2802da8d7feeb5f9923a8cee1e7425e9d4d

key/key-io.c (key_new): Don't leak attribute `sym_table' on error.

This is safe: `insert' doesn't do anything with `k->a'.
---

diff --git a/key/key-io.c b/key/key-io.c
index c79c8e06..15bebdc1 100644
--- a/key/key-io.c
+++ b/key/key-io.c
@@ -552,12 +552,12 @@ int key_new(key_file *f, uint32 id, const char *type, time_t exp, key **kk)
     k->exp = k->del = exp;
     k->c = 0;
     k->type = (char *)type; /* temporarily */
-    sym_create(&k->a);
     if ((e = insert(f, k)) != 0)
       DESTROY(k);
     else {
       k->k = key_newstring(KCAT_SHARE, "<unset>");
       k->type = xstrdup(type);
+      sym_create(&k->a);
       *kk = k;
       f->f |= KF_MODIFIED;
     }