progs/catsign.c; Verify equality of keys more directly.
authorMark Wooding <mdw@distorted.org.uk>
Sun, 3 Jun 2018 09:30:49 +0000 (10:30 +0100)
committerMark Wooding <mdw@distorted.org.uk>
Sun, 3 Jun 2018 09:30:49 +0000 (10:30 +0100)
commitd31eb5ca590699699b99dcb434c4f058bea4c90a
tree5f92b4b30cf2ac6f04b75c5b71420214b8be66f3
parente08c000f323a60ab87e9d54f165f4545e847e541
progs/catsign.c; Verify equality of keys more directly.

Rather than comparing the two keys' `id' slots, just compare the
pointers.  It's not like we got them from different keyrings or
anything.  This makes it clear that we're checking that we really have
the /same/ key, found by two different paths.

Fortunately, this isn't a security problem: the code in `key/key-io.c'
won't allow two keys with the same `id' value to exist in the same
keyring.  This change therefore doesn't have any observable effect.
But, seeing as I just had a panic regarding a potential security hole in
`tripe-keys', it's as well to make it clear what's actually going on.
progs/catsign.c