X-Git-Url: https://git.distorted.org.uk/~mdw/catacomb-python/blobdiff_plain/6311e4f71d2aac179fa3841d47302cdb642e487d..f5a133608a72a96b2023024043dc00480192bcc7:/mp.c

diff --git a/mp.c b/mp.c
index 96e3e86..59fce83 100644
--- a/mp.c
+++ b/mp.c
@@ -289,24 +289,27 @@ int convgf(PyObject *o, void *p)
 
 mp *implicitmp(PyObject *o)
 {
-  if (!o ||
-      GF_PYCHECK(o) ||
-      ECPT_PYCHECK(o) ||
-      FE_PYCHECK(o) ||
-      GE_PYCHECK(o))
-    return (0);
-  return (tomp(o));
+  PyObject *l;
+
+  if (!o || GF_PYCHECK(o) || FE_PYCHECK(o)) return (0);
+  else if (MP_PYCHECK(o)) return (MP_COPY(MP_X(o)));
+  else if (PFILT_PYCHECK(o)) return (MP_COPY(PFILT_F(o)->m));
+#ifdef PY2
+  else if (PyInt_Check(o)) return (mp_fromlong(MP_NEW, PyInt_AS_LONG(o)));
+#endif
+  else if ((l = PyNumber_Index(o)) != 0) {
+#ifdef PY2
+    if (PyInt_Check(o)) return (mp_fromlong(MP_NEW, PyInt_AS_LONG(o)));
+#endif
+    if (PyLong_Check(o)) return (mp_frompylong(o));
+  }
+  PyErr_Clear(); return (0);
 }
 
 mp *implicitgf(PyObject *o)
 {
-  if (!o ||
-      MP_PYCHECK(o) ||
-      ECPT_PYCHECK(o) ||
-      FE_PYCHECK(o) ||
-      GE_PYCHECK(o))
-    return (0);
-  return (tomp(o));
+  if (GF_PYCHECK(o)) return (MP_COPY(MP_X(o)));
+  return (0);
 }
 
 static int mpbinop(PyObject *x, PyObject *y, mp **xx, mp **yy)
@@ -393,25 +396,24 @@ UNOP(mp, not2c)
 static PyObject *mp_pyid(PyObject *x) { RETURN_OBJ(x); }
 
 #define gf_lsr mp_lsr
-#define SHIFTOP(pre, name, rname)					\
+#define SHIFTOP(pre, PRE, name, rname)					\
   static PyObject *pre##_py##name(PyObject *x, PyObject *y) {		\
-    mp *xx, *yy;							\
+    PyObject *yix = 0;							\
     PyObject *z = 0;							\
     long n;								\
-    if (pre##binop(x, y, &xx, &yy)) RETURN_NOTIMPL;			\
-    if (mp_tolong_checked(yy, &n, 1)) goto end;				\
-    if (n < 0)								\
-      z = pre##_pywrap(mp_##rname(MP_NEW, xx, -n));			\
-    else								\
-      z = pre##_pywrap(mp_##name(MP_NEW, xx, n));			\
-  end:									\
-    MP_DROP(xx); MP_DROP(yy);						\
+    if (!PRE##_PYCHECK(x)) RETURN_NOTIMPL;				\
+    if (GF_PYCHECK(y) || FE_PYCHECK(y)) RETURN_NOTIMPL;			\
+    yix = PyNumber_Index(y); if (!yix) { PyErr_Clear(); RETURN_NOTIMPL; } \
+    n = PyInt_AsLong(yix); Py_DECREF(yix);				\
+    if (n == -1 && PyErr_Occurred())  { PyErr_Clear(); RETURN_NOTIMPL; } \
+    if (n < 0) z = pre##_pywrap(mp_##rname(MP_NEW, MP_X(x), -n));	\
+    else z = pre##_pywrap(mp_##name(MP_NEW, MP_X(x), n));		\
     return (z);								\
   }
-SHIFTOP(mp, lsl2c, lsr2c)
-SHIFTOP(mp, lsr2c, lsl2c)
-SHIFTOP(gf, lsl, lsr)
-SHIFTOP(gf, lsr, lsl)
+SHIFTOP(mp, MP, lsl2c, lsr2c)
+SHIFTOP(mp, MP, lsr2c, lsl2c)
+SHIFTOP(gf, GF, lsl, lsr)
+SHIFTOP(gf, GF, lsr, lsl)
 #undef SHIFTOP
 
 #define DIVOP(pre, name, qq, rr, gather)				\
@@ -547,7 +549,7 @@ static PyObject *mp_pyfloat(PyObject *x)
       Py_INCREF(*x); Py_INCREF(*y);					\
       return (0);							\
     }									\
-    if ((z = tomp(*y)) != 0) {						\
+    if ((z = implicit##pre(*y)) != 0) {					\
       Py_INCREF(*x);							\
       *y = pre##_pywrap(z);						\
       return (0);							\
@@ -601,6 +603,22 @@ end:
   return ((PyObject *)zz);
 }
 
+#define IMPLICIT(pre)							\
+  static PyObject *pre##meth__implicit(PyObject *me, PyObject *arg)	\
+  {									\
+    PyObject *x, *rc = 0;						\
+    mp *y = MP_NEW;							\
+    if (!PyArg_ParseTuple(arg, "O:_implicit", &x)) goto end;		\
+    y = implicit##pre(x);						\
+    if (!y) TYERR("can't convert implicitly to " #pre);			\
+    rc = pre##_pywrap(y);						\
+  end:									\
+    return (rc);							\
+  }
+IMPLICIT(mp)
+IMPLICIT(gf)
+#undef IMPLICIT
+
 Py_hash_t mphash(mp *x)
 {
   PyObject *l = mp_topylong(x);
@@ -929,6 +947,7 @@ static const PyMethodDef mp_pymethods[] = {
     "  Parse STR as a large integer, according to RADIX.  If RADIX is\n"
     "  zero, read a prefix from STR to decide radix: allow `0b' for binary,\n"
     "  `0' or `0o' for octal, `0x' for hex, or `R_' for other radix R.")
+  SMTH	(_implicit,	0)
   SMTH	(factorial,	"factorial(I) -> I!: compute factorial")
   SMTH	(fibonacci,	"fibonacci(I) -> F(I): compute Fibonacci number")
   SMTH	(loadl,		"loadl(STR) -> X: read little-endian bytes")
@@ -1764,12 +1783,10 @@ static PyObject *mcmeth_solve(PyObject *me, PyObject *arg)
   mp **v = 0;
   Py_ssize_t i = 0, n = c->k;
 
-  Py_INCREF(me);
   if (PyTuple_GET_SIZE(arg) == n)
     q = arg;
   else if (!PyArg_ParseTuple(arg, "O:solve", &q))
     goto end;
-  Py_INCREF(q);
   if (!PySequence_Check(q)) TYERR("want a sequence of residues");
   i = PySequence_Size(q); if (i < 0) goto end;
   if (i != n) VALERR("residue count mismatch");
@@ -1787,8 +1804,6 @@ end:
       MP_DROP(v[i]);
     xfree(v);
   }
-  Py_DECREF(me);
-  Py_XDECREF(q);
   return (z);
 }
 
@@ -1813,7 +1828,6 @@ static PyObject *mpcrt_pynew(PyTypeObject *ty, PyObject *arg, PyObject *kw)
     q = arg;
   else if (!PyArg_ParseTupleAndKeywords(arg, kw, "O:new", KWLIST, &q))
     goto end;
-  Py_INCREF(q);
   if (!PySequence_Check(q)) TYERR("want a sequence of moduli");
   n = PySequence_Size(q); if (n < 0) goto end;
   if (!n) VALERR("want at least one modulus");
@@ -1835,7 +1849,6 @@ static PyObject *mpcrt_pynew(PyTypeObject *ty, PyObject *arg, PyObject *kw)
 
   c = (mpcrt_pyobj *)ty->tp_alloc(ty, 0);
   mpcrt_create(&c->c, v, n, 0);
-  Py_DECREF(q);
   mp_drop(xx); mp_drop(y); mp_drop(g);
   return ((PyObject *)c);
 
@@ -1846,7 +1859,6 @@ end:
       MP_DROP(v[i].m);
     xfree(v);
   }
-  Py_XDECREF(q);
   mp_drop(xx); mp_drop(y); mp_drop(g);
   return (0);
 }
@@ -2121,6 +2133,7 @@ static const PyMethodDef gf_pymethods[] = {
     "  Parse STR as a binary polynomial, according to RADIX.  If RADIX is\n"
     "  zero, read a prefix from STR to decide radix: allow `0b' for binary,\n"
     "  `0' or `0o' for octal, `0x' for hex, or `R_' for other radix R.")
+  SMTH	(_implicit,	0)
   SMTH	(loadl,		"loadl(STR) -> X: read little-endian bytes")
   SMTH	(loadb,		"loadb(STR) -> X: read big-endian bytes")
   SMTH	(frombuf,	"frombuf(STR) -> (X, REST): read buffer format")