X-Git-Url: https://git.distorted.org.uk/~mdw/adns/blobdiff_plain/e1d31292a9c52afb49d6dcbb5dc140289774f8c7..6480e2dfab3ff911cac1d1e922666fcea65e511e:/src/types.c

diff --git a/src/types.c b/src/types.c
index c0183c9..18cf159 100644
--- a/src/types.c
+++ b/src/types.c
@@ -66,13 +66,13 @@
  * _mailbox                   (pap +pap_mailbox822)
  * _rp                        (pa)
  * _soa                       (pa,mf,cs)
- * _srv*                      (qdpl,(pap),pa,mf,di,(csp),cs,postsort)
+ * _srv*                      (ckl,(pap),pa,mf,di,(csp),cs,postsort)
  * _byteblock                 (mf)
  * _opaque                    (pa,cs)
  * _flat                      (mf)
  *
  * within each section:
- *    qdpl_*
+ *    ckl_*
  *    pap_*
  *    pa_*
  *    dip_*
@@ -275,10 +275,9 @@ static int search_sortlist(adns_state ads, int af, const void *ad) {
 
   for (i=0, slp=ads->sortlist;
        i<ads->nsortlist &&
-       !(af == slp->ai->af &&
-	 slp->ai->matchp(ad, &slp->base, &slp->mask)) &&
-       !(v6mappedp && slp->ai->af == AF_INET &&
-	 slp->ai->matchp(&a, &slp->base, &slp->mask));
+	 !adns__addr_match_p(af,ad, slp->af,&slp->base,&slp->mask) &&
+	 !(v6mappedp &&
+	   adns__addr_match_p(AF_INET,&a, slp->af,&slp->base,&slp->mask));
        i++, slp++);
   return i;
 }
@@ -339,6 +338,37 @@ static adns_status cs_in6addr(vbuf *vb, const void *datap) {
  *		addr_rrtypes)
  */
 
+static const typeinfo tinfo_addrsub;
+
+#define ADDR_RRTYPES(_) _(a) _(aaaa)
+
+static const adns_rrtype addr_all_rrtypes[] = {
+#define RRTY_CODE(ty) adns_r_##ty,
+  ADDR_RRTYPES(RRTY_CODE)
+#undef RRTY_CODE
+};
+
+enum {
+#define RRTY_INDEX(ty) addr__ri_##ty,
+  ADDR_RRTYPES(RRTY_INDEX)
+#undef RRTY_INDEX
+  addr_nrrtypes,
+#define RRTY_FLAG(ty) addr_rf_##ty = 1 << addr__ri_##ty,
+  ADDR_RRTYPES(RRTY_FLAG)
+  addr__rrty_hunoz
+#undef RRTY_FLAG
+};
+
+static unsigned addr_rrtypeflag(adns_rrtype type)
+{
+  int i;
+
+  type &= adns_rrt_typemask;
+  for (i = 0; i < addr_nrrtypes && type != addr_all_rrtypes[i]; i++);
+  assert(i < addr_nrrtypes);
+  return 1 << i;
+}
+
 /* About CNAME handling in addr queries.
  *
  * A user-level addr query is translated into a number of protocol-level
@@ -418,15 +448,7 @@ static adns_status pa_addr(const parseinfo *pai, int cbyte,
 
 static int search_sortlist_sa(adns_state ads, const struct sockaddr *sa)
 {
-  const afinfo *ai = 0;
-
-  switch (sa->sa_family) {
-    case AF_INET: ai = &adns__inet_afinfo; break;
-    case AF_INET6: ai = &adns__inet6_afinfo; break;
-  }
-  assert(ai);
-
-  return search_sortlist(ads, sa->sa_family, ai->sockaddr_to_inaddr(sa));
+  return search_sortlist(ads, sa->sa_family, adns__sockaddr_to_inaddr(sa));
 }
 
 static int dip_sockaddr(adns_state ads,
@@ -479,13 +501,11 @@ static adns_status cs_addr(vbuf *vb, const void *datap) {
   return csp_addr(vb,rrp);
 }
 
-static void addr_rrtypes(adns_state ads, adns_rrtype type,
-			 adns_queryflags qf,
-			 adns_rrtype *rrty, size_t *nrrty)
+static unsigned addr_rrtypes(adns_state ads, adns_rrtype type,
+			     adns_queryflags qf)
 {
-  size_t n = 0;
-  adns_rrtype qtf = type & adns__qtf_deref;
   adns_queryflags permitaf = 0, hackaf = 0;
+  unsigned want = 0;
 
   if (!(qf & (adns_qf_ipv4_only | adns_qf_ipv6_only)))
     qf |= adns_qf_ipv4_only | adns_qf_ipv6_only;
@@ -502,10 +522,10 @@ static void addr_rrtypes(adns_state ads, adns_rrtype type,
       qf &= hackaf | permitaf | ~adns__qf_afmask;
   }
 
-  if (qf & adns_qf_ipv4_only) rrty[n++] = adns_r_a | qtf;
-  if (qf & adns_qf_ipv6_only) rrty[n++] = adns_r_aaaa | qtf;
+  if (qf & adns_qf_ipv4_only) want |= addr_rf_a;
+  if (qf & adns_qf_ipv6_only) want |= addr_rf_aaaa;
 
-  *nrrty = n;
+  return want;
 }
 
 static int gsz_addr(adns_rrtype type)
@@ -521,7 +541,7 @@ static adns_status append_addrs(adns_query qu, adns_query from, size_t rrsz,
   size_t drrsz = *dlen*rrsz, srrsz = slen*rrsz;
   byte *p;
 
-  /* if (!slen) return adns_s_ok; */
+  if (!slen) return adns_s_ok;
   p = adns__alloc_interim(qu, drrsz + srrsz);
   if (!p) R_NOMEM;
   if (*dlen) {
@@ -538,27 +558,25 @@ static adns_status append_addrs(adns_query qu, adns_query from, size_t rrsz,
 static void icb_addr(adns_query parent, adns_query child);
 
 static void addr_subqueries(adns_query qu, struct timeval now,
+			    adns_queryflags qf_extra,
 			    const byte *qd_dgram, int qd_dglen)
 {
   int i, err, id;
   adns_query cqu;
-  adns_queryflags qf =
-    (qu->flags | adns__qf_senddirect) &
-    ~(adns_qf_search);
+  adns_queryflags qf = (qu->flags & ~adns_qf_search) | qf_extra;
+  adns_rrtype qtf = qu->answer->type & adns__qtf_deref;
+  unsigned which = qu->ctx.tinfo.addr.want & ~qu->ctx.tinfo.addr.have;
   qcontext ctx;
 
-  /* This always makes child queries, even if there's only the one.  This
-   * seems wasteful, but there's only one case where it'd be safe -- namely
-   * IPv4-only -- and that's not the case I want to optimize.
-   */
   memset(&ctx, 0, sizeof(ctx));
   ctx.callback = icb_addr;
-  qu->t.addr.onrrty = qu->t.addr.nrrty;
-  for (i = 0; i < qu->t.addr.nrrty; i++) {
+  for (i = 0; i < addr_nrrtypes; i++) {
+    if (!(which & (1 << i))) continue;
     err = adns__mkquery_frdgram(qu->ads, &qu->vb, &id, qd_dgram, qd_dglen,
-				DNS_HDRSIZE, qu->t.addr.rrty[i], qf);
+				DNS_HDRSIZE, addr_all_rrtypes[i], qf);
     if (err) goto x_error;
-    err = adns__internal_submit(qu->ads, &cqu, qu->typei, qu->t.addr.rrty[i],
+    err = adns__internal_submit(qu->ads, &cqu, &tinfo_addrsub,
+				addr_all_rrtypes[i] | qtf,
 				&qu->vb, id, qf, now, &ctx);
     if (err) goto x_error;
     cqu->answer->rrsz = qu->answer->rrsz;
@@ -574,10 +592,9 @@ x_error:
 }
 
 static adns_status addr_submit(adns_query parent, adns_query *query_r,
-			       vbuf *qumsg_vb, int id,
-			       const adns_rrtype *rrty, size_t nrrty,
+			       vbuf *qumsg_vb, int id, unsigned want,
 			       adns_queryflags flags, struct timeval now,
-			       const qcontext *ctx)
+			       qcontext *ctx)
 {
   /* This is effectively a substitute for adns__internal_submit, intended for
    * the case where the caller (possibly) only wants a subset of the
@@ -586,7 +603,9 @@ static adns_status addr_submit(adns_query parent, adns_query *query_r,
    *
    * Some differences: the query is linked onto the parent's children list
    * before exit (though the parent's state is not changed, and it is not
-   * linked into the childw list queue).
+   * linked into the childw list queue); and we fiddle with the `tinfo'
+   * portion of the context structure (yes, modifying *ctx), since this is,
+   * in fact, the main purpose of this function.
    */
 
   adns_state ads = parent->ads;
@@ -596,17 +615,14 @@ static adns_status addr_submit(adns_query parent, adns_query *query_r,
     (adns_r_addr & adns_rrt_reprmask) |
     (parent->answer->type & ~adns_rrt_reprmask);
 
+  ctx->tinfo.addr.want = want;
+  ctx->tinfo.addr.have = 0;
   err = adns__internal_submit(ads, &qu, adns__findtype(adns_r_addr),
-			      type, qumsg_vb, id, flags | adns__qf_nosend,
-			      now, ctx);
+			      type, qumsg_vb, id, flags, now, ctx);
   if (err) return err;
 
   qu->parent = parent;
   LIST_LINK_TAIL_PART(parent->children, qu, siblings.);
-
-  memcpy(qu->t.addr.rrty, rrty, nrrty*sizeof(*rrty));
-  qu->t.addr.nrrty = nrrty;
-  addr_subqueries(qu, now, qu->query_dgram, qu->query_dglen);
   *query_r = qu;
   return adns_s_ok;
 }
@@ -623,28 +639,20 @@ static adns_status copy_cname_from_child(adns_query parent, adns_query child)
 }
 
 static void done_addr_type(adns_query qu, adns_rrtype type)
-{
-  size_t i;
-
-  for (i = 0; i < qu->t.addr.nrrty && type != qu->t.addr.rrty[i]; i++);
-  assert(i < qu->t.addr.nrrty);
-  qu->t.addr.rrty[i] = qu->t.addr.rrty[--qu->t.addr.nrrty];
-  qu->t.addr.rrty[qu->t.addr.nrrty] = type;
-}
+  { qu->ctx.tinfo.addr.have |= addr_rrtypeflag(type); }
 
 static void icb_addr(adns_query parent, adns_query child)
 {
   adns_state ads = parent->ads;
   adns_answer *pans = parent->answer, *cans = child->answer;
-  struct timeval tvbuf;
+  struct timeval now;
   adns_status err;
-  const struct timeval *now = 0;
   int id;
 
   if (!(child->flags & adns__qf_addr_cname) &&
       (parent->flags & adns__qf_addr_answer) &&
-      (!pans->cname != !cans->cname ||
-       (pans->cname && strcmp(pans->cname, pans->cname) != 0))) {
+      (!!pans->cname != !!cans->cname ||
+       (pans->cname && strcmp(pans->cname, cans->cname) != 0))) {
     /* We've detected an inconsistency in CNAME records, and must deploy
      * countermeasures.
      */
@@ -659,7 +667,7 @@ static void icb_addr(adns_query parent, adns_query child)
       adns__transfer_interim(child, parent, cans->rrs.bytes);
       pans->rrs.bytes = cans->rrs.bytes;
       pans->nrrs = cans->nrrs;
-      parent->t.addr.nrrty = parent->t.addr.onrrty;
+      parent->ctx.tinfo.addr.have = 0;
       done_addr_type(parent, cans->type);
       err = copy_cname_from_child(parent, child); if (err) goto x_err;
     }
@@ -670,7 +678,7 @@ static void icb_addr(adns_query parent, adns_query child)
      * families.  The child's vbuf looks handy for this.
      */
     err = adns__mkquery(ads, &child->vb, &id, pans->cname,
-			strlen(pans->cname), adns__findtype(adns_r_addr),
+			strlen(pans->cname), &tinfo_addrsub,
 			adns_r_addr, parent->flags);
     if (err) goto x_err;
 
@@ -678,8 +686,9 @@ static void icb_addr(adns_query parent, adns_query child)
      * settled on.
      */
     adns__cancel_children(parent);
-    adns__must_gettimeofday(ads, &now, &tvbuf);
-    if (now) addr_subqueries(parent, *now, child->vb.buf, child->vb.used);
+    if (gettimeofday(&now, 0)) goto x_gtod;
+    addr_subqueries(parent, now, adns__qf_addr_cname,
+		    child->vb.buf, child->vb.used);
     return;
   }
 
@@ -698,8 +707,8 @@ static void icb_addr(adns_query parent, adns_query child)
     adns__cancel_children(parent);
     adns__free_interim(parent, pans->rrs.bytes);
     pans->rrs.bytes = 0; pans->nrrs = 0;
-    adns__must_gettimeofday(ads, &now, &tvbuf);
-    if (now) adns__search_next(ads, parent, *now);
+    if (gettimeofday(&now, 0)) goto x_gtod;
+    adns__search_next(ads, parent, now);
     return;
   }
 
@@ -719,15 +728,23 @@ static void icb_addr(adns_query parent, adns_query child)
   parent->flags |= adns__qf_addr_answer;
   return;
 
+x_gtod:
+  adns__diag(ads, -1, parent, "gettimeofday failed: %s", strerror(errno));
+  err = adns_s_systemfail;
+  goto x_err;
+
 x_err:
   adns__query_fail(parent, err);
 }
 
 static void qs_addr(adns_query qu, struct timeval now)
 {
-  addr_rrtypes(qu->ads, qu->answer->type, qu->flags,
-	       qu->t.addr.rrty, &qu->t.addr.nrrty);
-  addr_subqueries(qu, now, qu->query_dgram, qu->query_dglen);
+  if (!qu->ctx.tinfo.addr.want) {
+    qu->ctx.tinfo.addr.want =
+      addr_rrtypes(qu->ads, qu->answer->type, qu->flags);
+    qu->ctx.tinfo.addr.have = 0;
+  }
+  addr_subqueries(qu, now, 0, qu->query_dgram, qu->query_dglen);
 }
 
 /*
@@ -800,12 +817,11 @@ static adns_status pa_host_raw(const parseinfo *pai, int cbyte,
  */
 
 static adns_status pap_findaddrs(const parseinfo *pai, adns_rr_hostaddr *ha,
-				 adns_rrtype *rrty, size_t *nrrty_io,
-				 size_t addrsz, int *cbyte_io, int count,
-				 int dmstart) {
-  int rri, naddrs, j;
+				 unsigned *want_io, size_t addrsz,
+				 int *cbyte_io, int count, int dmstart) {
+  int rri, naddrs;
+  unsigned typef, want = *want_io;
   int type, class, rdlen, rdend, rdstart, ownermatched;
-  size_t nrrty = *nrrty_io;
   unsigned long ttl;
   adns_status st;
   
@@ -816,14 +832,9 @@ static adns_status pap_findaddrs(const parseinfo *pai, adns_rr_hostaddr *ha,
 			    pai->dgram, pai->dglen, dmstart, &ownermatched);
     if (st) return st;
     if (!ownermatched || class != DNS_CLASS_IN) continue;
-    for (j = 0; j < nrrty && type != (rrty[j] & adns_rrt_typemask); j++);
-    if (j >= nrrty) continue;
-    if (j < *nrrty_io) {
-      (*nrrty_io)--;
-      adns_rrtype t = rrty[j];
-      rrty[j] = rrty[*nrrty_io];
-      rrty[*nrrty_io] = t;
-    }
+    typef = addr_rrtypeflag(type);
+    if (!(want & typef)) continue;
+    want &= ~typef;
     if (!adns__vbuf_ensure(&pai->qu->vb, (naddrs+1)*addrsz)) R_NOMEM;
     adns__update_expires(pai->qu,ttl,pai->now);
     rdend = rdstart + rdlen;
@@ -839,17 +850,18 @@ static adns_status pap_findaddrs(const parseinfo *pai, adns_rr_hostaddr *ha,
     if (st) return st;
     ha->astatus= adns_s_ok;
 
-    if (!*nrrty_io) {
+    if (!want) {
       adns__isort(ha->addrs, naddrs, addrsz, pai->qu->vb.buf,
 		  div_addr, pai->ads);
     }
   }
+  *want_io = want;
   return adns_s_ok;
 }
 
 static void icb_hostaddr(adns_query parent, adns_query child) {
   adns_answer *cans= child->answer;
-  adns_rr_hostaddr *rrp= child->ctx.info.hostaddr;
+  adns_rr_hostaddr *rrp= child->ctx.pinfo.hostaddr;
   adns_state ads= parent->ads;
   adns_status st;
   size_t addrsz = gsz_addr(parent->answer->type);
@@ -891,8 +903,7 @@ static adns_status pap_hostaddr(const parseinfo *pai, int *cbyte_io,
   int id;
   adns_query nqu;
   adns_queryflags nflags;
-  adns_rrtype rrty[ADDR_MAXRRTYPES];
-  size_t nrrty;
+  unsigned want;
   size_t addrsz = gsz_addr(pai->qu->answer->type);
 
   dmstart= cbyte= *cbyte_io;
@@ -907,18 +918,15 @@ static adns_status pap_hostaddr(const parseinfo *pai, int *cbyte_io,
 
   cbyte= pai->nsstart;
 
-  addr_rrtypes(pai->ads, pai->qu->answer->type,
-	       pai->qu->flags, rrty, &nrrty);
+  want = addr_rrtypes(pai->ads, pai->qu->answer->type, pai->qu->flags);
 
-  st= pap_findaddrs(pai, rrp, rrty, &nrrty, addrsz,
-		    &cbyte, pai->nscount, dmstart);
+  st= pap_findaddrs(pai, rrp, &want, addrsz, &cbyte, pai->nscount, dmstart);
   if (st) return st;
-  if (!nrrty) return adns_s_ok;
+  if (!want) return adns_s_ok;
 
-  st= pap_findaddrs(pai, rrp, rrty, &nrrty, addrsz,
-		    &cbyte, pai->arcount, dmstart);
+  st= pap_findaddrs(pai, rrp, &want, addrsz, &cbyte, pai->arcount, dmstart);
   if (st) return st;
-  if (!nrrty) return adns_s_ok;
+  if (!want) return adns_s_ok;
 
   st= adns__mkquery_frdgram(pai->ads, &pai->qu->vb, &id,
 			    pai->dgram, pai->dglen, dmstart,
@@ -927,12 +935,12 @@ static adns_status pap_hostaddr(const parseinfo *pai, int *cbyte_io,
 
   ctx.ext= 0;
   ctx.callback= icb_hostaddr;
-  ctx.info.hostaddr= rrp;
+  ctx.pinfo.hostaddr= rrp;
   
   nflags= adns_qf_quoteok_query | (pai->qu->flags & adns__qf_afmask);
   if (!(pai->qu->flags & adns_qf_cname_loose)) nflags |= adns_qf_cname_forbid;
   
-  st= addr_submit(pai->qu, &nqu, &pai->qu->vb, id, rrty, nrrty,
+  st= addr_submit(pai->qu, &nqu, &pai->qu->vb, id, want,
 		  nflags, pai->now, &ctx);
   if (st) return st;
 
@@ -1132,7 +1140,7 @@ static void icb_ptr(adns_query parent, adns_query child) {
     return;
   }
 
-  queried= &parent->ctx.info.ptr_parent_addr.addr;
+  queried= &parent->ctx.tinfo.ptr.addr.addr;
   for (i=0, found=cans->rrs.bytes; i<cans->nrrs; i++, found += cans->rrsz) {
     if (!memcmp(queried,found,cans->rrsz)) {
       if (!parent->children.head) {
@@ -1148,24 +1156,28 @@ static void icb_ptr(adns_query parent, adns_query child) {
   adns__query_fail(parent,adns_s_inconsistent);
 }
 
+static adns_status ckl_ptr(adns_state ads, adns_queryflags flags,
+			   union checklabel_state *css, qcontext *ctx,
+			   int labnum, const char *label, int lablen)
+{
+  if (lablen) {
+    if (adns__revparse_label(&css->ptr, labnum, label,lablen))
+      return adns_s_querydomainwrong;
+  } else {
+    if (adns__revparse_done(&css->ptr, labnum,
+			    &ctx->tinfo.ptr.rev_rrtype,
+			    &ctx->tinfo.ptr.addr))
+      return adns_s_querydomainwrong;
+  }
+  return adns_s_ok;
+}
+
 static adns_status pa_ptr(const parseinfo *pai, int dmstart,
 			  int max, void *datap) {
-  static const struct {
-    const afinfo *ai;
-    const char *const tail[3];
-  } expectdomain[] = {
-    { &adns__inet_afinfo, { DNS_INADDR_ARPA, 0 } },
-    { &adns__inet6_afinfo, { DNS_IP6_ARPA, 0 } }
-  };
-  enum { n_ed = sizeof(expectdomain)/sizeof(expectdomain[0]) };
-  
   char **rrp= datap;
   adns_status st;
-  struct afinfo_addr *ap;
-  findlabel_state fls;
-  byte ipv[n_ed][32];
-  int cbyte, i, j, foundj = -1, lablen, labstart, id, f, ac;
-  const char *tp;
+  adns_rrtype rrtype = pai->qu->ctx.tinfo.ptr.rev_rrtype;
+  int cbyte, id;
   adns_query nqu;
   qcontext ctx;
 
@@ -1175,64 +1187,17 @@ static adns_status pa_ptr(const parseinfo *pai, int dmstart,
   if (st) return st;
   if (cbyte != max) return adns_s_invaliddata;
 
-  ap= &pai->qu->ctx.info.ptr_parent_addr;
-  if (!ap->ai) {
-    adns__findlabel_start(&fls, pai->ads, -1, pai->qu,
-			  pai->qu->query_dgram, pai->qu->query_dglen,
-			  pai->qu->query_dglen, DNS_HDRSIZE, 0);
-
-    f = (1 << n_ed) - 1; /* superposition of address types */
-    for (i = 0;; i++) {
-      st= adns__findlabel_next(&fls,&lablen,&labstart); assert(!st);
-      if (lablen <= 0) break;
-      for (j = 0; j < n_ed; j++) {
-	if (!(f & (1 << j))) continue;
-	if (i < expectdomain[j].ai->nrevcomp) {
-	  ac = expectdomain[j].ai->rev_parsecomp(
-	    pai->qu->query_dgram + labstart, lablen);
-	  if (ac < 0) goto mismatch;
-	  assert(i < sizeof(ipv[j]));
-	  ipv[j][i] = ac;
-	} else {
-	  tp = expectdomain[j].tail[i - expectdomain[j].ai->nrevcomp];
-	  if (!tp ||
-	      strncmp(pai->qu->query_dgram + labstart, tp, lablen) != 0 ||
-	      tp[lablen] != 0)
-	    goto mismatch;
-	}
-	continue;
-
-      mismatch:
-	f &= ~(1 << j);
-	if (!f) return adns_s_querydomainwrong;
-      }
-    }
-
-    if (lablen < 0) return adns_s_querydomainwrong;
-    for (j = 0; j < n_ed; j++) {
-      if (!(f & (1 << j))) continue;
-      if (i >= expectdomain[j].ai->nrevcomp &&
-	  !expectdomain[j].tail[i - expectdomain[j].ai->nrevcomp])
-	{ foundj = j; continue; }
-      f &= ~(1 << j);
-      if (!f) return adns_s_querydomainwrong;
-    }
-    assert(foundj >= 0 && f == (1 << foundj)); /* collapsed to a single type */
-
-    ap->ai = expectdomain[foundj].ai;
-    ap->ai->rev_mkaddr(&ap->addr, ipv[foundj]);
-  }
-
   st= adns__mkquery_frdgram(pai->ads, &pai->qu->vb, &id,
 			    pai->dgram, pai->dglen, dmstart,
-			    ap->ai->rrtype, adns_qf_quoteok_query);
+			    rrtype, adns_qf_quoteok_query);
   if (st) return st;
 
   ctx.ext= 0;
   ctx.callback= icb_ptr;
-  memset(&ctx.info,0,sizeof(ctx.info));
-  st= adns__internal_submit(pai->ads, &nqu, adns__findtype(ap->ai->rrtype),
-			    ap->ai->rrtype, &pai->qu->vb, id,
+  memset(&ctx.pinfo,0,sizeof(ctx.pinfo));
+  memset(&ctx.tinfo,0,sizeof(ctx.tinfo));
+  st= adns__internal_submit(pai->ads, &nqu, adns__findtype(rrtype),
+			    rrtype, &pai->qu->vb, id,
 			    adns_qf_quoteok_query, pai->now, &ctx);
   if (st) return st;
 
@@ -1441,36 +1406,18 @@ static adns_status cs_soa(vbuf *vb, const void *datap) {
 }
 
 /*
- * _srv*  (pa*2,di,cs*2,qdpl,postsort)
+ * _srv*  (pa*2,di,cs*2,ckl,postsort)
  */
 
-static adns_status qdpl_srv(adns_state ads,
-			    const char **p_io, const char *pe, int labelnum,
-			    char label_r[DNS_MAXDOMAIN], int *ll_io,
-			    adns_queryflags flags,
-			    const typeinfo *typei) {
-  int useflags;
-  const char *p_orig;
-  adns_status st;
-
-  if (labelnum < 2 && !(flags & adns_qf_quoteok_query)) {
-    useflags= adns_qf_quoteok_query;
-    p_orig= *p_io;
-  } else {
-    useflags= flags;
-    p_orig= 0;
-  }
-  st= adns__qdpl_normal(ads, p_io,pe, labelnum,label_r, ll_io, useflags,typei);
-  if (st) return st;
-
-  if (p_orig) {
-    int ll= *ll_io;
-    if (!ll || label_r[0]!='_')
-      return adns_s_querydomaininvalid;
-    if (memchr(p_orig+1, '\\', pe - (p_orig+1)))
-      return adns_s_querydomaininvalid;
+static adns_status ckl_srv(adns_state ads, adns_queryflags flags,
+			   union checklabel_state *css, qcontext *ctx,
+			   int labnum, const char *label, int lablen)
+{
+  if (labnum < 2 && !(flags & adns_qf_quoteok_query)) {
+    if (!lablen || label[0] != '_') return adns_s_querydomaininvalid;
+    label++; lablen--;
   }
-  return adns_s_ok;
+  return adns__ckl_hostname(ads, flags, css, ctx, labnum, label, lablen);
 }
 
 static adns_status pap_srv_begin(const parseinfo *pai, int *cbyte_io, int max,
@@ -1686,14 +1633,14 @@ static void mf_flat(adns_query qu, void *data) { }
 
 #define DEEP_TYPE(code,rrt,fmt,memb,parser,comparer,printer)	\
 { adns_r_##code & adns_rrt_reprmask, rrt,fmt,TYPESZ_M(memb),	\
-    mf_##memb, printer,parser,comparer, adns__qdpl_normal,0,0,0 }
+    mf_##memb, printer,parser,comparer, adns__ckl_hostname,0,0,0 }
 #define FLAT_TYPE(code,rrt,fmt,memb,parser,comparer,printer)	\
 { adns_r_##code & adns_rrt_reprmask, rrt,fmt,TYPESZ_M(memb),	\
-    mf_flat, printer,parser,comparer, adns__qdpl_normal,0,0,0 }
+    mf_flat, printer,parser,comparer, adns__ckl_hostname,0,0,0 }
 #define XTRA_TYPE(code,rrt,fmt,memb,parser,comparer,printer,		   \
-		  makefinal,qdpl,postsort,getrrsz,sender)		   \
+		  makefinal,ckl,postsort,getrrsz,sender)		   \
 { adns_r_##code & adns_rrt_reprmask, rrt,fmt,TYPESZ_M(memb), makefinal,	   \
-    printer,parser,comparer,qdpl,postsort,getrrsz,sender }
+    printer,parser,comparer,ckl,postsort,getrrsz,sender }
 
 static const typeinfo typeinfos[] = {
 /* Must be in ascending order of rrtype ! */
@@ -1710,20 +1657,25 @@ DEEP_TYPE(txt,    "TXT",   0,   manyistr,pa_txt,     0,        cs_txt        ),
 DEEP_TYPE(rp_raw, "RP",   "raw",strpair, pa_rp,      0,        cs_rp         ),
 FLAT_TYPE(aaaa,   "AAAA",  0,   in6addr, pa_in6addr, di_in6addr,cs_in6addr   ),
 XTRA_TYPE(srv_raw,"SRV",  "raw",srvraw , pa_srvraw,  di_srv,   cs_srvraw,
-				      mf_srvraw, qdpl_srv, postsort_srv, 0, 0),
+				       mf_srvraw, ckl_srv, postsort_srv, 0, 0),
 
 XTRA_TYPE(addr,   "A",  "addr", addr,    pa_addr,    di_addr,  cs_addr,
-			     mf_flat, adns__qdpl_normal, 0, gsz_addr, qs_addr),
+			    mf_flat, adns__ckl_hostname, 0, gsz_addr, qs_addr),
 DEEP_TYPE(ns,     "NS", "+addr",hostaddr,pa_hostaddr,di_hostaddr,cs_hostaddr ),
-DEEP_TYPE(ptr,    "PTR","checked",str,   pa_ptr,     0,        cs_domain     ),
+XTRA_TYPE(ptr,    "PTR","checked",str,   pa_ptr,     0,        cs_domain,
+						     mf_str, ckl_ptr, 0, 0, 0),
 DEEP_TYPE(mx,     "MX", "+addr",inthostaddr,pa_mx,   di_mx,    cs_inthostaddr),
 XTRA_TYPE(srv,    "SRV","+addr",srvha,   pa_srvha,   di_srv,   cs_srvha,
-				       mf_srvha, qdpl_srv, postsort_srv, 0, 0),
+					mf_srvha, ckl_srv, postsort_srv, 0, 0),
 
 DEEP_TYPE(soa,    "SOA","822",  soa,     pa_soa,     0,        cs_soa        ),
 DEEP_TYPE(rp,     "RP", "822",  strpair, pa_rp,      0,        cs_rp         ),
 };
 
+static const typeinfo tinfo_addrsub =
+XTRA_TYPE(none,	  "<addr>","sub",addr,	 pa_addr,    0,	       cs_addr,
+				  mf_flat, adns__ckl_hostname, 0, gsz_addr, 0);
+
 static const typeinfo typeinfo_unknown=
 DEEP_TYPE(unknown,0, "unknown",byteblock,pa_opaque,  0,        cs_opaque     );