RELEASE-CHECKLIST: Non-real mode (the default, now)
[adns] / changelog
CommitLineData
3212d4ff
IJ
1adns (1.5.0~rc1~) UPSTREAM; urgency=low
2
3 * WIP
4
5 -- Ian Jackson <ijackson@chiark.greenend.org.uk> Mon, 20 Oct 2014 02:29:45 +0100
6
90c1b41d 7adns (1.5.0~rc0) UPSTREAM; urgency=low
56569363
IJ
8
9 New features:
56569363
IJ
10 * Support for queries about IPv6 data in all applicable adns
11 query types (including AAAA, PTR, and adns_r_addr queries).
c019dfb2
IJ
12 (Thanks very much to Mark Wooding.)
13 * Support for transport over IPv6. (Thanks to Mark Wooding again.)
14 * adns_addr2text and adns_text2addr: Convenient functions for
15 converting between addresses and address literals.
56569363
IJ
16
17 Bugfixes:
18 * Fix a crashing bug in adnslogres. (Debian#392102.)
19 * Do all checks of checked PTR owner name before actually sending the
20 query, and reject IPv4 PTR owner names whose labels have leading zero
21 digits or values >255.
22
23 Build system fixes and improvements:
24 * `make clean' removes the pipes.
25 * Work around bugs in make (Debian #4073, #756123) affecting regress.
a63608e6 26 * Do not include Makefile and src/config.h in distribution tarball.
56569363
IJ
27
28 Regression test debugging improvements:
29 * Provide gdbwrap convenience script.
c019dfb2 30 * Honour ADNS_TEST_DEBUG env. var. (Mark Wooding.)
56569363
IJ
31
32 Other improvements:
b839df39 33 * Licence changed to GPLv3 (still LGPLv2 for adns.h).
c019dfb2 34 * Source code cleanups. (Some from Mark Wooding.)
56569363
IJ
35 * Now in git.
36 * Documentation and webpage updates.
37
90c1b41d 38 -- Ian Jackson <ijackson@chiark.greenend.org.uk> Mon, 20 Oct 2014 01:29:50 +0100
56569363 39
79f97001 40adns (1.4); urgency=low
47a6797e 41
42 Improvements for multithreaded programs:
43 * New documentation comment in adns.h explaining thread guarantees
44 (or lack of them), replaces `single-threaded' note at the top.
45 * Fix string conversion of adns_r_addr not to use a static buffer
46 (function csp_addr) so as to make thread promise true.
47 * Make an internal variable const-correct (expectdomain in pa_ptr).
48
79f97001 49 -- Ian Jackson <ian@davenant.greenend.org.uk> Tue, 17 Oct 2006 17:05:08 +0100
47a6797e 50
2448bf59 51adns (1.3); urgency=low
52
aef0409a 53 Portability fixes:
bf41c1c2 54 * Cast ptrdiff_t to int for %.*s length in adnsheloex and adnslogres,
55 as is required. (Report from Jim Meyering.)
aef0409a 56 * In configure.in, quote macro name argument to define() to
57 suppress spurious autoconf error. (Report from Mihai Ibanescu.)
58 * Use autoconf's values for {bin,lib,include}dir rather than inventing
0447b870 59 our own from @exec_prefix@, making configure --libdir work.
60 (Patch from Mihai Ibanescu.)
aef0409a 61 * Remove spurious `_' from {bin,lib,include}dir Makefile variables.
62 (Report from Mihai Ibanescu.)
d6e317f7 63 * Do away with `mismatch' variable in parse.c:adns__findrr_anychk so that
64 overzealous GCC cannot complain about members of eo_fls being
65 uninitialised. (Report from Jim Meyering.)
2448bf59 66
bb6fad18 67 -- Ian Jackson <ian@davenant.greenend.org.uk> Tue, 6 Jun 2006 20:22:30 +0100
2448bf59 68
000a608b 69adns (1.2); urgency=medium
e24bc510 70
e8bbac11 71 New features:
72 * Support for SRV RRs.
73 * Support for unknown RR types (according to RFC3597) via adns_r_unknown.
74 * Allow `;'-comments in resolv.conf (report from Colin Charles).
75 * New adnsheloex client courtesy of Tony Finch.
76 * New adns_init_logfn etc. for having logging use a callback function.
77
78 Bugfixes:
79 * Fix error in prototype in definition of adns__parse_domain.
80 * Add missing ENOTSOCK to hcommon.c.m4 (was already in hcommon.c!)
e24bc510 81
e8bbac11 82 Portability fixes prompted by Bernd Eckenfels, the Debian maintainer:
0ca555c6 83 * Correct type of various printf arguments: ptrdiff_t != int.
cb0a827b 84 * Do not print size of leaked blocks of memory (this causes
e8bbac11 85 a spurious regression test failure on some platforms).
deb1edb6 86 * Provide adns_if_none and adns_qf_none (which will help with compilers
87 which complain about plain `0' being passed where an enum is wanted).
e8bbac11 88 * adnstest converts some errno values to EFOOBAR: all of the ones
89 mentioned in adns.h, at least. This makes the regression test
90 more portable (fixes problem noticed by Bernd Eckenfels).
91 * Add -Wno-pointer-sign if GCC has that option.
0ca555c6 92
e8bbac11 93 Documentation improvements:
94 * Add documentation comment by definition of adns_r_ptr_raw type enum.
95 * Document in adns.h EINVAL from adns_init meaning bad configuration.
96 * Include several new references to related programs to README.html.
97 * Redacted the TODO list.
a14bea78 98 * New LICENCE.WAIVERS file for GPL-incompatility workarounds.
99 * Clarified GPL-vs-LGPL: a bit less hostile and a bit more mercenary.
e8bbac11 100 * Copyright notices updated.
101
102 Packaging changes:
a33a9e25 103 * Update MINOR to 2 and DISTVERSION and ADNS_VERSION_STRING to 1.2.
45f773b3 104 * Reran autoconf/autoheader (autoconf Debian 2.13-54).
e8bbac11 105 * Create $(bin_dir) and $(lib_dir) on `make install', and also
106 make a libadns.so.1 -> libadns.so.1.<minor> link. (Suggestions
107 and patch from Nix of esperi.org.uk.)
cc1cc02a 108 * Add .PHONY: install to Makefile, to help people with demented fs's.
b50b34c9 109 * Darwin listed in INSTALL.
e8bbac11 110
111 Minor test harness improvements:
112 * Hgettimeofday calls Tensurerecordfile (was Tensureinput/outputfile).
113 * Add bind(2) and listen(2) wrappers (for epithet, but harmless in adns).
07b2653a 114
000a608b 115 -- Ian Jackson <ian@davenant.greenend.org.uk> Sat, 8 Apr 2006 15:41:28 +0100
07b2653a 116
ac015392 117adns (1.1); urgency=medium
118
c5f033db 119 Major bugfixes:
237ce710 120 * Do not spin if connect() fails immediately (!)
ac015392 121 * Stop searching on a CNAME (even if it's broken).
122 * When search list runs out, _qf_owner sets owner to query domain.
0d66e373 123 * Fix bogus multiple updates to p in transmit.c (!)
c5f033db 124
125 Portability improvements:
0d66e373 126 * Fix up spurious #undef's in hredirect.h.
91e6c883 127 * Don't use <sys/select.h> any more, it was a mistake made in pre-1.0
128 (and there doesn't seem to be much explanation why).
0f15dd7b 129 * Understand and sort of check OpenBSD `lookup' resolv.conf directive.
0d66e373 130 * #include <stdlib.h> in internal.h (for abort etc).
5aabad0d 131 * Always #include <sys/types.h> before <sys/socket.h> (for FreeBSD 4.6).
c5f033db 132
133 Cosmetic and documentation improvements:
1ec67696 134 * Added wishlist entry re configurable port no.
4fde3e92 135 * Problem with SERVFAIL in TODO.
3a68c787 136 * README.html: mentioned Jarle Aase's Windows port, and other fixes.
b5bc5076 137 * Some better source code formatting/wrapping.
ac015392 138
20b6c0bb 139 -- Ian Jackson <ian@davenant.greenend.org.uk> Tue, 1 Jul 2003 22:55:29 +0100
ac015392 140
ad7e1412 141adns (1.0); urgency=medium
0a4fd9ed 142
5a0be244 143 Bugfixes:
7672a872 144 * Treat 8-bit characters in email addrs as RFC822 `special' (=> quote).
6b891b5a 145 * Fix incorrect `compressed datagram contains loop' error.
5a0be244 146 * Actually compile shared libraries by default !
98e3fa81 147 * Fix adnsresfilter usage message to include correct default timeout.
5a0be244 148
bef232ae 149 General improvements:
98e3fa81 150 * adnshost, adnslogres, adnsresfilter have options for config override.
151 * adnsresfilter has --debug option.
295cf525 152 * Improvements to adnslogres (incl. new -c option) from Tony Finch.
aa3ffb57 153 * adnslogres has --help option, all utilities support --version.
239d2e4d 154 * Documentation improved somewhat, including new GPL-vs-LGPL file.
b6922f88 155
156 Changes for non-BETA release:
157 * Change shared library soname to 1.0.
8e5a4960 158 * Do not install adnstest test utility.
bef232ae 159
160 Regression test improvements:
161 * Tests now include adnshost, adnslogres and adnsresfilter.
0ebff22d 162 * Test cancellation both before and after query completion.
163
e64c0ea5 164 Portability fixes and cleanups:
165 * adnstest: setvbuf(stdout,...) before we do first output.
5a0be244 166 * Cope with compilers that don't do `inline'.
e64c0ea5 167 * Add and fix various missing system #includes.
57700a3b 168 * Find install-sh properly when we need to use it, and chmod it +x.
5a0be244 169 * Do not use variadic macro, use stdarg instead (adnslogres.c).
e64c0ea5 170 * Regression tests work even if some syscalls are already macros.
5a0be244 171 * #include "config.h" before "adns.h".
5a0be244 172 * Cast a sizeof(...) in src/event.c to unsigned long before printing.
f9476535 173 * Add pre-generated versions of m4-generated files in regress/.
5a0be244 174 * Kill bogus warning, adh-main.c: `arg2' might be used uninitialized ...
e32d0f9e 175 * Add extra {...} near adnslogres.c:167 to kill spurious warning.
5a0be244 176 * Use `printf' instead of `echo -n'.
e64c0ea5 177 * Add list of tested platforms in INSTALL file.
0a4fd9ed 178
cada00d4 179 -- Ian Jackson <ian@davenant.greenend.org.uk> Sun, 17 Sep 2000 15:15:58 +0100
0a4fd9ed 180
b6922f88 181adns (0.9) BETA; urgency=high
8fedcfeb 182
1ed3dba4 183 Bug fixes:
184 * Don't make _processany always kill the TCP connection with the message
185 `TCP connection failed: poll/select: exceptional condition detected'.
3dbef075 186 * Call MEM_ROUND in __transfer_interim (avoids assert fail
187 `qu->interim_allocd>=0' on some platforms eg 64 bit).
51cc4d90 188 * adnsresfilter doesn't resolve textual prefixes of addresses (eg,
189 10.0.0.1 out of 10.0.0.123) if input happens to block at that point.
fb901bf5 190 * Do not spin if TCP connection blocks for writing (and add test case).
191 * Fail queries if TCP dies repeatedly, rather than retrying many times.
192 * Do not abort in a couple of places if TCP unexpectedly broken.
d1cac7c0 193 * Do not free something twice if query fails and is then cancelled.
8fedcfeb 194
1ed3dba4 195 Portability/compilation fixes:
196 * Move `extern "C" {' to after #include <...>'s.
a5e80149 197 * Pass LDFLAGS from configure on to ld via settings.make.in.
198 * make clean deletes *.so and *.so.* files.
48337073 199 * New --disable-dynamic configure option for non-ELF systems.
a0c76eee 200 * Use AC_PROG_INSTALL (=> perhaps install-sh), to avoid bad `install'.
1ed3dba4 201
0544e0de 202 Minor improvements:
203 * Do not print warning if sendto() gives EAGAIN.
51cc4d90 204 * adnsresfilter default timeout changed to 1000ms.
e24e7155 205 * m1test script can invoke `hrecord' differently.
fc938da6 206 * regress/output-<case>.report file contains more useful info.
4423286d 207 * TODO list and other docs updated slightly.
d00d4b99 208 * Referrals with RD+RA set, or RCODE=Refused, don't generate warnings,
209 just debug messages. BIND does this kind of thing all the time.
0544e0de 210
806b3e0a 211 -- Ian Jackson <ian@davenant.greenend.org.uk> Wed, 9 Aug 2000 16:59:28 +0100
8fedcfeb 212
626f8695 213adns (0.8) BETA; urgency=medium
34a2240e 214
4fad263d 215 Bugfixes:
6c68a593 216 * Race near adns_beforeselect which could cause infinite timeout fixed
217 (it's now less agressive, and will more often return a zero timeout.)
428bd682 218 * Fixed infrequent race causing assertion failure in adns__tcp_broken
219 `ads->tcpstate == server_connecting || ads->tcpstate == server_ok'.
d0bed398 220 * Spurious `server failure on unidentifiable query' warning suppressed.
428bd682 221 * If we get a referral, don't also always complain falsely about RD==0.
2658c305 222 * adnslogres: cast chars to unsigned char before using ctype.h macros.
4fad263d 223 * In _beforeselect, global failure now means zero timeout, and in
224 tcp_events, really never try to do anything with the TCP connection if
225 act is zero. This might possibly cause an infinite delay (ie, lockup)
226 if things go badly wrong *and* a really unlikely race happens.
227 * Test suite `lines of syscall left' value is correct; !0 is failure.
228
229 Portability fixes:
230 * install-sh (from autoconf 2.12 Debian r13) included.
7c409027 231 * adnslogres: do not call equivalent of printf("%.*s",0,(char*)0).
4fad263d 232
233 Documentation improvements:
2b61beb8 234 * Security/performance note added, about local nameservers and DNSSEC.
06f8e611 235 * Documented that adns_rr_info _rr_hostaddr ( ) for address list
236 means permanent failure, and ? means temporary failure.
237 * Typo (*now for now in _beforeselect description) in adns.h fixed.
3d5cde09 238 * Copyright notices updated.
4fad263d 239
240 Changes to produce more defensive code:
241 * In adns_wait, assert that the timeout is not infinite.
242 * Make qu->id start out as -2 when initially allocated.
d0bed398 243
3d5cde09 244 -- Ian Jackson <ian@davenant.greenend.org.uk> Sun, 7 May 2000 23:37:13 +0100
d0bed398 245
16d7d2b5 246adns (0.7) BETA; urgency=medium
1a0a5dbd 247
2b1c6979 248 * New adns_submit_reverse_any for eg RBL lookups, and corresponding
249 option to adnshost.
1a0a5dbd 250 * README updated (from www home page).
2b1c6979 251
252 * In answers, quote all except alphanums and - _ / + (and document).
253 * Don't reject specials in cnames even without adns_qf_quotefail_cname.
4b2c4f8a 254 * Better checking of long domain names and labels in queries.
2b1c6979 255 * answer->owner may be null on error. Documented, and adnshost copes.
256 * Better reporting of unexpected or weird replies from nameserver.
5b9dd636 257 * Add test case for recursion (infinite loop) domain compression.
1a0a5dbd 258
d233258a 259 -- Ian Jackson <ian@davenant.greenend.org.uk> Thu, 2 Mar 2000 01:55:53 +0000
1a0a5dbd 260
8c586086 261adns (0.6) BETA; urgency=high
3d1ae6ea 262
eed63b97 263 Core library bugfixes:
3905bfc2 264 * Avoid infinite timeouts, causing lockup, when they should be zero !
c62edca0 265 * TCP handling revamped (avoids undefined behaviour due to reentrancy).
8c586086 266 * Do not fail assertion if _qf_owner, _qf_search, domain ends in `.'.
914a5ff5 267 * Many memory leaks fixed.
eed63b97 268
8ef9f155 269 Cool new utility:
270 * adnsresfilter is like `cat' but converts addresses to names without
271 delaying the output. Pipe `netstat -n', `tcpdump -ln', etc. into it.
272
eed63b97 273 Test and client program bug and portability fixes:
696e536a 274 * Dynamic library building works properly.
4f257c51 275 * adnshost prints somewhat better messages about some wrong usages.
eed63b97 276 * Include <stdlib.h> and <sys/types.h> in adnshost.h.
8c7e7322 277 * adnslogres: parsing and error checking improved (Tony Finch).
914a5ff5 278 * Regression tests can cope with zero-length reads.
279 * Regression tests check for memory leaks.
c62edca0 280 * adnstest copes with empty query type list.
281 * adnstest uninitialised memory bug fixed.
bb149f75 282
283 General improvements
413b9ad6 284 * Better control of adnshost output and error messages (new -F options).
8ef9f155 285 * New adns_if_logpid option (functionality suggested by Tony Finch).
592aa664 286 * New fanftest test program from Tony Finch (ignored by `make install').
fb7fbb66 287 * Reads /etc/resolv-adns.conf if it exists.
8ef9f155 288 * Declare flags parameters as enums again, not ints.
3d1ae6ea 289
33d35d14 290 -- Ian Jackson <ian@davenant.greenend.org.uk> Wed, 24 Nov 1999 17:13:03 +0000
3d1ae6ea 291
b6a93f16 292adns (0.5) unstable; urgency=high
9ea0d219 293
23d78b27 294 New features:
d7449548 295 * adnslogres, ~100x faster replacement for Apache logresolve;
23d78b27 296 Thanks to Tony Finch for the program and the performance figure.
d7449548 297 * Internal consistency checking with assert if right options set.
298 * adns_wait_poll function like adns_wait but uses poll, not select.
299 * adns_reverse_submit function for easy in-addr queries.
300 * adns_errtypeabbrev funcion for getting eg "permfail" from _s_nodata.
301 * adnshost utility for scripts and the like (rather alpha).
23d78b27 302
b365d68a 303 Incompatible changes:
304 * RRs with mailboxes never rejected due to strange chars if _raw.
305 * Lack of a mailbox produces `.' not `<>'.
4ac46883 306 * Better usage messages (and no default query domain) for adnstest.
226c5eef 307 * Return EAGAIN from _check instead of EWOULDBLOCK.
ac77ffc1 308 * adns_rr_info on _r_mx etc. shows status type abbrev and status number.
b365d68a 309
dd34699e 310 Bugfixes:
70ad7a2a 311 * Do not invoke __autosys indirectly from __procdgram (result: coredump
312 usually in memmove, unless adns_if_noautosys was used).
313 * Do not scramble innards when a query on the output queue is cancelled.
6a578b2c 314 * Do not close tcp socket twice.
b365d68a 315 * Mailboxes containing spaces in their names are quoted.
57d68ed1 316 * Give ESRCH, not EAGAIN, if _check called with no queries outstanding.
b365d68a 317 * adns_rr_hostaddr naddrs is -1 on temporary failure (as documented).
b365d68a 318 * Reject TXT RRs with no strings.
05db5bce 319 * Correct error messages for qname CNAME foo, foo CNAME bar.
f31af9c9 320 * adns_processany actually does something.
70ad7a2a 321 * Fixed typos in adns.h.
dd34699e 322
323 General improvements:
324 * Promise not to change fds in adns_beforepoll (if now is specified).
05db5bce 325 * Improved textual error string for _s_prohibitedcname.
0aa7cba0 326 * New comment in adns_processany and return 0 (not r which is 0).
c8c7c813 327 * Documentation of resolv.conf directives and options, and of environment
328 variables understood, in adns.h
1671459c 329 * Regression test scripts set EF_DISABLE_BANNER (for Electric Fence).
9ea0d219 330
dd34699e 331 Portability and build improvements:
332 * Give install the '-c' flag (otherwise some delete the original !).
333 * Do not remove top-level Makefile on `make clean'.
334 * Don't complain so much about poll(2) tests if not available.
335 * Do not give -u 0 -g 0 options to install.
0aa7cba0 336 * Remove trailing , from some enums in adns.h.
9310ea4d 337 * Dynamically linked clients now made with -l, so as to avoid rpath.
338 * Do not use $^ in make rules (should help with non-GNU make).
679ff49d 339 * Declare flags parameters as ints not enums because C++ is crap.
dd34699e 340
a7b2012b 341 -- Ian Jackson <ian@davenant.greenend.org.uk> Wed, 13 Oct 1999 02:24:35 +0100
9ea0d219 342
a7c94417 343adns (0.4) unstable; urgency=high
54f4a80a 344
14975d6b 345 General important bugfixes:
8b3d55e3 346 * make _qf_owner work if _qf_search not specified, and test it (oops!)
d855b532 347 * ads->configerrno now initialised (in setup.c).
14975d6b 348 * timercmp(,,<=) doesn't work - use !timercmp(,,>).
4218fb9a 349 * Changed memory semantics of internal queries to fix bugs.
14975d6b 350 * Restarting a TCP-using query (eg due to CNAME) doesn't abort.
351
352 Fixes for handling of broken kinds of reply:
ebf4877a 353 * Only accept a reply from the subset of servers we sent the query.
14975d6b 354 * Ignore CNAME(s) in answer after RR(s) (and test).
355
356 Other bugfixes and improvements:
357 * adns_s_systemfail is in table of errors (for eg adns_strerror).
5ab2163b 358 * Do not ship config.cache, Makefile, etc.
14975d6b 359 * Improvements to install instructions, TODO, etc.
636b69b1 360 * Regression tests compile on systems without poll(2).
361 * Do not install adnstest_s.
636b69b1 362 * _submit returns ENOSYS, not adns_s_unknownquery; documented, tested.
14975d6b 363 * <adns.h> includes <sys/types.h>, <sys/time.h>, <unistd.h>.
54f4a80a 364
5ab2163b 365 -- Ian Jackson <ian@davenant.greenend.org.uk> Thu, 5 Aug 1999 01:17:38 +0100
54f4a80a 366
dcc8e442 367adns (0.3) unstable; urgency=low
368
620c146d 369 Incompatible changes:
370 * Low adns_status values (below adns_s_max_tempfail) renumbered to make
371 room for future locally-induced and locally-detected errors.
372 * Event loop functions for use by select(2) renamed and tidied up.
373
9da4a044 374 Features / improvements:
375 * New adns_errabbrev() for getting status abbreviation strings.
376 * regress/checkall prints summary list of failed tests, if any.
620c146d 377 * Event loop functions for poll(2), and some raw variants.
fc6a52ae 378 * adnstest has ability to use poll(2), and user can set initflags.
379 * checkall prints passed list as well as failed list, if any failed.
9f81b2a2 380 * You can iterate over outstanding queries (but only once at a time).
9da4a044 381
dcc8e442 382 Bugfixes:
9da4a044 383 * Non-RFC822 mailbox `domain' formatting now works, and clarified.
384 * Rejection of bad characters in domains (without quoteok) works.
dcc8e442 385 * Clean up parents from adns->childw (otherwise would abort/segfault).
386 * In adnstest, allocate enough space for, and terminate, query types.
9da4a044 387 * In adnstest, don't print errno values as adns_status values.
dcc8e442 388
389 * Added TODO file.
669f9df5 390 * Made adnstest.c test context pointers.
9da4a044 391
bd3fce65 392 -- Ian Jackson <ian@davenant.greenend.org.uk> Thu, 15 Jul 1999 00:23:12 +0100
dcc8e442 393
71a6ff46 394adns (0.2) experimental; urgency=low
395
73c4c523 396 Portability fixes for compilation on various platforms:
71a6ff46 397 * Include <sys/socket.h> and <netinet/in.h> in files with <arpa/inet.h>.
398 * Don't use GCC union assignment feature (.rrs=0 => .rrs.untyped=0).
399 * Explictly cast things to [const] struct sockaddr* in syscall args.
400 * Check whether we need -lsocket.
0f091044 401 * Include <sys/times.h> in a few more files.
402 * Include <unistd.h> and <sys/time.h> for select.
8b5269f2 403 * Look for inet_aton and inet_ntoa (in -lnsl and -lsocket).
053b9ec6 404 * LDLIBS removed from dependency lists (some makes don't support this).
405 * An `ambiguous else' warning from some compilers in types.c is removed.
73c4c523 406
407 Other changes:
7544c6df 408 * Added COPYING (copy of the GPL).
51e80719 409 * Regression test failure output improved.
81937f1c 410 * Missing targets in regress/Makefile.in added.
f9f23683 411 * Regression test doesn't rely on value of fcntl flags eg O_NONBLOCK.
71a6ff46 412
f9f23683 413 -- Ian Jackson <ian@davenant.greenend.org.uk> Thu, 20 May 1999 00:27:32 +0100
71a6ff46 414
11b35193 415adns (0.1) experimental; urgency=low
416
417 * Initial public alpha release.
418
71a6ff46 419 -- Ian Jackson <ian@davenant.greenend.org.uk> Sat, 17 April 1999 17:42:19
11b35193 420
421Local variables:
422mode: debian-changelog
bfc2c80e 423fill-column: 75
11b35193 424End: